From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2396C63697 for ; Mon, 23 Nov 2020 21:48:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D473206CA for ; Mon, 23 Nov 2020 21:48:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YcNnH80O"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="mMt/hU8u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731904AbgKWVsE (ORCPT ); Mon, 23 Nov 2020 16:48:04 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:38558 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730108AbgKWVsE (ORCPT ); Mon, 23 Nov 2020 16:48:04 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1606168081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w1uCKrC/JVnFefj87bZYqeaIDv0yyNdd4LhM7mGuDJM=; b=YcNnH80Owhk67icq+BuAaMvftswTwmhM+6euUdaRP7WH3T+rzPpJstyMnAnylH/NUwzqUo ZQrS0RmAPYvBjjLnr4LpGTm8v0sSlD18iq5nCw2lZx3WXOpAS63Tp+BfZtPdNM1BD34108 VYnzKJh/bF9SujydFoFCIzQwqCgIgfLg4x+BX4gNkGtjk3nOeaPEpSeeJw6e9WybLoupX3 m5NVmypPWg1ykY9tZ+MmwxOcGBWUa2LBVQwce5TSLeeJ5Ny1hRHS4DTFHrKRmCX+TsDn+4 cq1ml6AdNowL6NbKTl1jWudmP4lGWwmBUrYSykWVmMgRuDWnvIQdK+hmUDGWGA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1606168081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w1uCKrC/JVnFefj87bZYqeaIDv0yyNdd4LhM7mGuDJM=; b=mMt/hU8u/OTPxDuQKILiP1HhdRxZ4zvs1L8KKoZmzhLl6g612jVzcISf+J/GJPD6Y6RT8s rYLoGs+JkPIjWpCA== To: Alex Belits , "nitesh\@redhat.com" , "frederic\@kernel.org" Cc: Prasun Kapoor , "linux-api\@vger.kernel.org" , "davem\@davemloft.net" , "trix\@redhat.com" , "mingo\@kernel.org" , "catalin.marinas\@arm.com" , "rostedt\@goodmis.org" , "linux-kernel\@vger.kernel.org" , "peterx\@redhat.com" , "linux-arch\@vger.kernel.org" , "mtosatti\@redhat.com" , "will\@kernel.org" , "peterz\@infradead.org" , "leon\@sidebranch.com" , "linux-arm-kernel\@lists.infradead.org" , "pauld\@redhat.com" , "netdev\@vger.kernel.org" Subject: Re: [PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function In-Reply-To: <0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com> References: <8d887e59ca713726f4fcb25a316e1e932b02823e.camel@marvell.com> <0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com> Date: Mon, 23 Nov 2020 22:48:01 +0100 Message-ID: <87eekjn3se.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alex, On Mon, Nov 23 2020 at 17:56, Alex Belits wrote: why are you insisting on adding 'task_isolation: ' as prefix to every single patch? That's wrong as I explained before. The prefix denotes the affected subsystem and 'task_isolation' is _NOT_ a subsystem. It's the project name you are using but the affected code belongs to the memory management subsystem and if you run git log mm/vmstat.c you might get a hint what the proper prefix is, i.e. 'mm/vmstat: ' > In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") > the quiet_vmstat() function became asynchronous, in the sense that > the vmstat work was still scheduled to run on the core when the > function returned. For task isolation, we need a synchronous This changelog is useless because how should someone not familiar with the term 'task isolation' figure out what that means? It's not the reviewers job to figure that out. Again: Go read and adhere to Documentation/process/* Aside of that your patches are CR/LF inflicted. Please fix your work flow and tools. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E3C5C63697 for ; Mon, 23 Nov 2020 21:48:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6E0820663 for ; Mon, 23 Nov 2020 21:48:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lpYm54E/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YcNnH80O"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="mMt/hU8u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E0820663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I+MQjfXw7hWB7DWM1418PGq3o71OO8cdSbF9H/+xWts=; b=lpYm54E/Tei61nO5IrkLSVhMT wqiLQPggsI+NUlh5meiuk+MqYB6xNzyFsXd/6CeNnTNXvLr+kj2S4eG5ODCnU62GL4zlHrTVkhOCH Ppk54Vzw35FGFohVQC+uaz42X9llALz0V9dVCvsj2SNnIJp0ih12MQWv90+SeUklMR/KMn2YBRSAU QZ1252kfMDWtnZsaMuay/K6GUu3pSt5iAYHhICdQ4AR3nmXsKXCJWc7BIdKUcY/zOmgJg1+S9TsRt laT9+kvZaZc3Q8sokzH5v/vW3f6UIUB+G3PNqP7HzEElfHNc0IndbGlSLVOL6ecIvDqTLG0mOs7zv woyA72MvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khJgt-0006oq-9t; Mon, 23 Nov 2020 21:48:07 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khJgq-0006nJ-Qr for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 21:48:05 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1606168081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w1uCKrC/JVnFefj87bZYqeaIDv0yyNdd4LhM7mGuDJM=; b=YcNnH80Owhk67icq+BuAaMvftswTwmhM+6euUdaRP7WH3T+rzPpJstyMnAnylH/NUwzqUo ZQrS0RmAPYvBjjLnr4LpGTm8v0sSlD18iq5nCw2lZx3WXOpAS63Tp+BfZtPdNM1BD34108 VYnzKJh/bF9SujydFoFCIzQwqCgIgfLg4x+BX4gNkGtjk3nOeaPEpSeeJw6e9WybLoupX3 m5NVmypPWg1ykY9tZ+MmwxOcGBWUa2LBVQwce5TSLeeJ5Ny1hRHS4DTFHrKRmCX+TsDn+4 cq1ml6AdNowL6NbKTl1jWudmP4lGWwmBUrYSykWVmMgRuDWnvIQdK+hmUDGWGA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1606168081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w1uCKrC/JVnFefj87bZYqeaIDv0yyNdd4LhM7mGuDJM=; b=mMt/hU8u/OTPxDuQKILiP1HhdRxZ4zvs1L8KKoZmzhLl6g612jVzcISf+J/GJPD6Y6RT8s rYLoGs+JkPIjWpCA== To: Alex Belits , "nitesh\@redhat.com" , "frederic\@kernel.org" Subject: Re: [PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function In-Reply-To: <0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com> References: <8d887e59ca713726f4fcb25a316e1e932b02823e.camel@marvell.com> <0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com> Date: Mon, 23 Nov 2020 22:48:01 +0100 Message-ID: <87eekjn3se.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_164805_005476_1976CBB1 X-CRM114-Status: UNSURE ( 7.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arch@vger.kernel.org" , "pauld@redhat.com" , "catalin.marinas@arm.com" , "peterz@infradead.org" , Prasun Kapoor , "mtosatti@redhat.com" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "davem@davemloft.net" , "leon@sidebranch.com" , "netdev@vger.kernel.org" , "peterx@redhat.com" , "trix@redhat.com" , "linux-api@vger.kernel.org" , "will@kernel.org" , "mingo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Alex, On Mon, Nov 23 2020 at 17:56, Alex Belits wrote: why are you insisting on adding 'task_isolation: ' as prefix to every single patch? That's wrong as I explained before. The prefix denotes the affected subsystem and 'task_isolation' is _NOT_ a subsystem. It's the project name you are using but the affected code belongs to the memory management subsystem and if you run git log mm/vmstat.c you might get a hint what the proper prefix is, i.e. 'mm/vmstat: ' > In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") > the quiet_vmstat() function became asynchronous, in the sense that > the vmstat work was still scheduled to run on the core when the > function returned. For task isolation, we need a synchronous This changelog is useless because how should someone not familiar with the term 'task isolation' figure out what that means? It's not the reviewers job to figure that out. Again: Go read and adhere to Documentation/process/* Aside of that your patches are CR/LF inflicted. Please fix your work flow and tools. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel