From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7A6C433DF for ; Wed, 10 Jun 2020 07:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C8C5207ED for ; Wed, 10 Jun 2020 07:34:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="T9b/7hcS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726274AbgFJHeD (ORCPT ); Wed, 10 Jun 2020 03:34:03 -0400 Received: from esa1.microchip.iphmx.com ([68.232.147.91]:1426 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726081AbgFJHeD (ORCPT ); Wed, 10 Jun 2020 03:34:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1591774442; x=1623310442; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=H0mGDxnEZFg00erzET87dowCc530Z3JfzOW8o5EaPg0=; b=T9b/7hcSkVDJ3djV0ATTkwLzimMAUHiqseG8Qa9M8EZxv4n005OvIgAS TkJlHUs6Af5VbrRjgYBWP7zgfdnN2oEaxdFMRqbd4vwqiu2F+qwpYhraB 7bJ1rd5UAYIRfHEhCDH2Yx1UbY8uJr629fyNlpTXEWFjH+KQYvhkWVg33 hUCDAMXjjdSoaC/E7EbmudsexpABmvUpna23T9QfGAuWRwoqb9Z/bia6t fMtRmxtjpooikBxOStk1BEh/FRh6MoTyjGVdOLqo5mLBb4JWChAzJz/MS v/kwmXKa4TF4kkbQg8i1MK/OaXnmQCT6lX3nydm9x2UcpSln0Qhyzj2Q2 Q==; IronPort-SDR: tRCMCf0cC57dobeWM9CJUIUQEBcjnDkCmmimitTGVaen/LOuUjJfmwx/3UvyiNCGvpEpxrEMxV i+fTQD7Jj/YMoq28YKgrurZQZG8LWNIVhLHfRwhwWyWNu6adaMHKRvFsLsAstV2A6PXoZMQ4yW PmU+Zqxib8XRTAJ3u+e2Kizd0AyEww1SRjyhWZPcKRaZ19R0Eqqn92I2+UC40fPzDrUnvmV0UP 0N/+33BfpjbARGiOuL7HUqz26a0R+IK+AMczYoJ/CyhlHXm01hRpjd3axPeR0ZPhHVA/vMn75m 0HI= X-IronPort-AV: E=Sophos;i="5.73,495,1583218800"; d="scan'208";a="82940802" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Jun 2020 00:34:01 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Wed, 10 Jun 2020 00:34:01 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3 via Frontend Transport; Wed, 10 Jun 2020 00:33:59 -0700 References: <20200609072828.9088-1-lars.povlsen@microchip.com> <5f006733-52b6-e003-5db3-2ff16596918c@roeck-us.net> From: Lars Povlsen To: Guenter Roeck CC: Lars Povlsen , Jean Delvare , Microchip Linux Driver Support , , , , , Alexandre Belloni Subject: Re: [PATCH v2 0/3] hwmon: Adding support for Microchip Sparx5 SoC In-Reply-To: <5f006733-52b6-e003-5db3-2ff16596918c@roeck-us.net> Date: Wed, 10 Jun 2020 09:33:58 +0200 Message-ID: <87eeqnidcp.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Guenter Roeck writes: > On 6/9/20 12:28 AM, Lars Povlsen wrote: >> This is an add-on series to the main SoC Sparx5 series >> (Message-ID: <20200608123024.5330-1-lars.povlsen@microchip.com>) >> >> Changes in v2: >> - Changes in driver as per review comments >> > > And you expect the reviewers/maintainers to remember what those were ? > Well, I can see that this might not be the case. I'll be a little more specific next time. Sorry about that. For the record, it was: - Removed unnecessary #includes - Statement reordering in s5_read() - Replaced EINVAL with EIO - Add 'break' in default: case statement. - Removed extra () - Removed superfluous initialization I got some more comments from Jonathan Cameron , so there will be another round. Thanks, ---Lars >> Lars Povlsen (3): >> dt-bindings: hwmon: Add Sparx5 temperature sensor >> arm64: dts: sparx5: Add hwmon temperature sensor >> hwmon: sparx5: Add Sparx5 SoC temperature driver >> >> .../bindings/hwmon/microchip,sparx5-temp.yaml | 39 +++++ >> arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 + >> drivers/hwmon/Kconfig | 10 ++ >> drivers/hwmon/Makefile | 2 +- >> drivers/hwmon/sparx5-temp.c | 152 ++++++++++++++++++ >> 5 files changed, 208 insertions(+), 1 deletion(-) >> create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml >> create mode 100644 drivers/hwmon/sparx5-temp.c >> >> -- >> 2.27.0 >> -- Lars Povlsen, Microchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E81C433E0 for ; Wed, 10 Jun 2020 07:34:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66892207ED for ; Wed, 10 Jun 2020 07:34:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iSuhnuU1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="pJoZi4ht" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66892207ED Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-Reply-To:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1GtSO1pKmpRNQu/bs/xE+Il18lG/p8wIUvZ+A02bKkg=; b=iSuhnuU10RaBj4ivoZXRdNG1RN h1zmevFRKXN1cmVMqayL9ynp0Vko+ouz9XWbSKdBTMzyIkgsbbgANCB4ir7tlp/MR0am9n5uQ9yUw dBUPnUoe/xuEJ9kSsGeLe34FfKvZSz/CvN6z43oeCKRi2VQ9XSZEiaIMPzyNVcjA5zwA6vZmb6OBg Ea+TMZJ/AAmscnOVPtf53hbL/UoxS/5c5jrYBf6J1EUH6m5j4faCRvoAzHA4MsmO7w3A+EUNY99Pw H8Kyzdrg8/wBJ+k2oleIISG4IMQVPtYtgGqP/oC65aQTIrEf7AJchSfE/NreIZFsYPMWQP1NoGgRw 7FxC7UFg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jivFP-0007vw-Ez; Wed, 10 Jun 2020 07:34:07 +0000 Received: from esa1.microchip.iphmx.com ([68.232.147.91]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jivFM-0007vO-OO for linux-arm-kernel@lists.infradead.org; Wed, 10 Jun 2020 07:34:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1591774444; x=1623310444; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=H0mGDxnEZFg00erzET87dowCc530Z3JfzOW8o5EaPg0=; b=pJoZi4htaIgh6XAcON5G1C+YLah4AiqN0vGtVj6aB89XhjslASisT3Ix eKx5KHBca+6LmUVR/O55TQD+7vFEP5lleCmRoOJo8zFbjHs87TlpMKrlh osfYFz6PjmCO2aBBA883VMvDV+L8MALxdbL05Lwa+TagnnbzPvbfNctYU 7cg8gfCHlWFreg1MD320dIk3AqLnBftzTTG0fImDJxlrQi9T1JEX1a7aa LxkCFQ11olwFnyTQlGPnlYc5J2honlL1Nz07TE1HlMFSlmBuES9e2ZlUF jR7RQ/RnO/8HwZLX7cK91gFFh5lVdWKH59rptbZRxx27J3dFa7DyHhAp7 A==; IronPort-SDR: tRCMCf0cC57dobeWM9CJUIUQEBcjnDkCmmimitTGVaen/LOuUjJfmwx/3UvyiNCGvpEpxrEMxV i+fTQD7Jj/YMoq28YKgrurZQZG8LWNIVhLHfRwhwWyWNu6adaMHKRvFsLsAstV2A6PXoZMQ4yW PmU+Zqxib8XRTAJ3u+e2Kizd0AyEww1SRjyhWZPcKRaZ19R0Eqqn92I2+UC40fPzDrUnvmV0UP 0N/+33BfpjbARGiOuL7HUqz26a0R+IK+AMczYoJ/CyhlHXm01hRpjd3axPeR0ZPhHVA/vMn75m 0HI= X-IronPort-AV: E=Sophos;i="5.73,495,1583218800"; d="scan'208";a="82940802" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Jun 2020 00:34:01 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Wed, 10 Jun 2020 00:34:01 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3 via Frontend Transport; Wed, 10 Jun 2020 00:33:59 -0700 References: <20200609072828.9088-1-lars.povlsen@microchip.com> <5f006733-52b6-e003-5db3-2ff16596918c@roeck-us.net> From: Lars Povlsen To: Guenter Roeck Subject: Re: [PATCH v2 0/3] hwmon: Adding support for Microchip Sparx5 SoC In-Reply-To: <5f006733-52b6-e003-5db3-2ff16596918c@roeck-us.net> Date: Wed, 10 Jun 2020 09:33:58 +0200 Message-ID: <87eeqnidcp.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200610_003404_831433_00578F76 X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, Alexandre Belloni , Jean Delvare , linux-kernel@vger.kernel.org, Microchip Linux Driver Support , Lars Povlsen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Guenter Roeck writes: > On 6/9/20 12:28 AM, Lars Povlsen wrote: >> This is an add-on series to the main SoC Sparx5 series >> (Message-ID: <20200608123024.5330-1-lars.povlsen@microchip.com>) >> >> Changes in v2: >> - Changes in driver as per review comments >> > > And you expect the reviewers/maintainers to remember what those were ? > Well, I can see that this might not be the case. I'll be a little more specific next time. Sorry about that. For the record, it was: - Removed unnecessary #includes - Statement reordering in s5_read() - Replaced EINVAL with EIO - Add 'break' in default: case statement. - Removed extra () - Removed superfluous initialization I got some more comments from Jonathan Cameron , so there will be another round. Thanks, ---Lars >> Lars Povlsen (3): >> dt-bindings: hwmon: Add Sparx5 temperature sensor >> arm64: dts: sparx5: Add hwmon temperature sensor >> hwmon: sparx5: Add Sparx5 SoC temperature driver >> >> .../bindings/hwmon/microchip,sparx5-temp.yaml | 39 +++++ >> arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 + >> drivers/hwmon/Kconfig | 10 ++ >> drivers/hwmon/Makefile | 2 +- >> drivers/hwmon/sparx5-temp.c | 152 ++++++++++++++++++ >> 5 files changed, 208 insertions(+), 1 deletion(-) >> create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml >> create mode 100644 drivers/hwmon/sparx5-temp.c >> >> -- >> 2.27.0 >> -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel