* [Buildroot] [PATCH] package/jailhouse: fix misc details in Config.in
@ 2019-11-10 13:26 Thomas Petazzoni
2019-11-10 18:33 ` Yann E. MORIN
2019-11-18 12:50 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-11-10 13:26 UTC (permalink / raw)
To: buildroot
This commit fixes a number of small minor details in the jailhouse
Config.in file:
- The Config.in comment is in the middle of the main
BR2_PACKAGE_JAILHOUSE option and its sub-options, causing the
sub-options to not be indented properly in menuconfig
- jailhouse was capitalized as Jailhouse, while all Buildroot
packages in menuconfig use small letters, so use "jailhouse"
everywhere
- no need to repeat "jailhouse" in the prompt of the sub-option for
helper scripts, since it is not properly indented under the main
jailhouse option.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/jailhouse/Config.in | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/package/jailhouse/Config.in b/package/jailhouse/Config.in
index 5b9ecc7b7b..e792900d76 100644
--- a/package/jailhouse/Config.in
+++ b/package/jailhouse/Config.in
@@ -1,5 +1,5 @@
config BR2_PACKAGE_JAILHOUSE
- bool "Jailhouse"
+ bool "jailhouse"
depends on BR2_aarch64 || BR2_x86_64
depends on BR2_LINUX_KERNEL
help
@@ -7,21 +7,21 @@ config BR2_PACKAGE_JAILHOUSE
https://github.com/siemens/jailhouse
-comment "Jailhouse needs a Linux kernel to be built"
- depends on BR2_aarch64 || BR2_x86_64
- depends on !BR2_LINUX_KERNEL
-
if BR2_PACKAGE_JAILHOUSE
config BR2_PACKAGE_JAILHOUSE_HELPER_SCRIPTS
- bool "Jailhouse helper scripts"
+ bool "helper scripts"
depends on BR2_PACKAGE_PYTHON
help
Python-based helpers for the Jailhouse Hypervisor.
https://github.com/siemens/jailhouse
-comment "Jailhouse helper scripts require Python"
+comment "jailhouse helper scripts require Python"
depends on !BR2_PACKAGE_PYTHON
endif
+
+comment "jailhouse needs a Linux kernel to be built"
+ depends on BR2_aarch64 || BR2_x86_64
+ depends on !BR2_LINUX_KERNEL
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/jailhouse: fix misc details in Config.in
2019-11-10 13:26 [Buildroot] [PATCH] package/jailhouse: fix misc details in Config.in Thomas Petazzoni
@ 2019-11-10 18:33 ` Yann E. MORIN
2019-11-18 12:50 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2019-11-10 18:33 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2019-11-10 14:26 +0100, Thomas Petazzoni spake thusly:
> This commit fixes a number of small minor details in the jailhouse
> Config.in file:
>
> - The Config.in comment is in the middle of the main
> BR2_PACKAGE_JAILHOUSE option and its sub-options, causing the
> sub-options to not be indented properly in menuconfig
>
> - jailhouse was capitalized as Jailhouse, while all Buildroot
> packages in menuconfig use small letters, so use "jailhouse"
> everywhere
>
> - no need to repeat "jailhouse" in the prompt of the sub-option for
> helper scripts, since it is not properly indented under the main
> jailhouse option.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks. I have however done a slight modification,
see below...
> ---
> package/jailhouse/Config.in | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/package/jailhouse/Config.in b/package/jailhouse/Config.in
> index 5b9ecc7b7b..e792900d76 100644
> --- a/package/jailhouse/Config.in
> +++ b/package/jailhouse/Config.in
> @@ -1,5 +1,5 @@
> config BR2_PACKAGE_JAILHOUSE
> - bool "Jailhouse"
> + bool "jailhouse"
> depends on BR2_aarch64 || BR2_x86_64
> depends on BR2_LINUX_KERNEL
> help
> @@ -7,21 +7,21 @@ config BR2_PACKAGE_JAILHOUSE
>
> https://github.com/siemens/jailhouse
>
> -comment "Jailhouse needs a Linux kernel to be built"
> - depends on BR2_aarch64 || BR2_x86_64
> - depends on !BR2_LINUX_KERNEL
> -
> if BR2_PACKAGE_JAILHOUSE
>
> config BR2_PACKAGE_JAILHOUSE_HELPER_SCRIPTS
> - bool "Jailhouse helper scripts"
> + bool "helper scripts"
> depends on BR2_PACKAGE_PYTHON
> help
> Python-based helpers for the Jailhouse Hypervisor.
>
> https://github.com/siemens/jailhouse
>
> -comment "Jailhouse helper scripts require Python"
> +comment "jailhouse helper scripts require Python"
I've also dropped 'jailhouse' from this comment.
Regards,
Yann E. MORIN.
> depends on !BR2_PACKAGE_PYTHON
>
> endif
> +
> +comment "jailhouse needs a Linux kernel to be built"
> + depends on BR2_aarch64 || BR2_x86_64
> + depends on !BR2_LINUX_KERNEL
> --
> 2.21.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/jailhouse: fix misc details in Config.in
2019-11-10 13:26 [Buildroot] [PATCH] package/jailhouse: fix misc details in Config.in Thomas Petazzoni
2019-11-10 18:33 ` Yann E. MORIN
@ 2019-11-18 12:50 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-11-18 12:50 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> This commit fixes a number of small minor details in the jailhouse
> Config.in file:
> - The Config.in comment is in the middle of the main
> BR2_PACKAGE_JAILHOUSE option and its sub-options, causing the
> sub-options to not be indented properly in menuconfig
> - jailhouse was capitalized as Jailhouse, while all Buildroot
> packages in menuconfig use small letters, so use "jailhouse"
> everywhere
> - no need to repeat "jailhouse" in the prompt of the sub-option for
> helper scripts, since it is not properly indented under the main
> jailhouse option.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2019.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-18 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-10 13:26 [Buildroot] [PATCH] package/jailhouse: fix misc details in Config.in Thomas Petazzoni
2019-11-10 18:33 ` Yann E. MORIN
2019-11-18 12:50 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.