From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A99C5DF60 for ; Wed, 6 Nov 2019 02:57:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C9F421D81 for ; Wed, 6 Nov 2019 02:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="dsB+rMGY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C9F421D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6128B16E1; Wed, 6 Nov 2019 03:56:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6128B16E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573009025; bh=P+lJpvfEEPCw74GT3JbcrrbnOh6mOX1XGcJuNOqryjY=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dsB+rMGYj4ifFSIecscWJOptCk7VS2WKFMgrJ89/F4KFN0WFHWQcAGDnp5T9NjlFw mJO6oHgJIJ2c0a5nBHfvdubeVs71udpSsehJB+mtZP9WDcP+ZIknnCar8LqcCZ6ELO eWoZt/GKQEkDHAEAvN7ZXKZ8vTvONVa6SMdPreEU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CD8C4F80321; Wed, 6 Nov 2019 03:56:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C8C4AF803D0; Wed, 6 Nov 2019 03:56:13 +0100 (CET) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id 12E99F80291 for ; Wed, 6 Nov 2019 03:56:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 12E99F80291 Date: 06 Nov 2019 11:56:06 +0900 X-IronPort-AV: E=Sophos;i="5.68,272,1569250800"; d="scan'208";a="30939363" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 06 Nov 2019 11:56:06 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 2EF3B400A0E5; Wed, 6 Nov 2019 11:56:06 +0900 (JST) Message-ID: <87eeylhfw9.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: "Sridharan, Ranjani" In-Reply-To: References: <87wocdhkz6.wl-kuninori.morimoto.gx@renesas.com> <87k18dhkw2.wl-kuninori.morimoto.gx@renesas.com> <87ftj1hgly.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA , Mark Brown Subject: Re: [alsa-devel] [PATCH 9/9] ASoC: soc-core: call snd_soc_dapm_shutdown() at soc_cleanup_card_resources() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Ranjani Thank you for your feedback > Do you mean [7/9] patch ? > It merges snd_soc_instantiate_card() and snd_soc_bind_card(). > Thus, snd_soc_bind_card() is still exist. > Or am I misunderstanding ? > > Oh yes, sorry I misread that. So why not remove cleanup_card_resources and move everything to snd_soc_unbind_card()? Good question :) Indeed snd_soc_bind_card() and snd_soc_unbind_card() are paired function. We want to merge cleanup_card_resources() and snd_soc_unbind_card(). But, can you check snd_soc_unbind_card() ? unbind() is caring - card->instantiated - snd_soc_flush_all_delayed_work(card); - unbind_card_list Actually I tried to merge cleanup() and unbind() into one, but then, the code became not simple. So I gave up this time. But, we might can do it in the future if soc-core is more cleanuped/simpled. Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel