From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 02/16] drm/i915: Drop assertion that ce->pin_mutex guards state updates Date: Tue, 22 Oct 2019 15:25:00 +0300 Message-ID: <87eez57ysj.fsf@gaia.fi.intel.com> References: <20191021080226.537-1-chris@chris-wilson.co.uk> <20191021080226.537-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EF4F6E28E for ; Tue, 22 Oct 2019 12:25:50 +0000 (UTC) In-Reply-To: <20191021080226.537-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gVGhlIGFj dHVhbCBjb25kaXRpb25zIGFyZSB0aGF0IHdlIGtub3cgdGhlIEdQVSBpcyBub3QgYWNjZXNzaW5n IHRoZQo+IGNvbnRleHQsIGFuZCB3ZSBob2xkIGEgcGluIG9uIHRoZSBjb250ZXh0IGltYWdlIHRv IGFsbG93IENQVSBhY2Nlc3MuIFdlCj4gdXNlZCBhIGZha2UgbG9jayBvbiBjZS0+cGluX211dGV4 IHNvIHRoYXQgd2UgY291bGQgdHJ5IGFuZCB1c2UgbG9ja2RlcAo+IHRvIGFzc2VydCB0aGF0IGFj Y2VzcyBpcyBzZXJpYWxpc2VkLCBidXQgdGhlIHZhcmlvdXMgZGlmZmVyZW50Cj4gaGFyZGlycS9z b2Z0aXJxIGNvbnRleHRzIHdoZXJlIHdlIG5lZWQgdG8gKmZha2UqIGhvbGRpbmcgdGhlIHBpbl9t dXRleAo+IGFyZSBjYXVzaW5nIG1vcmUgdHJvdWJsZS4KPgo+IFN0aWxsIGl0IHdvdWxkIGJlIG5p Y2UgaWYgd2UgZGlkIGhhdmUgYSB3YXkgdG8gcmVhc3N1cmUgb3Vyc2VsdmVzIHRoYXQKPiB0aGUg ZGlyZWN0IHVwZGF0ZSB0byB0aGUgY29udGV4dCBpbWFnZSBpcyBzZXJpYWxpc2VkIHdpdGggR1BV IGV4ZWN1dGlvbi4KPiBJbiB0aGUgbWVhbnRpbWUsIHN0b3AgbG9ja2RlcCBjb21wbGFpbmluZyBh Ym91dCBmYWxzZSBpcnEgaW52ZXJzaW9ucy4KPgo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJl ZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE5MjMKPiBTaWduZWQtb2ZmLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KCkEgdGFkIHNhZCB0aGF0IHRoZSBw cmljZS9wYXlvdXQgZGlkbid0IHByb3ZpZGUuCgpBY2tlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlr YS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9ndC9pbnRlbF9scmMuYyAgICB8IDE2IC0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvZ3Qvc2VsZnRlc3RfbHJjLmMgfCAgNSAtLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3BlcmYuYyAgICAgICB8ICAxIC0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAyMiBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9s cmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5jCj4gaW5kZXggZDAwODhk MDIwMjIwLi5mOWYzZTk4NWJiNzkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3QvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMu Ywo+IEBAIC0yMzUsMTYgKzIzNSw2IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19pbml0X3JlZ19z dGF0ZSh1MzIgKnJlZ19zdGF0ZSwKPiAgCQkJCSAgICAgY29uc3Qgc3RydWN0IGludGVsX3Jpbmcg KnJpbmcsCj4gIAkJCQkgICAgIGJvb2wgY2xvc2UpOwo+ICAKPiAtc3RhdGljIHZvaWQgX19jb250 ZXh0X3Bpbl9hY3F1aXJlKHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjZSkKPiAtewo+IC0JbXV0ZXhf YWNxdWlyZSgmY2UtPnBpbl9tdXRleC5kZXBfbWFwLCAyLCAwLCBfUkVUX0lQXyk7Cj4gLX0KPiAt Cj4gLXN0YXRpYyB2b2lkIF9fY29udGV4dF9waW5fcmVsZWFzZShzdHJ1Y3QgaW50ZWxfY29udGV4 dCAqY2UpCj4gLXsKPiAtCW11dGV4X3JlbGVhc2UoJmNlLT5waW5fbXV0ZXguZGVwX21hcCwgMCwg X1JFVF9JUF8pOwo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZCBtYXJrX2VpbyhzdHJ1Y3QgaTkxNV9y ZXF1ZXN0ICpycSkKPiAgewo+ICAJaWYgKGk5MTVfcmVxdWVzdF9jb21wbGV0ZWQocnEpKQo+IEBA IC0yNzkyLDkgKzI3ODIsNiBAQCBzdGF0aWMgdm9pZCBfX2V4ZWNsaXN0c19yZXNldChzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUsIGJvb2wgc3RhbGxlZCkKPiAgCWNlID0gcnEtPmh3X2Nv bnRleHQ7Cj4gIAlHRU1fQlVHX09OKCFpOTE1X3ZtYV9pc19waW5uZWQoY2UtPnN0YXRlKSk7Cj4g IAo+IC0JLyogUHJvY2xhaW0gd2UgaGF2ZSBleGNsdXNpdmUgYWNjZXNzIHRvIHRoZSBjb250ZXh0 IGltYWdlISAqLwo+IC0JX19jb250ZXh0X3Bpbl9hY3F1aXJlKGNlKTsKPiAtCj4gIAlycSA9IGFj dGl2ZV9yZXF1ZXN0KHJxKTsKPiAgCWlmICghcnEpIHsKPiAgCQkvKiBJZGxlIGNvbnRleHQ7IHRp ZHkgdXAgdGhlIHJpbmcgc28gd2UgY2FuIHJlc3RhcnQgYWZyZXNoICovCj4gQEAgLTI4NjAsNyAr Mjg0Nyw2IEBAIHN0YXRpYyB2b2lkIF9fZXhlY2xpc3RzX3Jlc2V0KHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSwgYm9vbCBzdGFsbGVkKQo+ICAJX19leGVjbGlzdHNfcmVzZXRfcmVnX3N0 YXRlKGNlLCBlbmdpbmUpOwo+ICAJX19leGVjbGlzdHNfdXBkYXRlX3JlZ19zdGF0ZShjZSwgZW5n aW5lKTsKPiAgCWNlLT5scmNfZGVzYyB8PSBDVFhfREVTQ19GT1JDRV9SRVNUT1JFOyAvKiBwYXJh bm9pZDogR1BVIHdhcyByZXNldCEgKi8KPiAtCV9fY29udGV4dF9waW5fcmVsZWFzZShjZSk7Cj4g IAo+ICB1bndpbmQ6Cj4gIAkvKiBQdXNoIGJhY2sgYW55IGluY29tcGxldGUgcmVxdWVzdHMgZm9y IHJlcGxheSBhZnRlciB0aGUgcmVzZXQuICovCj4gQEAgLTQ1MDIsNyArNDQ4OCw2IEBAIHZvaWQg aW50ZWxfbHJfY29udGV4dF9yZXNldChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4g IAkJCSAgICBib29sIHNjcnViKQo+ICB7Cj4gIAlHRU1fQlVHX09OKCFpbnRlbF9jb250ZXh0X2lz X3Bpbm5lZChjZSkpOwo+IC0JX19jb250ZXh0X3Bpbl9hY3F1aXJlKGNlKTsKPiAgCj4gIAkvKgo+ ICAJICogV2Ugd2FudCBhIHNpbXBsZSBjb250ZXh0ICsgcmluZyB0byBleGVjdXRlIHRoZSBicmVh ZGNydW1iIHVwZGF0ZS4KPiBAQCAtNDUyOCw3ICs0NTEzLDYgQEAgdm9pZCBpbnRlbF9scl9jb250 ZXh0X3Jlc2V0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCWludGVsX3Jpbmdf dXBkYXRlX3NwYWNlKGNlLT5yaW5nKTsKPiAgCj4gIAlfX2V4ZWNsaXN0c191cGRhdGVfcmVnX3N0 YXRlKGNlLCBlbmdpbmUpOwo+IC0JX19jb250ZXh0X3Bpbl9yZWxlYXNlKGNlKTsKPiAgfQo+ICAK PiAgI2lmIElTX0VOQUJMRUQoQ09ORklHX0RSTV9JOTE1X1NFTEZURVNUKQo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9zZWxmdGVzdF9scmMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2d0L3NlbGZ0ZXN0X2xyYy5jCj4gaW5kZXggNWRjNjc5NzgxYTA4Li43NTE2ZDFjOTA5 MjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Qvc2VsZnRlc3RfbHJjLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9zZWxmdGVzdF9scmMuYwo+IEBAIC0xNjgs MTIgKzE2OCw3IEBAIHN0YXRpYyBpbnQgbGl2ZV91bmxpdGVfcmVzdG9yZShzdHJ1Y3QgaW50ZWxf Z3QgKmd0LCBpbnQgcHJpbykKPiAgCQl9Cj4gIAkJR0VNX0JVR19PTighY2VbMV0tPnJpbmctPnNp emUpOwo+ICAJCWludGVsX3JpbmdfcmVzZXQoY2VbMV0tPnJpbmcsIGNlWzFdLT5yaW5nLT5zaXpl IC8gMik7Cj4gLQo+IC0JCWxvY2FsX2lycV9kaXNhYmxlKCk7IC8qIGFwcGVhc2UgbG9ja2RlcCAq Lwo+IC0JCV9fY29udGV4dF9waW5fYWNxdWlyZShjZVsxXSk7Cj4gIAkJX19leGVjbGlzdHNfdXBk YXRlX3JlZ19zdGF0ZShjZVsxXSwgZW5naW5lKTsKPiAtCQlfX2NvbnRleHRfcGluX3JlbGVhc2Uo Y2VbMV0pOwo+IC0JCWxvY2FsX2lycV9lbmFibGUoKTsKPiAgCj4gIAkJcnFbMF0gPSBpZ3Rfc3Bp bm5lcl9jcmVhdGVfcmVxdWVzdCgmc3BpbiwgY2VbMF0sIE1JX0FSQl9DSEVDSyk7Cj4gIAkJaWYg KElTX0VSUihycVswXSkpIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9wZXJmLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BlcmYuYwo+IGluZGV4IGQyYWM1 MWZlNGYwNC4uMzEzMGIwYzdlZDgzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcGVyZi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wZXJmLmMKPiBA QCAtMjYxNSw3ICsyNjE1LDYgQEAgdm9pZCBpOTE1X29hX2luaXRfcmVnX3N0YXRlKGNvbnN0IHN0 cnVjdCBpbnRlbF9jb250ZXh0ICpjZSwKPiAgCXN0cnVjdCBpOTE1X3BlcmZfc3RyZWFtICpzdHJl YW07Cj4gIAo+ICAJLyogcGVyZi5leGNsdXNpdmVfc3RyZWFtIHNlcmlhbGlzZWQgYnkgZ2VuOF9j b25maWd1cmVfYWxsX2NvbnRleHRzKCkgKi8KPiAtCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmNlLT5w aW5fbXV0ZXgpOwo+ICAKPiAgCWlmIChlbmdpbmUtPmNsYXNzICE9IFJFTkRFUl9DTEFTUykKPiAg CQlyZXR1cm47Cj4gLS0gCj4gMi4yNC4wLnJjMAo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeA==