From: Michael Ellerman <mpe@ellerman.id.au> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nayna <nayna@linux.vnet.ibm.com> Cc: Nayna Jain <nayna@linux.ibm.com>, linuxppc-dev@ozlabs.org, linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Jeremy Kerr <jk@ozlabs.org>, Matthew Garret <matthew.garret@nebula.com>, Mimi Zohar <zohar@linux.ibm.com>, Claudio Carvalho <cclaudio@linux.ibm.com>, George Wilson <gcwilson@linux.ibm.com>, Elaine Palmer <erpalmer@us.ibm.com>, Eric Ricther <erichte@linux.ibm.com>, Oliver O'Halloran <oohall@gmail.com> Subject: Re: [PATCH] sysfs: add BIN_ATTR_WO() macro Date: Tue, 03 Sep 2019 13:37:02 +1000 [thread overview] Message-ID: <87ef0yrqxt.fsf@mpe.ellerman.id.au> (raw) In-Reply-To: <20190826150153.GD18418@kroah.com> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > This variant was missing from sysfs.h, I guess no one noticed it before. > > Turns out the powerpc secure variable code can use it, so add it to the > tree for it, and potentially others to take advantage of, instead of > open-coding it. > > Reported-by: Nayna Jain <nayna@linux.ibm.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > > I'll queue this up to my tree for 5.4-rc1, but if you want to take this > in your tree earlier, feel free to do so. OK. This series is blocked on the firmware support going in, so at the moment it might miss v5.4 anyway. So this going via your tree is no problem. If it does make it into v5.4 we can do a fixup patch to use the new macro once everything's in Linus' tree. cheers > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h > index 965236795750..5420817ed317 100644 > --- a/include/linux/sysfs.h > +++ b/include/linux/sysfs.h > @@ -196,6 +196,12 @@ struct bin_attribute { > .size = _size, \ > } > > +#define __BIN_ATTR_WO(_name) { \ > + .attr = { .name = __stringify(_name), .mode = 0200 }, \ > + .store = _name##_store, \ > + .size = _size, \ > +} > + > #define __BIN_ATTR_RW(_name, _size) \ > __BIN_ATTR(_name, 0644, _name##_read, _name##_write, _size) > > @@ -208,6 +214,9 @@ struct bin_attribute bin_attr_##_name = __BIN_ATTR(_name, _mode, _read, \ > #define BIN_ATTR_RO(_name, _size) \ > struct bin_attribute bin_attr_##_name = __BIN_ATTR_RO(_name, _size) > > +#define BIN_ATTR_WO(_name, _size) \ > +struct bin_attribute bin_attr_##_name = __BIN_ATTR_WO(_name, _size) > + > #define BIN_ATTR_RW(_name, _size) \ > struct bin_attribute bin_attr_##_name = __BIN_ATTR_RW(_name, _size) > > -- > 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nayna <nayna@linux.vnet.ibm.com> Cc: linux-efi@vger.kernel.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Eric Ricther <erichte@linux.ibm.com>, Nayna Jain <nayna@linux.ibm.com>, linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>, Claudio Carvalho <cclaudio@linux.ibm.com>, Matthew Garret <matthew.garret@nebula.com>, linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>, Jeremy Kerr <jk@ozlabs.org>, Elaine Palmer <erpalmer@us.ibm.com>, Oliver O'Halloran <oohall@gmail.com>, linux-integrity@vger.kernel.org, George Wilson <gcwilson@linux.ibm.com> Subject: Re: [PATCH] sysfs: add BIN_ATTR_WO() macro Date: Tue, 03 Sep 2019 13:37:02 +1000 [thread overview] Message-ID: <87ef0yrqxt.fsf@mpe.ellerman.id.au> (raw) In-Reply-To: <20190826150153.GD18418@kroah.com> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > This variant was missing from sysfs.h, I guess no one noticed it before. > > Turns out the powerpc secure variable code can use it, so add it to the > tree for it, and potentially others to take advantage of, instead of > open-coding it. > > Reported-by: Nayna Jain <nayna@linux.ibm.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > > I'll queue this up to my tree for 5.4-rc1, but if you want to take this > in your tree earlier, feel free to do so. OK. This series is blocked on the firmware support going in, so at the moment it might miss v5.4 anyway. So this going via your tree is no problem. If it does make it into v5.4 we can do a fixup patch to use the new macro once everything's in Linus' tree. cheers > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h > index 965236795750..5420817ed317 100644 > --- a/include/linux/sysfs.h > +++ b/include/linux/sysfs.h > @@ -196,6 +196,12 @@ struct bin_attribute { > .size = _size, \ > } > > +#define __BIN_ATTR_WO(_name) { \ > + .attr = { .name = __stringify(_name), .mode = 0200 }, \ > + .store = _name##_store, \ > + .size = _size, \ > +} > + > #define __BIN_ATTR_RW(_name, _size) \ > __BIN_ATTR(_name, 0644, _name##_read, _name##_write, _size) > > @@ -208,6 +214,9 @@ struct bin_attribute bin_attr_##_name = __BIN_ATTR(_name, _mode, _read, \ > #define BIN_ATTR_RO(_name, _size) \ > struct bin_attribute bin_attr_##_name = __BIN_ATTR_RO(_name, _size) > > +#define BIN_ATTR_WO(_name, _size) \ > +struct bin_attribute bin_attr_##_name = __BIN_ATTR_WO(_name, _size) > + > #define BIN_ATTR_RW(_name, _size) \ > struct bin_attribute bin_attr_##_name = __BIN_ATTR_RW(_name, _size) > > -- > 2.23.0
next prev parent reply other threads:[~2019-09-03 3:37 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-26 13:23 [PATCH v3 0/4] powerpc: expose secure variables to the kernel and userspace Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-08-26 13:23 ` [PATCH v3 1/4] powerpc/powernv: Add OPAL API interface to access secure variable Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-08-26 13:23 ` [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-08-26 14:01 ` Greg Kroah-Hartman 2019-08-26 14:01 ` Greg Kroah-Hartman 2019-08-26 14:12 ` Nayna 2019-08-26 14:12 ` Nayna 2019-08-26 15:01 ` [PATCH] sysfs: add BIN_ATTR_WO() macro Greg Kroah-Hartman 2019-08-26 15:01 ` Greg Kroah-Hartman 2019-09-03 3:37 ` Michael Ellerman [this message] 2019-09-03 3:37 ` Michael Ellerman 2019-09-04 11:36 ` Greg Kroah-Hartman 2019-09-04 11:36 ` Greg Kroah-Hartman 2019-10-01 18:08 ` Nayna 2019-10-01 18:16 ` Greg Kroah-Hartman 2019-10-01 18:55 ` Nayna 2019-08-26 14:56 ` [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Greg Kroah-Hartman 2019-08-26 14:56 ` Greg Kroah-Hartman 2019-08-26 15:46 ` Nayna 2019-08-26 15:46 ` Nayna 2019-08-26 15:57 ` Greg Kroah-Hartman 2019-08-26 15:57 ` Greg Kroah-Hartman 2019-08-26 13:23 ` [PATCH v3 3/4] x86/efi: move common keyring handler functions to new file Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-09-02 11:55 ` Michael Ellerman 2019-09-02 11:55 ` Michael Ellerman 2019-09-03 22:51 ` Mimi Zohar 2019-09-03 22:51 ` Mimi Zohar 2019-09-05 3:59 ` Michael Ellerman 2019-09-05 3:59 ` Michael Ellerman 2019-08-26 13:23 ` [PATCH v3 4/4] powerpc: load firmware trusted keys/hashes into kernel keyring Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-09-03 22:54 ` Mimi Zohar 2019-09-03 22:54 ` Mimi Zohar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87ef0yrqxt.fsf@mpe.ellerman.id.au \ --to=mpe@ellerman.id.au \ --cc=ard.biesheuvel@linaro.org \ --cc=benh@kernel.crashing.org \ --cc=cclaudio@linux.ibm.com \ --cc=erichte@linux.ibm.com \ --cc=erpalmer@us.ibm.com \ --cc=gcwilson@linux.ibm.com \ --cc=gregkh@linuxfoundation.org \ --cc=jk@ozlabs.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=matthew.garret@nebula.com \ --cc=nayna@linux.ibm.com \ --cc=nayna@linux.vnet.ibm.com \ --cc=oohall@gmail.com \ --cc=paulus@samba.org \ --cc=zohar@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.