All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards
@ 2019-04-04  4:01 Douglas Anderson
  2019-04-04  5:20 ` Kalle Valo
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Douglas Anderson @ 2019-04-04  4:01 UTC (permalink / raw)
  To: Kalle Valo
  Cc: linux-rockchip, briannorris, mka, ryandcase, heiko,
	Douglas Anderson, David S. Miller, Ganapathi Bhat,
	linux-wireless, Amitkumar Karwar, linux-kernel,
	Nishant Sarmukadam, netdev, Xinming Hu

The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
adapter status variables") had a fairly straightforward bug in it.  It
contained this bit of diff:

 - if (!adapter->is_suspended) {
 + if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {

As you can see the patch missed the "!" when converting to the atomic
bitops.  This meant that the resume hasn't done anything at all since
that commit landed and suspend/resume for mwifiex SDIO cards has been
totally broken.

After fixing this mwifiex suspend/resume appears to work again, at
least with the simple testing I've done.

Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index a85648342d15..d5a70340a945 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -181,7 +181,7 @@ static int mwifiex_sdio_resume(struct device *dev)
 
 	adapter = card->adapter;
 
-	if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
+	if (!test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
 		mwifiex_dbg(adapter, WARN,
 			    "device already resumed\n");
 		return 0;
-- 
2.21.0.392.gf8f6787159e-goog


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-04-25 11:05 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04  4:01 [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards Douglas Anderson
2019-04-04  5:20 ` Kalle Valo
2019-04-04 20:47   ` Brian Norris
2019-04-04 20:47     ` Brian Norris
2019-04-05  3:35     ` Kalle Valo
2019-04-05  3:35       ` Kalle Valo
2019-04-18 16:31       ` Doug Anderson
2019-04-18 16:31         ` Doug Anderson
2019-04-19  4:03         ` Kalle Valo
2019-04-19  4:03           ` Kalle Valo
2019-04-25 11:05 ` Kalle Valo
2019-04-25 11:05   ` Kalle Valo
     [not found] ` <20190404040106.40519-1-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-04-25 11:05   ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.