From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinicius Costa Gomes Subject: Re: [PATCH iproute2 net-next v2 2/6] include: Add helper to retrieve a __s64 from a netlink msg Date: Fri, 05 Oct 2018 10:08:09 -0700 Message-ID: <87efd4tj7q.fsf@intel.com> References: <20181004231711.6058-1-vinicius.gomes@intel.com> <20181004231711.6058-3-vinicius.gomes@intel.com> <20181005084107.GA16936@apalos> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, jesus.sanchez-palencia@intel.com, simon.fok@baesystems.com To: Ilias Apalodimas Return-path: Received: from mga04.intel.com ([192.55.52.120]:29540 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728582AbeJFAJa (ORCPT ); Fri, 5 Oct 2018 20:09:30 -0400 In-Reply-To: <20181005084107.GA16936@apalos> Sender: netdev-owner@vger.kernel.org List-ID: Hi Ilias, Ilias Apalodimas writes: > On Thu, Oct 04, 2018 at 04:17:07PM -0700, Vinicius Costa Gomes wrote: >> This allows signed 64-bit integers to be retrieved from a netlink >> message. >> --- >> include/libnetlink.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/include/libnetlink.h b/include/libnetlink.h >> index 9d9249e6..88164975 100644 >> --- a/include/libnetlink.h >> +++ b/include/libnetlink.h >> @@ -185,6 +185,13 @@ static inline __u64 rta_getattr_u64(const struct rtattr *rta) >> memcpy(&tmp, RTA_DATA(rta), sizeof(__u64)); >> return tmp; >> } >> +static inline __s64 rta_getattr_s64(const struct rtattr *rta) >> +{ >> + __s64 tmp; >> + >> + memcpy(&tmp, RTA_DATA(rta), sizeof(__s64)); > Maybe change it to sizeof(tmp)? Will fix. Thanks. >> + return tmp; >> +} >> static inline const char *rta_getattr_str(const struct rtattr *rta) >> { >> return (const char *)RTA_DATA(rta); >> -- >> 2.19.0 >> Cheers,