From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors Date: Fri, 20 Oct 2017 14:12:02 +0300 Message-ID: <87efpyhy4d.fsf@gaia.fi.intel.com> References: <20171019143942.909-1-mika.kuoppala@linux.intel.com> <1508495678.5349.31.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 893576EBFF for ; Fri, 20 Oct 2017 11:12:15 +0000 (UTC) In-Reply-To: <1508495678.5349.31.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Sm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPiB3cml0ZXM6 Cgo+IE9uIFRodSwgMjAxNy0xMC0xOSBhdCAxNzozOSArMDMwMCwgTWlrYSBLdW9wcGFsYSB3cm90 ZToKPj4gRnJvbTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4+IAo+ PiBJbnN0ZWFkIG9mIHRydXN0aW5nIHRoYXQgZmlyc3QgYXZhaWxhYmxlIHBvcnQgaXMgYXQgaW5k ZXggMCwKPj4gdXNlIGFjY2Vzc29yIHRvIGhpZGUgdGhpcy4gVGhpcyBpcyBhIHByZXBhcmF0aW9u IGZvciBhCj4+IGZvbGxvd2luZyBwYXRjaGVzIHdoZXJlIGhlYWQgY2FuIGJlIGF0IGFyYml0cmFy eSBsb2NhdGlvbgo+PiBpbiB0aGUgcG9ydCBhcnJheS4KPj4gCj4+IHYyOiBpbXByb3ZlZCBjb21t aXQgbWVzc2FnZSwgZWxzcF9yZWFkeSByZWFkYWJpbGl0eSAoQ2hyaXMpCj4+IHYzOiBzL2V4ZWNs aXN0X3BvcnRfaW5kZXgvZXhlY2xpc3RfcG9ydCAoQ2hyaXMpCj4+IHY0OiByZWJhc2UgdG8gbmV3 IG5hbWluZwo+PiB2NTogZml4IHBvcnRfbmV4dCBpbmRleGluZwo+PiAKPj4gQ2M6IE1pY2hhxYIg V2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPj4gQ2M6IEpvb25hcyBMYWh0 aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiBTaWduZWQtb2ZmLWJ5OiBNaWthIEt1b3Bw YWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPgo+IDxTTklQPgo+Cj4+IEBAIC01NjEsMTUg KzU2MywyMCBAQCBzdGF0aWMgdm9pZCBwb3J0X2Fzc2lnbihzdHJ1Y3QgZXhlY2xpc3RfcG9ydCAq cG9ydCwKPj4gIHN0YXRpYyB2b2lkIGk5MTVfZ3VjX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lKQo+PiAgewo+PiAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICog Y29uc3QgZXhlY2xpc3RzID0gJmVuZ2luZS0+ZXhlY2xpc3RzOwo+PiAtCXN0cnVjdCBleGVjbGlz dF9wb3J0ICpwb3J0ID0gZXhlY2xpc3RzLT5wb3J0Owo+PiArCXN0cnVjdCBleGVjbGlzdF9wb3J0 ICpwb3J0Owo+PiAgCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqbGFzdCA9IE5VTEw7Cj4+ IC0JY29uc3Qgc3RydWN0IGV4ZWNsaXN0X3BvcnQgKiBjb25zdCBsYXN0X3BvcnQgPQo+PiAtCQkm ZXhlY2xpc3RzLT5wb3J0W2V4ZWNsaXN0cy0+cG9ydF9tYXNrXTsKPj4gIAlib29sIHN1Ym1pdCA9 IGZhbHNlOwo+PiAgCXN0cnVjdCByYl9ub2RlICpyYjsKPj4gIAo+PiAtCWlmIChwb3J0X2lzc2V0 KHBvcnQpKQo+PiAtCQlwb3J0Kys7Cj4+ICsJcG9ydCA9IGV4ZWNsaXN0c19wb3J0X2hlYWQoZXhl Y2xpc3RzKTsKPj4gKwo+PiArCS8qCj4+ICsJICogV2UgZG9uJ3QgY29hbGVzY2UgaW50byBsYXN0 IHN1Ym1pdHRlZCBwb3J0IHdpdGggZ3VjLgo+PiArCSAqIEZpbmQgZmlyc3QgZnJlZSBwb3J0LCB0 aGlzIGlzIHNhZmUgYXMgd2UgZG9udCBkZXF1ZXVlIHdpdGhvdXQKPj4gKwkgKiBhdGxlYXN0IGxh c3QgcG9ydCBmcmVlLgo+Cj4gImF0IGxlYXN0IiArICJ0aGUiCj4KPiA8U05JUD4KPgo+PiBAQCAt NTU3LDYgKzU1Nyw5IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4gIAlpZiAoIXJiKQo+PiAgCQlnb3RvIHVubG9jazsKPj4g IAo+PiArCXBvcnQgPSBleGVjbGlzdHNfcG9ydF9oZWFkKGV4ZWNsaXN0cyk7Cj4+ICsJbGFzdCA9 IHBvcnRfcmVxdWVzdChwb3J0KTsKPj4gKwo+PiAgCWlmIChsYXN0KSB7Cj4+ICAJCS8qCj4+ICAJ CSAqIERvbid0IHJlc3VibWl0IG9yIHN3aXRjaCB1bnRpbCBhbGwgb3V0c3RhbmRpbmcKPj4gQEAg LTU2NCw3ICs1NjcsNyBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICAJCSAqIGtub3cgdGhlIG5leHQgcHJlZW1wdGlvbiBz dGF0dXMgd2Ugc2VlIGNvcnJlc3BvbmRzCj4+ICAJCSAqIHRvIHRoaXMgRUxTUCB1cGRhdGUuCj4+ ICAJCSAqLwo+PiAtCQlpZiAocG9ydF9jb3VudCgmcG9ydFswXSkgPiAxKQo+PiArCQlpZiAocG9y dF9jb3VudChwb3J0KSA+IDEpCj4+ICAJCQlnb3RvIHVubG9jazsKPj4gIAo+PiAgCQlpZiAoY2Fu X3ByZWVtcHQoZW5naW5lKSAmJgo+PiBAQCAtNTk4LDcgKzYwMSw3IEBAIHN0YXRpYyB2b2lkIGV4 ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4gIAkJCSAq IHRoZSBkcml2ZXIgaXMgdW5hYmxlIHRvIGtlZXAgdXAgdGhlIHN1cHBseSBvZiBuZXcKPj4gIAkJ CSAqIHdvcmspLgo+PiAgCQkJICovCj4+IC0JCQlpZiAocG9ydF9jb3VudCgmcG9ydFsxXSkpCj4+ ICsJCQlpZiAocG9ydF9jb3VudChleGVjbGlzdHNfcG9ydF9uZXh0KGV4ZWNsaXN0cywgcG9ydCkp KQo+PiAgCQkJCWdvdG8gdW5sb2NrOwo+PiAgCj4+ICAJCQkvKiBXYUlkbGVMaXRlUmVzdG9yZTpi ZHcsc2tsCj4+IEBAIC02MzQsNyArNjM3LDcgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2RlcXVl dWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+PiAgCQkJCSAqIGNvbWJpbmUgdGhp cyByZXF1ZXN0IHdpdGggdGhlIGxhc3QsIHRoZW4gd2UKPj4gIAkJCQkgKiBhcmUgZG9uZS4KPj4g IAkJCQkgKi8KPj4gLQkJCQlpZiAocG9ydCA9PSBsYXN0X3BvcnQpIHsKPj4gKwkJCQlpZiAocG9y dCA9PSBleGVjbGlzdHNfcG9ydF90YWlsKGV4ZWNsaXN0cykpIHsKPj4gIAkJCQkJX19saXN0X2Rl bF9tYW55KCZwLT5yZXF1ZXN0cywKPj4gIAkJCQkJCQkmcnEtPnByaW90cmVlLmxpbmspOwo+Cj4g Tm90aGluZyB0byBmaXggcmVsYXRlZCB0byB0aGlzIHBhdGNoLCBidXQgSSB3YXMgc3VyZSBuZXh0 IGh1bmsgd2FzCj4gZ29pbmcgdG8gZXNjYXBlIG15IHNjcmVlbiA6KSBNYXliZSB3ZSBuZWVkIHRv IGN1dCB0aGUgaW5kZW50cyBhIGJpdC4KPgoKSSBoYXZlIG5vdGljZWQgdGhlIHNhbWUuIEJ1dCBJ IGRpZG4ndCBmZWVsIGxpa2UgYXR0YWNraW5nIHRoaXMgbG9vcAp1bnRpbCBldmVyeXRoaW5nIGlz IGluIHBsYWNlIGFuZCB3b3JraW5nLgoKPj4gQEAgLTg5MCw3ICs5MDIsNyBAQCBzdGF0aWMgdm9p ZCBpbnRlbF9scmNfaXJxX2hhbmRsZXIodW5zaWduZWQgbG9uZyBkYXRhKQo+PiAgCQkJfQo+PiAg Cj4+ICAJCQkvKiBBZnRlciB0aGUgZmluYWwgZWxlbWVudCwgdGhlIGh3IHNob3VsZCBiZSBpZGxl ICovCj4+IC0JCQlHRU1fQlVHX09OKHBvcnRfY291bnQocG9ydCkgPT0gMCAmJgo+PiArCQkJR0VN X0JVR19PTihwb3J0X2NvdW50KGV4ZWNsaXN0c19wb3J0X2hlYWQoZXhlY2xpc3RzKSkgPT0gMCAm Jgo+PiAgCQkJCSAgICEoc3RhdHVzICYgR0VOOF9DVFhfU1RBVFVTX0FDVElWRV9JRExFKSk7Cj4K PiBXaHkgZGlkIHlvdSBzdG9wIHRydXN0aW5nIHBvcnQgdmFyaWFibGUgaGVyZT8KPgoKV2UgZGlk IGFzc2luZyBpdCBwcmUgbG9vcCBiZWZvcmUuIE5vdyB3ZSBkbyBpdCBpbnNpZGUgdGhlIGxvb3Au IEFsc28KSSB0aG91Z2h0IEkgbWFkZSBhIGZhdm91ciBmb3IgcmVhZGVyIChhbmQgZm9yIHRoZSBi dWcgdHJpYWdlcgphcyBHRU1fQlVHX09OIG1pZ2h0IHNvb24gc2hvdyBjb25kaXRpb24gaW4gZG1l c2cpIAp0byBub3RlIHRoYXQgaXQgaXMgYWx3YXlzIHRoZSBmaXJzdCBwb3J0IGNvdW50IHdlIGFz c2VydApmb3IgaWRsZW5lc3MuCgotTWlrYQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK