From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1diZu4-0002Mx-Ph for qemu-devel@nongnu.org; Fri, 18 Aug 2017 01:33:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1diZu1-0001Gf-MG for qemu-devel@nongnu.org; Fri, 18 Aug 2017 01:33:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50036) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1diZu1-0001GD-G7 for qemu-devel@nongnu.org; Fri, 18 Aug 2017 01:33:01 -0400 From: Markus Armbruster References: <2897c32f34b415aadcf43a5ae296cf5f6e15e757.1501280035.git.alistair.francis@xilinx.com> <87valqw9x0.fsf@dusky.pond.sub.org> <87lgmluw2g.fsf@dusky.pond.sub.org> <87fucq86wh.fsf@dusky.pond.sub.org> Date: Fri, 18 Aug 2017 07:32:58 +0200 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Thu, 17 Aug 2017 16:31:48 -0300") Message-ID: <87efs95tkl.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Alistair Francis , Paolo Bonzini , "qemu-devel@nongnu.org Developers" Philippe Mathieu-Daud=C3=A9 writes: > On 08/17/2017 02:55 PM, Alistair Francis wrote: >>>> On 15/08/2017 09:30, Markus Armbruster wrote: >>>>> The stupid fix is to repeat libraries until the link succeeds: >>>>> >>>>> test-util-obj-y =3D libqemuutil.a libqemustub.a libqemuutil.a >>>>> > [...] >>>>> >>>>> Sticking '-Wp,-(' and '-Wp,-)' into the command line I get from make = V=3D1 >>>>> doesn't work for me, though. >>>>> >>>>> The smart solution is not to have .a reference each other. >>>> >>>> Nah, I think we should teach those new kids on the block about -lX11 >>>> instead. :) >> >> This sounds scary... >> >>>> >>>>> Paolo, what do you think? >>>> >>>> Another possibility is to just merge the two static libraries into one. >>> >>> Sounds good to me! >> >> I feel like I have opened a can of worms. > > you are good at it! IIRC it all started with a 1-line change in > tcp_chr_wait_connected() more than 2 months ago :) > >> >> I can try and combine libqemustub.a into libqemuutil.a is that the >> solution? I just want to make sure before I start this. > > IMHO your series is OK like this, add a "TODO remove once > libqemuutil.a circular dep is resolved" comment in the Makefile is > enough, and let this issue for another time. I disagree. If merging the two .a is beyond your reach (I hope it isn't), then the spot to mess up is this one: # TODO bla bla explain bla test-util-obj-y =3D libqemuutil.a libqemustub.a libqemuutil.a