From: ebiederm@xmission.com (Eric W. Biederman)
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC][PATCHSET] wait4()/waitid() cleanups
Date: Wed, 17 May 2017 14:57:13 -0500 [thread overview]
Message-ID: <87efvn9rza.fsf@xmission.com> (raw)
In-Reply-To: <20170515223157.GM390@ZenIV.linux.org.uk> (Al Viro's message of "Mon, 15 May 2017 23:31:57 +0100")
Al Viro <viro@ZenIV.linux.org.uk> writes:
> This series switches compat wait4() and waitid() variants away
> from set_fs() use. A couple of helpers (kernel_wait4() and kernel_waitid())
> are introduced, copying siginfo/rusage to userland is taken to sys_wait...().
> That allows both to simplify the guts of do_wait() machinery and avoid
> messing with set_fs() in compat variants of these syscalls.
>
> Lightly tested, seems to survive without regressions. Please,
> review.
A quick heads up. I have a patchset that is almost ready to go that is
also extensively touching wait. The point of that patchset is to get
the logic correct in the intersection ptrace, threads, signals, and wait.
As an example of things that are obviously wrong today. In the case of
a ptrace stop we can set si_code to either CLD_STOPPED or CLD_TRAPPED
but in waitid we always return for the same set of conditions
CLD_TRAPPED.
I don't believe we have any fundamental conflicts but if we aren't
careful we could have a nasty merge conflict.
Eric
prev parent reply other threads:[~2017-05-17 20:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 22:31 [RFC][PATCHSET] wait4()/waitid() cleanups Al Viro
2017-05-15 22:37 ` [PATCH 1/8] move compat wait4 and waitid next to native variants Al Viro
2017-05-15 22:37 ` [PATCH 2/8] wait4(2)/waitid(2): separate copying rusage to userland Al Viro
2017-05-15 22:37 ` [PATCH 3/8] kernel_wait4()/kernel_waitid(): delay copying status " Al Viro
2017-05-15 22:37 ` [PATCH 4/8] waitid(2): leave copyout of siginfo to syscall itself Al Viro
2017-05-15 23:06 ` Linus Torvalds
2017-05-15 23:46 ` Al Viro
2017-05-17 19:48 ` Eric W. Biederman
2017-05-15 22:37 ` [PATCH 5/8] lift getrusage() from wait_noreap_copyout() Al Viro
2017-05-15 22:37 ` [PATCH 6/8] kill wait_noreap_copyout() Al Viro
2017-05-15 22:37 ` [PATCH 7/8] wait_task_zombie: consolidate info logics Al Viro
2017-05-15 22:37 ` [PATCH 8/8] waitid(): switch copyout of siginfo to unsafe_put_user() Al Viro
2017-05-16 3:55 ` kbuild test robot
2017-05-16 4:17 ` kbuild test robot
2017-05-19 6:08 ` [lkp-robot] [waitid()] 75f64d68f9: Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode= kernel test robot
2017-05-19 6:08 ` kernel test robot
2017-05-21 7:34 ` Al Viro
2017-05-21 7:34 ` Al Viro
2017-05-21 19:04 ` Linus Torvalds
2017-05-21 19:04 ` Linus Torvalds
2017-05-21 19:35 ` Linus Torvalds
2017-05-21 19:35 ` Linus Torvalds
2017-05-21 21:14 ` Al Viro
2017-05-21 21:14 ` Al Viro
2017-05-21 21:37 ` Linus Torvalds
2017-05-21 21:37 ` Linus Torvalds
2017-05-21 22:19 ` Linus Torvalds
2017-05-21 22:19 ` Linus Torvalds
2017-05-22 1:39 ` Linus Torvalds
2017-05-22 1:39 ` Linus Torvalds
2017-05-17 19:57 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efvn9rza.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.