From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755308AbcKVLd4 (ORCPT ); Tue, 22 Nov 2016 06:33:56 -0500 Received: from ozlabs.org ([103.22.144.67]:50477 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526AbcKVLdz (ORCPT ); Tue, 22 Nov 2016 06:33:55 -0500 From: Michael Ellerman To: Ravi Bangoria Cc: benh@kernel.crashing.org, paulus@samba.org, npiggin@gmail.com, peterz@infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, naveen.n.rao@linux.vnet.ibm.com, Ravi Bangoria Subject: Re: [PATCH] powerpc/xmon: Fix data-breakpoint In-Reply-To: <1479806759-5409-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> References: <1479806759-5409-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 22 Nov 2016 22:33:51 +1100 Message-ID: <87eg23vjds.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ravi Bangoria writes: > Xmon data-breakpoint feature is broken. > > Whenever there is a watchpoint match occurs, hw_breakpoint_handler will > be called by do_break via notifier chains mechanism. If watchpoint is > registered by xmon, hw_breakpoint_handler won't find any associated > perf_event and returns immediately with NOTIFY_STOP. Similarly, do_break > also returns without notifying to xmon. > > Solve this by returning NOTIFY_DONE when hw_breakpoint_handler does not > find any perf_event associated with matched watchpoint. .. rather than NOTIFY_STOP, which tells the core code to continue calling the other breakpoint handlers including the xmon one. Right? Also any idea when we broke this? cheers