From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bridS-00065W-3L for qemu-devel@nongnu.org; Wed, 05 Oct 2016 05:37:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bridO-0007Yj-Ux for qemu-devel@nongnu.org; Wed, 05 Oct 2016 05:37:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bridO-0007Ya-Ok for qemu-devel@nongnu.org; Wed, 05 Oct 2016 05:37:06 -0400 From: Juan Quintela In-Reply-To: <1473390856-4502-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 8 Sep 2016 22:14:13 -0500") References: <1473390856-4502-1-git-send-email-eblake@redhat.com> Reply-To: quintela@redhat.com Date: Wed, 05 Oct 2016 11:37:02 +0200 Message-ID: <87eg3vt9vl.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/3] migrate: simplify migrate-set-parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, ashijeetacharya@gmail.com Eric Blake wrote: > As promised earlier today, here's a patch series to simplify how one > calls into qmp_migrate_set_parameters(). With this in place, > Ashijeet's patches for the back-compat functions would look like: > > void qmp_migrate_set_speed(int64_t valuebw, Error **errp) > { > MigrationParameters *p = { > .has_max_bandwidth = true, > .max_bandwidth = valuebw, > }; > qmp_migrate_set_parameters(&p, errp); > } > > This series is a net reduction in lines, so it has to be good, right? :) it is always nice. Especially because they were ugly lines. Applied. > > Oh, and I found (and fixed) a 2.7 regression while touching this stuff. > > Eric Blake (3): > migrate: Fix cpu-throttle-increment regression in HMP > migrate: Share common MigrationParameters struct > migrate: Use boxed qapi for migrate-set-parameters > > qapi-schema.json | 86 +++++++++++++++++---------------------------------- > hmp.c | 50 ++++++++++++++++-------------- > migration/migration.c | 72 ++++++++++++++++++++---------------------- > 3 files changed, 88 insertions(+), 120 deletions(-)