From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934828AbcI2VpA (ORCPT ); Thu, 29 Sep 2016 17:45:00 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:49759 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934101AbcI2Vo7 (ORCPT ); Thu, 29 Sep 2016 17:44:59 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Thiago Jung Bauermann Cc: Mimi Zohar , Andrew Morton , linux-security-module , linux-ima-devel@lists.sourceforge.net, Dave Young , kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Stephen Rothwell References: <1472596811-9596-1-git-send-email-zohar@linux.vnet.ibm.com> <15061913.JRHEL97DN3@hactar> <87y42mk11a.fsf@x220.int.ebiederm.org> <1743059.2ZOQaNILxh@hactar> Date: Thu, 29 Sep 2016 16:43:08 -0500 In-Reply-To: <1743059.2ZOQaNILxh@hactar> (Thiago Jung Bauermann's message of "Mon, 26 Sep 2016 15:31:38 -0300") Message-ID: <87eg42xtzn.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1bpj8S-00066X-LD;;;mid=<87eg42xtzn.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=75.170.125.99;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX196pIVc/SpP6/rh5j8q4wyKIIJwrSlRxzg= X-SA-Exim-Connect-IP: 75.170.125.99 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.5 XM_Body_Dirty_Words Contains a dirty word X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Thiago Jung Bauermann X-Spam-Relay-Country: X-Spam-Timing: total 1223 ms - load_scoreonly_sql: 0.14 (0.0%), signal_user_changed: 4.0 (0.3%), b_tie_ro: 2.8 (0.2%), parse: 0.86 (0.1%), extract_message_metadata: 3.2 (0.3%), get_uri_detail_list: 1.36 (0.1%), tests_pri_-1000: 3.8 (0.3%), tests_pri_-950: 1.18 (0.1%), tests_pri_-900: 1.02 (0.1%), tests_pri_-400: 23 (1.8%), check_bayes: 22 (1.8%), b_tokenize: 6 (0.5%), b_tok_get_all: 8 (0.6%), b_comp_prob: 2.4 (0.2%), b_tok_touch_all: 3.0 (0.2%), b_finish: 0.61 (0.0%), tests_pri_0: 1166 (95.3%), check_dkim_signature: 0.59 (0.0%), check_dkim_adsp: 2.9 (0.2%), tests_pri_500: 12 (1.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATHC v2 0/9] ima: carry the measurement list across kexec X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thiago Jung Bauermann writes: > Hello Eric, > > Am Dienstag, 20 September 2016, 11:07:29 schrieb Eric W. Biederman: >> A semi-generic concept called a hand-over buffer seems to be a >> construction of infrustructure for no actual reason that will just >> result in confusion. There are lots of things that are handed over, the >> flattend device tree, ramdisks, bootparams on x86, etc, etc. ima is not >> special in this execpt for being perhaps the first addition that we are >> going to want the option of including on most architectures. > > Ok, I understand. I decided to implement a generic concept because I thought > that proposing a feature that is more useful than what I need it for would > increase its chance of being accepted. It's interesting to see that it had > the opposite effect. Yes. In this case it was not clear that anyone else could use it, and being less generic you can tweak the needs of the code to ima without anyone having to worry about it. So thank you very much for making the code more specific to the circumstances. > I reworked and simplified the code and folded the hand-over buffer patches > into Mimi's patch series to carry the measurement list across kexec. The > kexec buffer code is in the following patches now: > > [PATCH v5 01/10] powerpc: ima: Get the kexec buffer passed by the previous > kernel > [PATCH v5 05/10] powerpc: ima: Send the kexec buffer to the next > kernel That plus [PATCH v5 06/10] ima: on soft reboot, save the measurement list > Each patch has a changelog listing what I changed to make it specific to > IMA. I am a little sad to see you needed to modify kexec_file.c to get where you were going, but that isn't a huge issue either way. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out03.mta.xmission.com ([166.70.13.233]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bpj8p-0001QH-Gi for kexec@lists.infradead.org; Thu, 29 Sep 2016 21:45:20 +0000 From: ebiederm@xmission.com (Eric W. Biederman) References: <1472596811-9596-1-git-send-email-zohar@linux.vnet.ibm.com> <15061913.JRHEL97DN3@hactar> <87y42mk11a.fsf@x220.int.ebiederm.org> <1743059.2ZOQaNILxh@hactar> Date: Thu, 29 Sep 2016 16:43:08 -0500 In-Reply-To: <1743059.2ZOQaNILxh@hactar> (Thiago Jung Bauermann's message of "Mon, 26 Sep 2016 15:31:38 -0300") Message-ID: <87eg42xtzn.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Subject: Re: [PATHC v2 0/9] ima: carry the measurement list across kexec List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Thiago Jung Bauermann Cc: Stephen Rothwell , Mimi Zohar , kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-security-module , linux-ima-devel@lists.sourceforge.net, Andrew Morton , Dave Young Thiago Jung Bauermann writes: > Hello Eric, > > Am Dienstag, 20 September 2016, 11:07:29 schrieb Eric W. Biederman: >> A semi-generic concept called a hand-over buffer seems to be a >> construction of infrustructure for no actual reason that will just >> result in confusion. There are lots of things that are handed over, the >> flattend device tree, ramdisks, bootparams on x86, etc, etc. ima is not >> special in this execpt for being perhaps the first addition that we are >> going to want the option of including on most architectures. > > Ok, I understand. I decided to implement a generic concept because I thought > that proposing a feature that is more useful than what I need it for would > increase its chance of being accepted. It's interesting to see that it had > the opposite effect. Yes. In this case it was not clear that anyone else could use it, and being less generic you can tweak the needs of the code to ima without anyone having to worry about it. So thank you very much for making the code more specific to the circumstances. > I reworked and simplified the code and folded the hand-over buffer patches > into Mimi's patch series to carry the measurement list across kexec. The > kexec buffer code is in the following patches now: > > [PATCH v5 01/10] powerpc: ima: Get the kexec buffer passed by the previous > kernel > [PATCH v5 05/10] powerpc: ima: Send the kexec buffer to the next > kernel That plus [PATCH v5 06/10] ima: on soft reboot, save the measurement list > Each patch has a changelog listing what I changed to make it specific to > IMA. I am a little sad to see you needed to modify kexec_file.c to get where you were going, but that isn't a huge issue either way. Eric _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec