From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bCQnv-0006ri-P0
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:17:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bCQns-0004W0-Gs
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:17:19 -0400
Received: from roura.ac.upc.es ([147.83.33.10]:33212)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bCQns-0004VB-3Y
	for qemu-devel@nongnu.org; Mon, 13 Jun 2016 08:17:16 -0400
From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
References: <145641255678.30097.2919142707547689749.stgit@localhost>
	<145641258612.30097.7127731954660712163.stgit@localhost>
	<20160609120756.GA15369@stefanha-x1.localdomain>
	<871t4630rc.fsf@fimbulvetr.bsc.es>
	<20160610162524.GF3855@stefanha-x1.localdomain>
	<87bn39j5in.fsf@fimbulvetr.bsc.es>
	<deef23cb-9705-f9e0-8336-0332707b60d9@redhat.com>
Date: Mon, 13 Jun 2016 14:17:06 +0200
In-Reply-To: <deef23cb-9705-f9e0-8336-0332707b60d9@redhat.com> (Paolo
	Bonzini's message of "Mon, 13 Jun 2016 10:38:14 +0200")
Message-ID: <87eg81cmgt.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/6] trace: Add per-vCPU tracing states for
 events with the 'vcpu' property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

Paolo Bonzini writes:

> On 10/06/2016 19:52, Llu=C3=ADs Vilanova wrote:
>> Fair point. But now I feel tempted to change both trace_events_dstate and
>> trace_events_enabled_count into unsigned int... it burns me when I see s=
igned
>> types used only on their positives by design.
>>=20
>> But don't worry, I'll change trace_events_dstate into int :)

> unsigned int would be fine too.

You mean only for this patch, or changing all vcpu indexes to unsigned int?

Thanks,
  Lluis