From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aiNWM-0006e2-FF
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 10:42:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aiNWI-0005ri-A4
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 10:42:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42628)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aiNWI-0005re-5I
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 10:42:54 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1457951704-5217-1-git-send-email-weijg.fnst@cn.fujitsu.com>
	<1457951704-5217-4-git-send-email-weijg.fnst@cn.fujitsu.com>
Date: Tue, 22 Mar 2016 15:42:51 +0100
In-Reply-To: <1457951704-5217-4-git-send-email-weijg.fnst@cn.fujitsu.com> (Wei
	Jiangang's message of "Mon, 14 Mar 2016 18:35:04 +0800")
Message-ID: <87egb2o9p0.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 3/3] pxb-pcie: convert to realize()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
Cc: marcel@redhat.com, caoj.fnst@cn.fujitsu.com, mst@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com

Wei Jiangang <weijg.fnst@cn.fujitsu.com> writes:

> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  hw/pci-bridge/pci_expander_bridge.c | 18 +++++-------------
>  1 file changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c
> index cc5074d..64267d8 100644
> --- a/hw/pci-bridge/pci_expander_bridge.c
> +++ b/hw/pci-bridge/pci_expander_bridge.c
> @@ -314,22 +314,14 @@ static const TypeInfo pxb_dev_info = {
>      .class_init    = pxb_dev_class_init,
>  };
>  
> -static int pxb_pcie_dev_initfn(PCIDevice *dev)
> +static void pxb_pcie_dev_realize(PCIDevice *dev, Error **errp)
>  {
> -    Error *err = NULL;
> -
>      if (!pci_bus_is_express(dev->bus)) {
> -        error_report("pxb-pcie devices cannot reside on a PCI bus!");
> -        return -EINVAL;
> -    }
> -
> -    pxb_dev_realize_common(dev, true, &err);
> -    if (err) {
> -        error_report_err(err);
> -        return -EINVAL;
> +        error_setg(errp, "pxb-pcie devices cannot reside on a PCI bus!");

Suggest to use the occasion to drop the exclamation mark.

> +        return;
>      }
>  
> -    return 0;
> +    pxb_dev_realize_common(dev, true, errp);
>  }
>  
>  static void pxb_pcie_dev_class_init(ObjectClass *klass, void *data)
> @@ -337,7 +329,7 @@ static void pxb_pcie_dev_class_init(ObjectClass *klass, void *data)
>      DeviceClass *dc = DEVICE_CLASS(klass);
>      PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>  
> -    k->init = pxb_pcie_dev_initfn;
> +    k->realize = pxb_pcie_dev_realize;
>      k->exit = pxb_dev_exitfn;
>      k->vendor_id = PCI_VENDOR_ID_REDHAT;
>      k->device_id = PCI_DEVICE_ID_REDHAT_PXB_PCIE;

I'd be tempted to squash PATCH 1-3 together, with only the bug fix from
PATCH 1 (assuming it is a bug fix) separate.  Clearly a matter of taste.