From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: find_fh_dentry returned a DISCONNECTED directory Date: Fri, 14 Feb 2014 09:14:56 -0800 Message-ID: <87eh35sjjj.fsf@xmission.com> References: <20140213212701.GB21982@fieldses.org> <8738jm1ss3.fsf@xmission.com> <20140214033030.GC21982@fieldses.org> <87ob2az5fc.fsf@xmission.com> <20140214144640.GE21982@fieldses.org> <877g8x1ypc.fsf@xmission.com> <20140214161412.GH21982@fieldses.org> <52FE4681.40901@fb.com> <20140214164507.GI21982@fieldses.org> <52FE4C1F.2020907@fb.com> Mime-Version: 1.0 Content-Type: text/plain Cc: "J. Bruce Fields" , To: Josef Bacik Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:51813 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822AbaBNRPE (ORCPT ); Fri, 14 Feb 2014 12:15:04 -0500 In-Reply-To: <52FE4C1F.2020907@fb.com> (Josef Bacik's message of "Fri, 14 Feb 2014 12:02:23 -0500") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Josef Bacik writes: > So neither of these cases happened, I just didn't see _anything_ in > the directory when I mounted the fs. Once I mounted the parent subvol > and walked into the default subvol I could see everything properly. > This is with clearing DISCONNECTED and still using d_splice_alias() in > lookup. > > Once I switched d_splice_alias() to d_materialise_unique() in > btrfs_lookup() everything went back to working as normal. So I'm > calling it a win and forgetting we ever had this conversation. > Thanks, Yes. d_splice_alias won't find anything unless DCACHE_DISCONNECTED is set, and dmaterialse_unique is definitely what you want. Eric