From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue Date: Fri, 22 Jun 2012 07:14:32 -0700 Message-ID: <87ehp71liv.fsf@ti.com> References: <1340286132-20634-1-git-send-email-keshava_mgowda@ti.com> <87fw9o32v2.fsf@ti.com> <20120622103050.GG28472@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20120622103050.GG28472-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org> (Felipe Balbi's message of "Fri, 22 Jun 2012 13:30:51 +0300") Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: balbi-l0cyMroinI0@public.gmane.org Cc: "Munegowda, Keshava" , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Paul Walmsley List-Id: linux-omap@vger.kernel.org Felipe Balbi writes: > Hi, > > On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote: >> On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman wrote: >> > "Munegowda, Keshava" writes: >> > >> >> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda >> >> wrote: >> >>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled >> >>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing >> >>> the usb hub and device detection fails in beagle XM >> >>> causeing NFS not functional. This affects the core retention too. >> >>> The same commit logic needs to be revisted adhering to hwmod and >> >>> device tree framework. >> >>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac >> >>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted. >> >>> >> >>> This patch is validated on BeagleXM with NFS support over >> >>> usb ethernet and USB mass storage and other device detection. >> >>> >> >>> Signed-off-by: Keshava Munegowda >> > >> > [...] >> > >> >> >> >> hi kevin >> >> >> >> here is pm count log on beagle XM with the above patch: >> > >> > What are you meaning to show by this log? >> > >> > This dump shows that neither PER or CORE are hitting retention in idle. >> > Which sounds to me like you have not enabled UART runtime suspend: >> > >> > echo 3000 > /sys/devices/platform/omap_uart.0/power/autosuspend_delay_ms >> > echo 3000 > /sys/devices/platform/omap_uart.1/power/autosuspend_delay_ms >> > echo 3000 > /sys/devices/platform/omap_uart.2/power/autosuspend_delay_ms >> > echo 3000 > /sys/devices/platform/omap_uart.3/power/autosuspend_delay_ms >> > >> > My test with your patch shows that it fixes the oops during boot, and >> > doesn't hang during suspend, but that USB host is still preventing CORE >> > retention during idle (after UART runtime suspend is enabled.) >> > >> > This happens on 3530/Overo, 3630/Beagle-xM and 3730/Overo >> > >> > Setting CONFIG_MFD_OMAP_USB_HOST=n allows CORE to hit retention again. >> > >> > Kevin >> >> >> >> Hi kevin >> It woks. only the log was wrong. I was using no_console_suspend >> in boot args. >> i removed it. now I can see the core retention hits with USB host in Beagle XM. >> below is the log: > > the fact is that we can't really survive without that workaround. Kevin, I don't know what workaround you're talking about. Are you talking about the revert proposed in $SUBJECT patch? I don't have a problem with that revert. The problem I have is that it does not fix the problem I initially reported: USB host prevents CORE retention in *idle*. Kevin > Paul what are the suggestions here ? We _MUST_ reparent the clock at > that specific location as a HW workaround. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html