All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ubifs: Fix regression in ubifs_readdir()
Date: Thu, 3 Nov 2016 03:46:39 +0100	[thread overview]
Message-ID: <87f68565-765b-4e9b-a3f0-34dae0b45e93@mind.be> (raw)
In-Reply-To: <1478126967.8549.4.camel@embedded.rocks>



On 02-11-16 23:49, J?rg Krause wrote:
> On Wed, 2016-11-02 at 21:49 +0100, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Wed, 02 Nov 2016 20:56:59 +0100, J?rg Krause wrote:
>>
>>>> This is *really* bad. Which Buildroot version are you using?  
>>>
>>> 2016.11 #
>>>
>>> Note that I am using Buildroot as a submodule [1] and I needed to
>>> port
>>> the br2-external tree. Maybe I messed something up?
>>>
>>>> Are you able to reproduce the bad ccache behavior here?  
>>>
>>> Yes, I am. Linux kernel source directory is located locally and the
>>> path is set using LINUX_OVERRIDE_SRCDIR in local.mk.
>>>
>>> 1/ Checkout Linux kernel version 4.7.10
>>> 2/ make linux-dirclean all
>>> 3/ Booted Linux version is 4.7.10
>>>
>>> 4/ Checkout Linux kernel version 4.8.5
>>> 5/ make linux-dirclean all
>>> 6/ Booted Linux version is still 4.7.10
>>
>> And this scenario works fine with ccache *disabled*, but breaks when
>> you enable ccache support in Buildroot?
> 
> Yes.

 I can't reproduce this. I've got a nice mix of cache misses and cache hits when
building a different version, and version.o is definitely a cache miss.

 Can you double-check the version in output/build/linux-custom/init/version.o?
And the one in output/build/linux-custom/include/generated/utsrelease.h?

 Hm, hang on, is there maybe a utsrelease.h that ends up in your staging dir and
that is used by ccache?

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2016-11-03  2:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28  9:53 [PATCH] ubifs: Fix regression in ubifs_readdir() Richard Weinberger
2016-10-28 16:19 ` Jörg Krause
2016-10-28 16:19   ` Jörg Krause
2016-10-28 17:07   ` Richard Weinberger
2016-10-28 22:23     ` Jörg Krause
2016-10-28 22:23       ` Jörg Krause
2016-10-29  9:04       ` Richard Weinberger
2016-11-01 22:22       ` [Buildroot] " Thomas Petazzoni
2016-11-02 19:56         ` Jörg Krause
2016-11-02 20:49           ` Thomas Petazzoni
2016-11-02 22:49             ` Jörg Krause
2016-11-03  2:46               ` Arnout Vandecappelle [this message]
2016-11-03  7:23                 ` Jörg Krause
2016-11-03 10:22                   ` Arnout Vandecappelle
2016-11-07 22:08                     ` Jörg Krause
2016-11-07 22:24                       ` Jörg Krause
2016-11-07 22:54                     ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87f68565-765b-4e9b-a3f0-34dae0b45e93@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.