All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Armin Kuster" <akuster808@gmail.com>
To: Paulo Neves <ptsneves@gmail.com>, yocto@lists.yoctoproject.org
Cc: Christer Fletcher <christer.fletcher@inter.ikea.com>,
	Paulo Neves <paulo.neves1@inter.ikea.com>
Subject: Re: [yocto] [meta-security][PATCH] dm-verity-img.bbclass: Expose --data-block-size for configuration
Date: Mon, 6 Sep 2021 15:53:54 -0700	[thread overview]
Message-ID: <87fb7167-9cab-75e4-70ee-ac8bd0fac1de@gmail.com> (raw)
In-Reply-To: <20210901141801.1635611-1-ptsneves@gmail.com>

merged.

thanks
Armin

On 9/1/21 7:18 AM, Paulo Neves wrote:
> From: Christer Fletcher <christer.fletcher@inter.ikea.com>
>
> Add DM_VERITY_IMAGE_DATA_BLOCK_SIZE to be able to set the
> --data-block-size used in veritysetup. Tuning this value effects the
> performance and size of the resulting image.
>
> Signed-off-by: Christer Fletcher <christer.fletcher@inter.ikea.com>
> Signed-off-by: Paulo Neves <paulo.neves1@inter.ikea.com>
> ---
>  classes/dm-verity-img.bbclass | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/classes/dm-verity-img.bbclass b/classes/dm-verity-img.bbclass
> index 16d395b..b311fc5 100644
> --- a/classes/dm-verity-img.bbclass
> +++ b/classes/dm-verity-img.bbclass
> @@ -22,6 +22,9 @@
>  # is stored where it can be installed into associated initramfs rootfs.
>  STAGING_VERITY_DIR ?= "${TMPDIR}/work-shared/${MACHINE}/dm-verity"
>  
> +# Define the data block size to use in veritysetup.
> +DM_VERITY_IMAGE_DATA_BLOCK_SIZE ?= "1024"
> +
>  # Process the output from veritysetup and generate the corresponding .env
>  # file. The output from veritysetup is not very machine-friendly so we need to
>  # convert it to some better format. Let's drop the first line (doesn't contain
> @@ -57,7 +60,7 @@ verity_setup() {
>  
>      # Let's drop the first line of output (doesn't contain any useful info)
>      # and feed the rest to another function.
> -    veritysetup --data-block-size=1024 --hash-offset=$SIZE format $OUTPUT $OUTPUT | tail -n +2 | process_verity
> +    veritysetup --data-block-size=${DM_VERITY_IMAGE_DATA_BLOCK_SIZE} --hash-offset=$SIZE format $OUTPUT $OUTPUT | tail -n +2 | process_verity
>  }
>  
>  VERITY_TYPES = "ext2.verity ext3.verity ext4.verity btrfs.verity"
>
> 
>


      reply	other threads:[~2021-09-06 22:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 14:18 [meta-security][PATCH] dm-verity-img.bbclass: Expose --data-block-size for configuration Paulo Neves
2021-09-06 22:53 ` Armin Kuster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fb7167-9cab-75e4-70ee-ac8bd0fac1de@gmail.com \
    --to=akuster808@gmail.com \
    --cc=christer.fletcher@inter.ikea.com \
    --cc=paulo.neves1@inter.ikea.com \
    --cc=ptsneves@gmail.com \
    --cc=yocto@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.