From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: mtahhan@redhat.com, bpf@vger.kernel.org, linux-doc@vger.kernel.org
Cc: jbrouer@redhat.com, thoiland@redhat.com, donhunte@redhat.com,
yhs@meta.com, Maryam Tahhan <mtahhan@redhat.com>
Subject: Re: [PATCH bpf-next v7 1/1] doc: DEVMAPs and XDP_REDIRECT
Date: Thu, 10 Nov 2022 13:38:54 +0100 [thread overview]
Message-ID: <87fseryof5.fsf@toke.dk> (raw)
In-Reply-To: <20221110102950.2633685-2-mtahhan@redhat.com>
mtahhan@redhat.com writes:
> From: Maryam Tahhan <mtahhan@redhat.com>
>
> Add documentation for BPF_MAP_TYPE_DEVMAP and
> BPF_MAP_TYPE_DEVMAP_HASH including kernel version
> introduced, usage and examples.
>
> Add documentation that describes XDP_REDIRECT.
>
> Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
Just re-read this, and I think it's much improved over previous versions
- nice work!
With just one nit below, feel free to re-add my:
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
[...]
> +With ``BPF_F_BROADCAST`` the packet will be broadcast to all the interfaces
> +in the map, with ``BPF_F_EXCLUDE_INGRESS`` the ingress interface will be excluded
> +from the broadcast.
> +
> +.. note::
> + - The key is ignored if BPF_F_BROADCAST is set.
> + - Multicast can also be achieved using multiple DEVMAPs.
That last bullet was a bit confusing on a first read. Maybe change it
to:
- The broadcast feature can also be used to implement multicast
forwarding: simply create multiple DEVMAPs, each one corresponding to
a single multicast group.
-Toke
prev parent reply other threads:[~2022-11-10 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:29 [PATCH bpf-next v7 0/1] doc: DEVMAPs and XDP_REDIRECT mtahhan
2022-11-10 10:29 ` [PATCH bpf-next v7 1/1] " mtahhan
2022-11-10 12:38 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fseryof5.fsf@toke.dk \
--to=toke@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=donhunte@redhat.com \
--cc=jbrouer@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=mtahhan@redhat.com \
--cc=thoiland@redhat.com \
--cc=yhs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.