From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E87C433EF for ; Fri, 11 Feb 2022 09:09:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346344AbiBKJJn (ORCPT ); Fri, 11 Feb 2022 04:09:43 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348387AbiBKJJl (ORCPT ); Fri, 11 Feb 2022 04:09:41 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FE64103F; Fri, 11 Feb 2022 01:09:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DB2DE61451; Fri, 11 Feb 2022 09:09:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C65DC340ED; Fri, 11 Feb 2022 09:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644570578; bh=UIxfmZMcrj/zM/st9Omjlnyy7Spqhkm+fojS8BT6aWA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RdXIQgF6aeR5pu8xgbezSfrrlzHgZdWmPoG5Hk6NgTsqnfuKqXQZZvV6DnrzwDCGC mePYMDa7Jxc9fHcgqJWtl/wstQoryCtG9MV65ZWqwnu6vT2Uv9ASyrj+Se7WiDQtIM d6MEl4KgUWIsnlbNTP4RvSgTTBXW5iP8OE7vzMauADe1YPhcGzlq9kWg2M01wYsJTU A3RNu7mtS2jMq9VNSQaMoS/WF4nQBgy3kXz3s1mNcBHhOa6wwImQpVcZz9iwcgnbEC 8N9s0i8dhlTLKKWRzmizreplEns637r7ECB1jbbUCed4Qp3Pw8/fbeA+CWF66Rh5vj L49TlAkbHBylg== Received: from sofa.misterjones.org ([185.219.108.64] helo=billy-the-mountain.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nIRvr-0077Wg-Rs; Fri, 11 Feb 2022 09:09:36 +0000 Date: Fri, 11 Feb 2022 09:08:43 +0000 Message-ID: <87fsoplqhw.wl-maz@kernel.org> From: Marc Zyngier To: Linus Walleij Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski , Matthias Brugger , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Tony Lindgren , Thomas Gleixner , Vladimir Zapolskiy , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Emil Renner Berthing , kernel-team@android.com Subject: Re: [PATCH 03/10] irqchip/gic: Switch to dynamic chip name output In-Reply-To: References: <20220209162607.1118325-1-maz@kernel.org> <20220209162607.1118325-4-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, matthias.bgg@gmail.com, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, tony@atomide.com, tglx@linutronix.de, vz@mleia.com, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, kernel@esmil.dk, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 10 Feb 2022 23:38:49 +0000, Linus Walleij wrote: > > On Wed, Feb 9, 2022 at 5:26 PM Marc Zyngier wrote: > > > The last dynamic aspect of the GIC's irq_chip structure is the > > name that is associated to it. > > > > Move the output of that name to the relevant callback, which > > allows us to do a bit of cleanup and mark the structures const. > > > > Signed-off-by: Marc Zyngier > > Reviewed-by: Linus Walleij > > This naming was once introduced for the ARM PB11MPCore > that had two cascaded GICs (commit 58b8964990dc6) > so it became a pain to see which one > was being used in /proc/interrupts > arch/arm/boot/dts/arm-realview-pb11mp.dts > > I see it is not appreciated to use /proc/interrupts for this > type of diagnostics. Ugh. I suppose people do it for the > same reason they keep using the GPIO sysfs, they like > it and they know it. It was sort of fair game to use /proc/interrupts to track these things when we only had that. These days, we have a whole interrupt debugging infrastructure that is able to track hierarchies, domains and other state. And it isn't like we're taking away the /proc/interrupts facility at all, we only indirecting the name output it when possible. There are also a number of advantages in keeping these data structures read-only when possible, in addition to the memory saving associated with only having a reference to the irq_chip structure. Thanks, M. -- Without deviation from the norm, progress is not possible.