From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC998C433EF for ; Tue, 1 Feb 2022 16:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240752AbiBAQG5 (ORCPT ); Tue, 1 Feb 2022 11:06:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234704AbiBAQG4 (ORCPT ); Tue, 1 Feb 2022 11:06:56 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2B57C061714; Tue, 1 Feb 2022 08:06:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E4CF61708; Tue, 1 Feb 2022 16:06:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1936C340EB; Tue, 1 Feb 2022 16:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643731615; bh=wCusUGW69do8zdL1IFraRPrsU9+EHiNfdech3A1Xt2E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GCqkp12U2d1lF6WZIlwueos5RFb44pInCD9Ah+1yNj2GV3INPhYcyQywpz3GlB04Y Da8ubuViEBrES19LuGvR0owKJPw+xTWzJJ0CT7lJBsLkFX7Q1czcIf6ZlVVTJwa72b r41fBP1DPGVupupZsCLMnJM6VCEdXBtdCt09lUmfhW3zP1CtNTqU2XiGTbOmDibx+/ ptzJPQpcaQKmAT8lASTyf7oRO8DxDEXHV2ODKnGdwwKpzpX6737Hfn3u0Kzk4tLnDP iSC7Ine/0Uq1dYRL3rjObK3NIGOq9sooCiwC9Ryj0x70edt3tQ9sFT3P4SY9vlTVaQ 9oHhaaA7de+lg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEvgD-004gZY-KM; Tue, 01 Feb 2022 16:06:53 +0000 Date: Tue, 01 Feb 2022 16:06:53 +0000 Message-ID: <87fsp2606a.wl-maz@kernel.org> From: Marc Zyngier To: Emil Renner Berthing Cc: "open list:GPIO SUBSYSTEM" , linux-arm-kernel , linux-mediatek@lists.infradead.org, Linux Kernel Mailing List , linux-omap@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , Matthias Brugger , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Thomas Gleixner , Shawn Guo , Sascha Hauer , Avi Fishman , Tomer Maimon , Tali Perry Subject: Re: [PATCH 11/12] pinctrl: starfive: Move PM device over to irq domain In-Reply-To: References: <20220201120310.878267-1-maz@kernel.org> <20220201120310.878267-12-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kernel@esmil.dk, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, matthias.bgg@gmail.com, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, tglx@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, 01 Feb 2022 15:16:39 +0000, Emil Renner Berthing wrote: > > On Tue, 1 Feb 2022 at 13:19, Marc Zyngier wrote: > > > > Move the reference to the device over to the irq domain. > > > > Signed-off-by: Marc Zyngier > > --- > > drivers/pinctrl/pinctrl-starfive.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pinctrl/pinctrl-starfive.c b/drivers/pinctrl/pinctrl-starfive.c > > index 0b912152a405..5be9866c2b3c 100644 > > --- a/drivers/pinctrl/pinctrl-starfive.c > > +++ b/drivers/pinctrl/pinctrl-starfive.c > > @@ -1307,7 +1307,6 @@ static int starfive_probe(struct platform_device *pdev) > > sfp->gc.base = -1; > > sfp->gc.ngpio = NR_GPIOS; > > > > - starfive_irq_chip.parent_device = dev; > > starfive_irq_chip.name = sfp->gc.label; > > > > sfp->gc.irq.chip = &starfive_irq_chip; > > @@ -1330,6 +1329,8 @@ static int starfive_probe(struct platform_device *pdev) > > if (ret) > > return dev_err_probe(dev, ret, "could not register gpiochip\n"); > > > > + irq_domain_set_pm_device(sfp->gc.irq.domain, dev); > > + > > The gpio framework uses the irq_domain at sfp->gc.irq.domain, so > shouldn't this be set before registering the gpio_chip with > devm_gpiochip_add_data above? It is devm_gpiochip_add_data() that create the domain, so there is nothing to set before. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7ED0EC433EF for ; Tue, 1 Feb 2022 16:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3aUYXpoBnc1zNO+3CM23RpdiotJ3v6JwHiIwmtGPlBI=; b=t07Iu8kxwWiXXt FKCmQ5J4fzd1/PW5XPiMBT+TVtIMLiQbydpycmVOfVYCdufJpaO4NxBnGgn+e1Zl/EGE4xP5otOqc KjuPcSE3eBPB0vQBC/gLrm/DsnUoignwt272ioP5fD0GbpmKZomo0WCO/tTSezuaO9Lzg3Rvph35j GxtMQ0Q+2QNt23cEnUBa2EZOTDkxI9hYtKUPw05b3bVZDrM9cGZ7LUhM5JmtB4QmNBc4ezXa+STQF 1vigrjWZvTwy9VVx2Du5tlDVOovLKZ3hE16umPm4yAK+BNO1ZAjp9HezyAXEksE2dcM7EFpEX+sbW 7167NKzthLF+7Fa4ok/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEvgW-00CnzE-SG; Tue, 01 Feb 2022 16:07:12 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEvgJ-00CnuX-49; Tue, 01 Feb 2022 16:07:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1FDCFB82EB6; Tue, 1 Feb 2022 16:06:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1936C340EB; Tue, 1 Feb 2022 16:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643731615; bh=wCusUGW69do8zdL1IFraRPrsU9+EHiNfdech3A1Xt2E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GCqkp12U2d1lF6WZIlwueos5RFb44pInCD9Ah+1yNj2GV3INPhYcyQywpz3GlB04Y Da8ubuViEBrES19LuGvR0owKJPw+xTWzJJ0CT7lJBsLkFX7Q1czcIf6ZlVVTJwa72b r41fBP1DPGVupupZsCLMnJM6VCEdXBtdCt09lUmfhW3zP1CtNTqU2XiGTbOmDibx+/ ptzJPQpcaQKmAT8lASTyf7oRO8DxDEXHV2ODKnGdwwKpzpX6737Hfn3u0Kzk4tLnDP iSC7Ine/0Uq1dYRL3rjObK3NIGOq9sooCiwC9Ryj0x70edt3tQ9sFT3P4SY9vlTVaQ 9oHhaaA7de+lg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEvgD-004gZY-KM; Tue, 01 Feb 2022 16:06:53 +0000 Date: Tue, 01 Feb 2022 16:06:53 +0000 Message-ID: <87fsp2606a.wl-maz@kernel.org> From: Marc Zyngier To: Emil Renner Berthing Cc: "open list:GPIO SUBSYSTEM" , linux-arm-kernel , linux-mediatek@lists.infradead.org, Linux Kernel Mailing List , linux-omap@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , Matthias Brugger , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Thomas Gleixner , Shawn Guo , Sascha Hauer , Avi Fishman , Tomer Maimon , Tali Perry Subject: Re: [PATCH 11/12] pinctrl: starfive: Move PM device over to irq domain In-Reply-To: References: <20220201120310.878267-1-maz@kernel.org> <20220201120310.878267-12-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kernel@esmil.dk, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, matthias.bgg@gmail.com, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, tglx@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_080659_480070_0BF9C254 X-CRM114-Status: GOOD ( 25.94 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 01 Feb 2022 15:16:39 +0000, Emil Renner Berthing wrote: > > On Tue, 1 Feb 2022 at 13:19, Marc Zyngier wrote: > > > > Move the reference to the device over to the irq domain. > > > > Signed-off-by: Marc Zyngier > > --- > > drivers/pinctrl/pinctrl-starfive.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pinctrl/pinctrl-starfive.c b/drivers/pinctrl/pinctrl-starfive.c > > index 0b912152a405..5be9866c2b3c 100644 > > --- a/drivers/pinctrl/pinctrl-starfive.c > > +++ b/drivers/pinctrl/pinctrl-starfive.c > > @@ -1307,7 +1307,6 @@ static int starfive_probe(struct platform_device *pdev) > > sfp->gc.base = -1; > > sfp->gc.ngpio = NR_GPIOS; > > > > - starfive_irq_chip.parent_device = dev; > > starfive_irq_chip.name = sfp->gc.label; > > > > sfp->gc.irq.chip = &starfive_irq_chip; > > @@ -1330,6 +1329,8 @@ static int starfive_probe(struct platform_device *pdev) > > if (ret) > > return dev_err_probe(dev, ret, "could not register gpiochip\n"); > > > > + irq_domain_set_pm_device(sfp->gc.irq.domain, dev); > > + > > The gpio framework uses the irq_domain at sfp->gc.irq.domain, so > shouldn't this be set before registering the gpio_chip with > devm_gpiochip_add_data above? It is devm_gpiochip_add_data() that create the domain, so there is nothing to set before. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A9DFC433FE for ; Tue, 1 Feb 2022 16:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GR1JvFdjVrapiUkxuGZBDOUJNwCj150ptWIMbFoR3io=; b=yvaTZI11dKXMAG ztXBzLDqdfQwNEROtYKOYH6Y70LXxlfCQijM1x41AgulhPZLOmqiDD2hXKc4LWmiu7MQneHCZCFDC YfE/RY1tJBaXydLX4uOxCbhW1pKKX/TWEDP9YdE9PnFdPNBjCqyqFZp3BmVxVVx0MNYRUysHmisSf /JPiKa3Vr5phCTUNpCW1IeJGc74k7QKYHTZi11gXNIW6Xb6eOovePjX50N2OihhjJPA9pGEblY0L1 3gO6iweEQVCYykOYnBfNpV02v2T/N/J1ELzLgdFoItqPR0wmeID3UYB3AhpXpX5+jYo1oCrwQoIne YfNIxIvXm0oZceSgJ6xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEvgN-00CnwH-K3; Tue, 01 Feb 2022 16:07:03 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEvgJ-00CnuX-49; Tue, 01 Feb 2022 16:07:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1FDCFB82EB6; Tue, 1 Feb 2022 16:06:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1936C340EB; Tue, 1 Feb 2022 16:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643731615; bh=wCusUGW69do8zdL1IFraRPrsU9+EHiNfdech3A1Xt2E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GCqkp12U2d1lF6WZIlwueos5RFb44pInCD9Ah+1yNj2GV3INPhYcyQywpz3GlB04Y Da8ubuViEBrES19LuGvR0owKJPw+xTWzJJ0CT7lJBsLkFX7Q1czcIf6ZlVVTJwa72b r41fBP1DPGVupupZsCLMnJM6VCEdXBtdCt09lUmfhW3zP1CtNTqU2XiGTbOmDibx+/ ptzJPQpcaQKmAT8lASTyf7oRO8DxDEXHV2ODKnGdwwKpzpX6737Hfn3u0Kzk4tLnDP iSC7Ine/0Uq1dYRL3rjObK3NIGOq9sooCiwC9Ryj0x70edt3tQ9sFT3P4SY9vlTVaQ 9oHhaaA7de+lg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEvgD-004gZY-KM; Tue, 01 Feb 2022 16:06:53 +0000 Date: Tue, 01 Feb 2022 16:06:53 +0000 Message-ID: <87fsp2606a.wl-maz@kernel.org> From: Marc Zyngier To: Emil Renner Berthing Cc: "open list:GPIO SUBSYSTEM" , linux-arm-kernel , linux-mediatek@lists.infradead.org, Linux Kernel Mailing List , linux-omap@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , Matthias Brugger , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Thomas Gleixner , Shawn Guo , Sascha Hauer , Avi Fishman , Tomer Maimon , Tali Perry Subject: Re: [PATCH 11/12] pinctrl: starfive: Move PM device over to irq domain In-Reply-To: References: <20220201120310.878267-1-maz@kernel.org> <20220201120310.878267-12-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kernel@esmil.dk, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, matthias.bgg@gmail.com, grygorii.strashko@ti.com, ssantosh@kernel.org, khilman@kernel.org, tglx@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_080659_480070_0BF9C254 X-CRM114-Status: GOOD ( 25.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 01 Feb 2022 15:16:39 +0000, Emil Renner Berthing wrote: > > On Tue, 1 Feb 2022 at 13:19, Marc Zyngier wrote: > > > > Move the reference to the device over to the irq domain. > > > > Signed-off-by: Marc Zyngier > > --- > > drivers/pinctrl/pinctrl-starfive.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pinctrl/pinctrl-starfive.c b/drivers/pinctrl/pinctrl-starfive.c > > index 0b912152a405..5be9866c2b3c 100644 > > --- a/drivers/pinctrl/pinctrl-starfive.c > > +++ b/drivers/pinctrl/pinctrl-starfive.c > > @@ -1307,7 +1307,6 @@ static int starfive_probe(struct platform_device *pdev) > > sfp->gc.base = -1; > > sfp->gc.ngpio = NR_GPIOS; > > > > - starfive_irq_chip.parent_device = dev; > > starfive_irq_chip.name = sfp->gc.label; > > > > sfp->gc.irq.chip = &starfive_irq_chip; > > @@ -1330,6 +1329,8 @@ static int starfive_probe(struct platform_device *pdev) > > if (ret) > > return dev_err_probe(dev, ret, "could not register gpiochip\n"); > > > > + irq_domain_set_pm_device(sfp->gc.irq.domain, dev); > > + > > The gpio framework uses the irq_domain at sfp->gc.irq.domain, so > shouldn't this be set before registering the gpio_chip with > devm_gpiochip_add_data above? It is devm_gpiochip_add_data() that create the domain, so there is nothing to set before. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel