From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E821AC433EF for ; Mon, 15 Nov 2021 10:24:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3F0C630EF for ; Mon, 15 Nov 2021 10:24:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B3F0C630EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F3A246E3C4; Mon, 15 Nov 2021 10:24:32 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 244756E8A6 for ; Mon, 15 Nov 2021 10:24:31 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="319626546" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="319626546" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 02:24:30 -0800 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="505861951" Received: from csrini4x-mobl1.ger.corp.intel.com (HELO localhost) ([10.251.218.37]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 02:24:28 -0800 From: Jani Nikula To: Claudio Suarez , Sam Ravnborg , Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= Subject: Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Mon, 15 Nov 2021 12:24:26 +0200 Message-ID: <87fsrx3eed.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, 14 Nov 2021, Claudio Suarez wrote: > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: >> Hi Claudio, >>=20 >> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: >> > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in >> > drm core programs. >> >=20 >> > Suggested-by: Ville Syrj=C3=A4l=C3=A4 >> > Signed-off-by: Claudio Suarez >>=20 >> While touching all these logging calls, could you convernt them to the >> newer drm_dbg_kms variants? >> DRM_DEBUG_* are all deprecated. >>=20 > > Yes, I can, but it is recommended to do it in a different patch: > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#se= parate-your-changes > > C&P: > "Separate your changes > Separate each logical change into a separate patch. > For example, if your changes include both bug fixes and performance enhan= cements..." > > > I will study and send a new separate patch with your suggestion. I feel these logging changes are the types of changes where I'd err on the side of fewer patches than strictly following the above guidelines. BR, Jani. > > Best regards, > Claudio Suarez > > > --=20 Jani Nikula, Intel Open Source Graphics Center