From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_24_48, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AD1C433F5 for ; Fri, 3 Sep 2021 13:14:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6F8160F42 for ; Fri, 3 Sep 2021 13:14:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6F8160F42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM917-0007sW-R6 for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 09:14:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM8vt-00075Y-VS for qemu-devel@nongnu.org; Fri, 03 Sep 2021 09:08:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM8vq-0001ME-IR for qemu-devel@nongnu.org; Fri, 03 Sep 2021 09:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630674514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CQMHC6zK2tNs3PcSwnAkqH1f8ykryN0vefwgqKzdZaI=; b=YxMIa9weJtzpLOsJjxZWhjMvY/j1h1E31sKWKtSdYJw1xKarkb6DhXtZZbkUPqCHwrmkFB Ypr6bgFGbd/GtptiV/YWOPZLDttynfdpkhKAWkyfz+8dSwRUciGF3xT9iECjvzAITSKT9Z b2vSyAvoSlTQxkh0O6w5t8SzXalKu4E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-YuElEnSHOdSXCBfHustl-w-1; Fri, 03 Sep 2021 09:08:32 -0400 X-MC-Unique: YuElEnSHOdSXCBfHustl-w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6CEB91966324 for ; Fri, 3 Sep 2021 13:08:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-13.ams2.redhat.com [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8332710016F2; Fri, 3 Sep 2021 13:08:27 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 771091136421; Thu, 2 Sep 2021 13:37:35 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH v2 3/3] softmmu/vl: Deprecate the -sdl and -curses option References: <20210825092023.81396-1-thuth@redhat.com> <20210825092023.81396-4-thuth@redhat.com> Date: Thu, 02 Sep 2021 13:37:35 +0200 In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Thu, 2 Sep 2021 11:58:08 +0100") Message-ID: <87fsunmcn4.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_24_48=1.34, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Thomas Huth , qemu-devel , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel P. Berrang=C3=A9 writes: > On Thu, Sep 02, 2021 at 12:51:02PM +0200, Thomas Huth wrote: >> On 31/08/2021 15.53, Paolo Bonzini wrote: >> > As an alternative, you may want to turn it into "-display sdl" rather >> > than poke at dpy. This isn't much more code, but it keeps the shortcut >> > isolated within a single "case". This follows a lot of recently cleane= d >> > up command line parsing code such as -no-hpet, -enable-kvm, -smp etc. >> >=20 >> > In the end (spoiler alert for my upcoming KVM Forum presentation=E2=80= =94slides >> > are already on sched.com :)) what really produces >> > complexity is the lack of isolation/modularity. As long as UI code >> > doesn't care about command line parsing, and command line parsing >> > doesn't care about global variables from all over the place, the cost = of >> > shortcuts is so small that it may tilt in favor of keeping them. >>=20 >> Honestly, I'd rather like to see them removed in the end. Our user inter= face >> is so terribly inconsistent here that I think that these options are rat= her >> confusing for the users than helpful. For example, why do we have -sdl a= nd >> -curses, but no -gtk ? And as a normal user, I'd also always wonder what= 's >> the difference between "-display sdl" and "-sdl", since the difference i= n >> the amount of characters that you have to type here is not that much tha= t it >> justifies the shortcut option. So IMHO let's rather clean this up comple= tely >> than dragging the shortcut options along forever. > > There's also the elephant in the room "-vnc" which has never been mapped > into -display, but which is also one of the most widely used options for > display backends :-( There's -display vnc=3D... Option -help shows it, -display help doesn't, but that's just a bug, I guess. More serious: -display '{"type": "vnc", ...} isn't implemented.