All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: Marco Elver <elver@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linuxppc-dev@lists.ozlabs.org,
	kasan-dev <kasan-dev@googlegroups.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	aneesh.kumar@linux.ibm.com, Balbir Singh <bsingharora@gmail.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH v12 2/6] kasan: allow architectures to provide an outline readiness check
Date: Wed, 16 Jun 2021 14:41:39 +1000	[thread overview]
Message-ID: <87fsxiv2t8.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <CANpmjNN2=gdDBPzYQYsmOtLQVVjSz2qFcwcTMEqB=s_ZWndJLg@mail.gmail.com>

Hi Marco,
>> +       /* Don't touch the shadow memory if arch isn't ready */
>> +       if (!kasan_arch_is_ready())
>> +               return;
>> +
>
> What about kasan_poison_last_granule()? kasan_unpoison() currently
> seems to potentially trip on that.

Ah the perils of rebasing an old series! I'll re-audit the generic code
for functions that touch memory and make sure I have covered them all.

Thanks for the review.

Kind regards,
Daniel

>
> -- 
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/CANpmjNN2%3DgdDBPzYQYsmOtLQVVjSz2qFcwcTMEqB%3Ds_ZWndJLg%40mail.gmail.com.

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Axtens <dja@axtens.net>
To: Marco Elver <elver@google.com>
Cc: aneesh.kumar@linux.ibm.com, LKML <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	kasan-dev <kasan-dev@googlegroups.com>,
	linuxppc-dev@lists.ozlabs.org,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH v12 2/6] kasan: allow architectures to provide an outline readiness check
Date: Wed, 16 Jun 2021 14:41:39 +1000	[thread overview]
Message-ID: <87fsxiv2t8.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <CANpmjNN2=gdDBPzYQYsmOtLQVVjSz2qFcwcTMEqB=s_ZWndJLg@mail.gmail.com>

Hi Marco,
>> +       /* Don't touch the shadow memory if arch isn't ready */
>> +       if (!kasan_arch_is_ready())
>> +               return;
>> +
>
> What about kasan_poison_last_granule()? kasan_unpoison() currently
> seems to potentially trip on that.

Ah the perils of rebasing an old series! I'll re-audit the generic code
for functions that touch memory and make sure I have covered them all.

Thanks for the review.

Kind regards,
Daniel

>
> -- 
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/CANpmjNN2%3DgdDBPzYQYsmOtLQVVjSz2qFcwcTMEqB%3Ds_ZWndJLg%40mail.gmail.com.

  reply	other threads:[~2021-06-16  4:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15  1:46 [PATCH v12 0/6] KASAN core changes for ppc64 radix KASAN Daniel Axtens
2021-06-15  1:47 ` [PATCH v12 1/6] kasan: allow an architecture to disable inline instrumentation Daniel Axtens
2021-06-15  7:46   ` Marco Elver
2021-06-15  7:46     ` Marco Elver
2021-06-15  7:46     ` Marco Elver
2021-06-16  4:39     ` Daniel Axtens
2021-06-16  4:39       ` Daniel Axtens
2021-06-15  1:47 ` [PATCH v12 2/6] kasan: allow architectures to provide an outline readiness check Daniel Axtens
2021-06-15  1:47   ` Daniel Axtens
2021-06-15 10:08   ` Marco Elver
2021-06-15 10:08     ` Marco Elver
2021-06-15 10:08     ` Marco Elver
2021-06-16  4:41     ` Daniel Axtens [this message]
2021-06-16  4:41       ` Daniel Axtens
2021-06-15  1:47 ` [PATCH v12 3/6] kasan: define and use MAX_PTRS_PER_* for early shadow tables Daniel Axtens
2021-06-15  1:47 ` [PATCH v12 4/6] kasan: Document support on 32-bit powerpc Daniel Axtens
2021-06-15  1:47 ` [PATCH v12 5/6] powerpc/mm/kasan: rename kasan_init_32.c to init_32.c Daniel Axtens
2021-06-15  1:47 ` [PATCH v12 6/6] [RFC] powerpc: Book3S 64-bit outline-only KASAN support Daniel Axtens
2021-06-15 10:31 ` [PATCH v12 0/6] KASAN core changes for ppc64 radix KASAN Marco Elver
2021-06-15 10:31   ` Marco Elver
2021-06-15 10:31   ` Marco Elver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsxiv2t8.fsf@dja-thinkpad.axtens.net \
    --to=dja@axtens.net \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=bsingharora@gmail.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=elver@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.