Re: [PATCH] tests/acceptance: Add a 'virt_kvm' test using the GICv3

From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Willian Rampazzo <willianr@redhat.com>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	Wainer dos Santos Moschetta <wainersm@redhat.com>,
	Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH] tests/acceptance: Add a 'virt_kvm' test using the GICv3
Date: Tue, 06 Apr 2021 18:12:21 +0100	[thread overview]
Message-ID: <87ft03wd3w.fsf@linaro.org> (raw)
In-Reply-To: <7a720701-a34f-ccf4-d116-a0f0703b5f83@redhat.com>

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 3/31/21 5:45 PM, Alex Bennée wrote:
>> 
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>> 
>>> The current 'virt_kvm' test is restricted to GICv2, but can also
>>> work with a GICv3. Duplicate it but add a GICv3 test which can be
>>> tested on some hardware.
>>>
>>> Noticed while running:
>>>
>>>  $ avocado --show=app run -t machine:virt tests/acceptance/
>>>  ...
>>>  (2/6) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm: ERROR: Unexpected empty reply from server (1.82 s)
>>>
>>> The job.log content is:
>>>
>>>   L0351 DEBUG| Output: 'qemu-system-aarch64: host does not support in-kernel GICv2 emulation\n'
>>>
>>> With this patch:
>>>
>>>  $ avocado --show=app run -t device:gicv3 tests/acceptance/
>>>  (1/1)
>>>  tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm_gicv3:
>>>  PASS (55.10 s)
>> 
>> On the new aarch64 machine which is GICv3 I get the following:
>> 
>>  (006/142) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm_gicv2: ERROR: Unexpected empty reply from server (0.47 s)
>> 
>> which it shouldn't have run. However:
>> 
>>   ./tests/venv/bin/avocado --show=app run -t device:gic3 tests/acceptance/
>>   Test Suite could not be create. No test references provided nor any other arguments resolved into tests
>> 
>> Is this something that has regressed or am I doing it wrong?
>
> Typo in the tag: "device:gic3" -> "device:gicv3"

Doh!

But what about:

/tests/venv/bin/avocado run tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm_gicv2
JOB ID     : 396696d8f9d31d970878cb46025b2ced76f3623f
JOB LOG    : /home/alex/avocado/job-results/job-2021-04-06T17.11-396696d/job.log
 (1/1) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm_gicv2: ERROR: Unexpected empty reply from server (0.65 s)
RESULTS    : PASS 0 | ERROR 1 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB TIME   : 0.96 s

why doesn't that skip?

-- 
Alex Bennée