From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9923BC433E0 for ; Wed, 17 Feb 2021 19:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EF7164E45 for ; Wed, 17 Feb 2021 19:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232140AbhBQTLf convert rfc822-to-8bit (ORCPT ); Wed, 17 Feb 2021 14:11:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:51682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231336AbhBQTL3 (ORCPT ); Wed, 17 Feb 2021 14:11:29 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AEDF864DE0; Wed, 17 Feb 2021 19:10:48 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lCSDm-00EeFc-JX; Wed, 17 Feb 2021 19:10:46 +0000 Date: Wed, 17 Feb 2021 19:10:45 +0000 Message-ID: <87ft1upl1m.wl-maz@kernel.org> From: Marc Zyngier To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Mark Rutland , Thomas Gleixner , marcan@marcan.st, kernel-team@android.com Subject: Re: [PATCH] irqchip: Do not blindly select CONFIG_GENERIC_IRQ_MULTI_HANDLER In-Reply-To: <20210217142800.2547737-1-maz@kernel.org> References: <20210217142800.2547737-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, tglx@linutronix.de, marcan@marcan.st, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Feb 2021 14:28:00 +0000, Marc Zyngier wrote: > > Implementing CONFIG_GENERIC_IRQ_MULTI_HANDLER is a decision that is > made at the architecture level, and shouldn't involve the irqchip > at all (we even provide a fallback helper when the option isn't > selected). > > Drop all instances of such selection from non-arch code. > > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/Kconfig | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index da7b3cf63b07..1e3dba80ff0b 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig [...] > @@ -64,7 +62,6 @@ config ARM_NVIC > config ARM_VIC > bool > select IRQ_DOMAIN > - select GENERIC_IRQ_MULTI_HANDLER > Mark pointed out that ep93xx doesn't select GENERIC_IRQ_MULTI_HANDLER, and that this removal breaks it. I've added the patch below before this one to address the issue. Thanks, M. >From c14dc142dd97708d53566efafd7ef7c4e8354f8d Mon Sep 17 00:00:00 2001 From: Marc Zyngier Date: Wed, 17 Feb 2021 18:10:35 +0000 Subject: [PATCH] ARM: ep93xx: Select GENERIC_IRQ_MULTI_HANDLER directly ep93xx currently relies of CONFIG_ARM_VIC to select GENERIC_IRQ_MULTI_HANDLER. Given that this is logically a platform architecture property, add the selection of GENERIC_IRQ_MULTI_HANDLER at the platform level. Further patches will remove the selection from the irqchip side. Reported-by: Marc Rutland Signed-off-by: Marc Zyngier --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 138248999df7..8efa01363da3 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -348,6 +348,7 @@ config ARCH_EP93XX select ARM_AMBA imply ARM_PATCH_PHYS_VIRT select ARM_VIC + select GENERIC_IRQ_MULTI_HANDLER select AUTO_ZRELADDR select CLKDEV_LOOKUP select CLKSRC_MMIO -- 2.30.0 -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F41C433DB for ; Wed, 17 Feb 2021 19:12:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEB0764E15 for ; Wed, 17 Feb 2021 19:12:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEB0764E15 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s4rzIK1T4tTHzlQzujI+5N24onaKcOFUQ1+iQgaahTI=; b=fcRU1vgxmJdX8SgNjoz9208q7 w+BxRNEUuAiZF0DI0KzLyq5tswTZya01rFBI1OAud+Y5M5aIAM0BUjkvwcHaNH39OSR9dphlQRdj0 szUT9+xwehtmQjCe8ytGmrB19TOwYMLKp2XEeH+kLmfWNK8eyJ4lIxVrFGtEZnhFb45M0cFiOqIBn kEo3VIY7xBHsyzeeAAZBaqx+0kHGE+AJ6mgGvXK9kgIu9AaYLD0/yfeIGLdF2GPgzfjwVn8qn2pc0 2Tyr2xM79Yo0AI+6GKeOJEaNjbpIV0Fd/wYLOaUvXsMqMKAe4mqTyDchsTdU2/hwdB9FX0PMk0E5t 2nW/x3r6g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCSDt-0002PO-HW; Wed, 17 Feb 2021 19:10:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCSDq-0002Op-5W for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 19:10:51 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AEDF864DE0; Wed, 17 Feb 2021 19:10:48 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lCSDm-00EeFc-JX; Wed, 17 Feb 2021 19:10:46 +0000 Date: Wed, 17 Feb 2021 19:10:45 +0000 Message-ID: <87ft1upl1m.wl-maz@kernel.org> From: Marc Zyngier To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip: Do not blindly select CONFIG_GENERIC_IRQ_MULTI_HANDLER In-Reply-To: <20210217142800.2547737-1-maz@kernel.org> References: <20210217142800.2547737-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, tglx@linutronix.de, marcan@marcan.st, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_141050_305689_9517F0F2 X-CRM114-Status: GOOD ( 23.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Thomas Gleixner , marcan@marcan.st, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 17 Feb 2021 14:28:00 +0000, Marc Zyngier wrote: > > Implementing CONFIG_GENERIC_IRQ_MULTI_HANDLER is a decision that is > made at the architecture level, and shouldn't involve the irqchip > at all (we even provide a fallback helper when the option isn't > selected). > > Drop all instances of such selection from non-arch code. > > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/Kconfig | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index da7b3cf63b07..1e3dba80ff0b 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig [...] > @@ -64,7 +62,6 @@ config ARM_NVIC > config ARM_VIC > bool > select IRQ_DOMAIN > - select GENERIC_IRQ_MULTI_HANDLER > Mark pointed out that ep93xx doesn't select GENERIC_IRQ_MULTI_HANDLER, and that this removal breaks it. I've added the patch below before this one to address the issue. Thanks, M. >From c14dc142dd97708d53566efafd7ef7c4e8354f8d Mon Sep 17 00:00:00 2001 From: Marc Zyngier Date: Wed, 17 Feb 2021 18:10:35 +0000 Subject: [PATCH] ARM: ep93xx: Select GENERIC_IRQ_MULTI_HANDLER directly ep93xx currently relies of CONFIG_ARM_VIC to select GENERIC_IRQ_MULTI_HANDLER. Given that this is logically a platform architecture property, add the selection of GENERIC_IRQ_MULTI_HANDLER at the platform level. Further patches will remove the selection from the irqchip side. Reported-by: Marc Rutland Signed-off-by: Marc Zyngier --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 138248999df7..8efa01363da3 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -348,6 +348,7 @@ config ARCH_EP93XX select ARM_AMBA imply ARM_PATCH_PHYS_VIRT select ARM_VIC + select GENERIC_IRQ_MULTI_HANDLER select AUTO_ZRELADDR select CLKDEV_LOOKUP select CLKSRC_MMIO -- 2.30.0 -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel