From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF702C433DB for ; Wed, 13 Jan 2021 06:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C72423120 for ; Wed, 13 Jan 2021 06:36:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726244AbhAMGg5 convert rfc822-to-8bit (ORCPT ); Wed, 13 Jan 2021 01:36:57 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:45552 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbhAMGg5 (ORCPT ); Wed, 13 Jan 2021 01:36:57 -0500 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id B346E440045; Wed, 13 Jan 2021 08:36:12 +0200 (IST) References: <20210111201711.ym46w7dy62ux66zb@pengutronix.de> User-agent: mu4e 1.4.13; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: g@pengutronix.de, Thierry Reding , Lee Jones , Linus Walleij , Bartosz Golaszewski , Russell King , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Chris Packham , Sascha Hauer , Ralph Sennhauser , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5] gpio: mvebu: fix pwm get_state period calculation In-reply-to: <20210111201711.ym46w7dy62ux66zb@pengutronix.de> Date: Wed, 13 Jan 2021 08:36:12 +0200 Message-ID: <87ft35xs0z.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Uwe, On Mon, Jan 11 2021, Uwe Kleine-König wrote: > $Subject ~= s/get_state/.get_state/ ? Ack. > On Mon, Jan 11, 2021 at 01:17:02PM +0200, Baruch Siach wrote: >> The period is the sum of on and off values. >> >> Reported-by: Russell King >> Fixes: 757642f9a584e ("gpio: mvebu: Add limited PWM support") >> Signed-off-by: Baruch Siach >> --- >> drivers/gpio/gpio-mvebu.c | 19 ++++++++----------- >> 1 file changed, 8 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c >> index 672681a976f5..a912a8fed197 100644 >> --- a/drivers/gpio/gpio-mvebu.c >> +++ b/drivers/gpio/gpio-mvebu.c >> @@ -676,20 +676,17 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip, >> else >> state->duty_cycle = 1; >> >> + val = (unsigned long long) u; /* on duration */ >> regmap_read(mvpwm->regs, mvebu_pwmreg_blink_off_duration(mvpwm), &u); >> - val = (unsigned long long) u * NSEC_PER_SEC; >> + val += (unsigned long long) u; /* period = on + off duration */ >> + val *= NSEC_PER_SEC; >> do_div(val, mvpwm->clk_rate); >> - if (val < state->duty_cycle) { >> + if (val > UINT_MAX) >> + state->period = UINT_MAX; >> + else if (val) >> + state->period = val; >> + else >> state->period = 1; >> - } else { >> - val -= state->duty_cycle; >> - if (val > UINT_MAX) >> - state->period = UINT_MAX; >> - else if (val) >> - state->period = val; >> - else >> - state->period = 1; >> - } > > The patch looks good, the patch description could be a bit more verbose. > Something like: > > Calculate the period as > > ($on + $off) / clkrate > > instead of > > $off / clkrate - $on / clkrate > > . I take this to refer to the next patch (2/5). This patch changes from buggy $on / clkrate to ($on + $off) / clkrate baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79BD3C433DB for ; Wed, 13 Jan 2021 06:37:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 059D52311F for ; Wed, 13 Jan 2021 06:37:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 059D52311F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hHkB+km0kFJQ0/o3//pn0BTbCspXOhSgokWciyP1wk4=; b=ZNtH4V6ereOUeLqUqisEJIGIo SQG9kH/XnOMTaEDVQhktDjHibCPm9AN477UKGNE3zqiXoYOwcRBPFPmG9kQxk2ijTiCP2eOMK3WWp RxTwBsD7N9AE3KUg+p0cg9Vx3CF9aWn0RsmK/6GqdY06FjsDZxiy9Sk/F5buWrplSq6xjIb/bjILb Fh1ZPPM/pruMPfdRMvWnAWh8T+XgcQsEmJoigrUXHtnLvE3IPV/NYFwzjHMqFGcPMofH9QTZSQdwy D/HGo6xRyPWbd29mXEYk/ho7luSqLWiDGsoEBv34fmRqx2SLkUOXto/Q8mfDN00htIqE+iHyaARIj To+18lCIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzZlV-0007sJ-98; Wed, 13 Jan 2021 06:36:21 +0000 Received: from guitar.tcltek.co.il ([192.115.133.116] helo=mx.tkos.co.il) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzZlS-0007qy-PS for linux-arm-kernel@lists.infradead.org; Wed, 13 Jan 2021 06:36:20 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id B346E440045; Wed, 13 Jan 2021 08:36:12 +0200 (IST) References: <20210111201711.ym46w7dy62ux66zb@pengutronix.de> User-agent: mu4e 1.4.13; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 1/5] gpio: mvebu: fix pwm get_state period calculation In-reply-to: <20210111201711.ym46w7dy62ux66zb@pengutronix.de> Date: Wed, 13 Jan 2021 08:36:12 +0200 Message-ID: <87ft35xs0z.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_013619_101191_75FE53A4 X-CRM114-Status: GOOD ( 23.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sascha Hauer , linux-pwm@vger.kernel.org, Linus Walleij , Chris Packham , Russell King , Bartosz Golaszewski , g@pengutronix.de, Thierry Reding , Thomas Petazzoni , linux-gpio@vger.kernel.org, Ralph Sennhauser , Lee Jones , Gregory Clement , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVXdlLAoKT24gTW9uLCBKYW4gMTEgMjAyMSwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4g JFN1YmplY3Qgfj0gcy9nZXRfc3RhdGUvLmdldF9zdGF0ZS8gPwoKQWNrLgoKPiBPbiBNb24sIEph biAxMSwgMjAyMSBhdCAwMToxNzowMlBNICswMjAwLCBCYXJ1Y2ggU2lhY2ggd3JvdGU6Cj4+IFRo ZSBwZXJpb2QgaXMgdGhlIHN1bSBvZiBvbiBhbmQgb2ZmIHZhbHVlcy4KPj4gCj4+IFJlcG9ydGVk LWJ5OiBSdXNzZWxsIEtpbmcgPGxpbnV4QGFybWxpbnV4Lm9yZy51az4KPj4gRml4ZXM6IDc1NzY0 MmY5YTU4NGUgKCJncGlvOiBtdmVidTogQWRkIGxpbWl0ZWQgUFdNIHN1cHBvcnQiKQo+PiBTaWdu ZWQtb2ZmLWJ5OiBCYXJ1Y2ggU2lhY2ggPGJhcnVjaEB0a29zLmNvLmlsPgo+PiAtLS0KPj4gIGRy aXZlcnMvZ3Bpby9ncGlvLW12ZWJ1LmMgfCAxOSArKysrKysrKy0tLS0tLS0tLS0tCj4+ICAxIGZp bGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jIGIvZHJpdmVycy9ncGlvL2dwaW8tbXZl YnUuYwo+PiBpbmRleCA2NzI2ODFhOTc2ZjUuLmE5MTJhOGZlZDE5NyAxMDA2NDQKPj4gLS0tIGEv ZHJpdmVycy9ncGlvL2dwaW8tbXZlYnUuYwo+PiArKysgYi9kcml2ZXJzL2dwaW8vZ3Bpby1tdmVi dS5jCj4+IEBAIC02NzYsMjAgKzY3NiwxNyBAQCBzdGF0aWMgdm9pZCBtdmVidV9wd21fZ2V0X3N0 YXRlKHN0cnVjdCBwd21fY2hpcCAqY2hpcCwKPj4gIAllbHNlCj4+ICAJCXN0YXRlLT5kdXR5X2N5 Y2xlID0gMTsKPj4gIAo+PiArCXZhbCA9ICh1bnNpZ25lZCBsb25nIGxvbmcpIHU7IC8qIG9uIGR1 cmF0aW9uICovCj4+ICAJcmVnbWFwX3JlYWQobXZwd20tPnJlZ3MsIG12ZWJ1X3B3bXJlZ19ibGlu a19vZmZfZHVyYXRpb24obXZwd20pLCAmdSk7Cj4+IC0JdmFsID0gKHVuc2lnbmVkIGxvbmcgbG9u ZykgdSAqIE5TRUNfUEVSX1NFQzsKPj4gKwl2YWwgKz0gKHVuc2lnbmVkIGxvbmcgbG9uZykgdTsg LyogcGVyaW9kID0gb24gKyBvZmYgZHVyYXRpb24gKi8KPj4gKwl2YWwgKj0gTlNFQ19QRVJfU0VD Owo+PiAgCWRvX2Rpdih2YWwsIG12cHdtLT5jbGtfcmF0ZSk7Cj4+IC0JaWYgKHZhbCA8IHN0YXRl LT5kdXR5X2N5Y2xlKSB7Cj4+ICsJaWYgKHZhbCA+IFVJTlRfTUFYKQo+PiArCQlzdGF0ZS0+cGVy aW9kID0gVUlOVF9NQVg7Cj4+ICsJZWxzZSBpZiAodmFsKQo+PiArCQlzdGF0ZS0+cGVyaW9kID0g dmFsOwo+PiArCWVsc2UKPj4gIAkJc3RhdGUtPnBlcmlvZCA9IDE7Cj4+IC0JfSBlbHNlIHsKPj4g LQkJdmFsIC09IHN0YXRlLT5kdXR5X2N5Y2xlOwo+PiAtCQlpZiAodmFsID4gVUlOVF9NQVgpCj4+ IC0JCQlzdGF0ZS0+cGVyaW9kID0gVUlOVF9NQVg7Cj4+IC0JCWVsc2UgaWYgKHZhbCkKPj4gLQkJ CXN0YXRlLT5wZXJpb2QgPSB2YWw7Cj4+IC0JCWVsc2UKPj4gLQkJCXN0YXRlLT5wZXJpb2QgPSAx Owo+PiAtCX0KPgo+IFRoZSBwYXRjaCBsb29rcyBnb29kLCB0aGUgcGF0Y2ggZGVzY3JpcHRpb24g Y291bGQgYmUgYSBiaXQgbW9yZSB2ZXJib3NlLgo+IFNvbWV0aGluZyBsaWtlOgo+Cj4gCUNhbGN1 bGF0ZSB0aGUgcGVyaW9kIGFzCj4KPiAJCSgkb24gKyAkb2ZmKSAvIGNsa3JhdGUKPgo+IAlpbnN0 ZWFkIG9mCj4KPiAJCSRvZmYgLyBjbGtyYXRlIC0gJG9uIC8gY2xrcmF0ZQo+Cj4gCS4KCkkgdGFr ZSB0aGlzIHRvIHJlZmVyIHRvIHRoZSBuZXh0IHBhdGNoICgyLzUpLiBUaGlzIHBhdGNoIGNoYW5n ZXMgZnJvbQpidWdneQoKICAkb24gLyBjbGtyYXRlCgp0bwoKICAoJG9uICsgJG9mZikgLyBjbGty YXRlCgpiYXJ1Y2gKCi0tIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIH4uIC5+ICAgVGsgT3BlbiBTeXN0ZW1zCj19LS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tb29PLS1VLS1Pb28tLS0tLS0tLS0tLS17PQog ICAtIGJhcnVjaEB0a29zLmNvLmlsIC0gdGVsOiArOTcyLjUyLjM2OC40NjU2LCBodHRwOi8vd3d3 LnRrb3MuY28uaWwgLQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=