From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D456AC2D0E4 for ; Tue, 17 Nov 2020 10:21:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2876D208B8 for ; Tue, 17 Nov 2020 10:21:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V024GjsO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2876D208B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1key7D-0004hC-AB for qemu-devel@archiver.kernel.org; Tue, 17 Nov 2020 05:21:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1key6P-0003wf-0J for qemu-devel@nongnu.org; Tue, 17 Nov 2020 05:20:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:40151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1key6K-0002rv-BO for qemu-devel@nongnu.org; Tue, 17 Nov 2020 05:20:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605608439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XlpjVT4wpL+vDWEQQtVl0Y8ATKvIeO8kp1DROjvnfOM=; b=V024GjsOHE29cZN29CweXLrg+ZvudrvIGrFWZniZt3WfCqA1n25QxyCPyhFVYFtjmDL/jE qSngFJvhurd5xWHr+6REUQOI0hi6TSR5kaC48+KgifP6jxQncSLMu4LGpHYHhkFI13YacE t5FvRMqhnmA2dycKnUvAoXWKDBrIxVs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-Hsa01aZOPVaVKzfe65DHMA-1; Tue, 17 Nov 2020 05:20:38 -0500 X-MC-Unique: Hsa01aZOPVaVKzfe65DHMA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4EEC8030D0; Tue, 17 Nov 2020 10:20:35 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-103.ams2.redhat.com [10.36.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0811F60C05; Tue, 17 Nov 2020 10:20:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7C94A11358BA; Tue, 17 Nov 2020 11:20:14 +0100 (CET) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH v2 4/7] qapi: Use QAPI_LIST_PREPEND() where possible References: <20201113011340.463563-1-eblake@redhat.com> <20201113011340.463563-5-eblake@redhat.com> Date: Tue, 17 Nov 2020 11:20:14 +0100 In-Reply-To: <20201113011340.463563-5-eblake@redhat.com> (Eric Blake's message of "Thu, 12 Nov 2020 19:13:37 -0600") Message-ID: <87ft589tep.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/17 00:41:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , "open list:GLUSTER" , Juan Quintela , David Hildenbrand , Michael Roth , Halil Pasic , Christian Borntraeger , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Richard Henderson , Thomas Huth , Jiri Pirko , Eduardo Habkost , "Dr. David Alan Gilbert" , "open list:S390 KVM CPUs" , "open list:ARM TCG CPUs" , Stefan Hajnoczi , David Gibson , Kevin Wolf , "open list:GLUSTER" , "Daniel P. =?utf-8?Q?Berr?= =?utf-8?Q?ang=C3=A9?=" , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Max Reitz , "open list:PowerPC TCG CPUs" , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > Anywhere we create a list of just one item or by prepending items > (typically because order doesn't matter), we can use the now-public > macro. But places where we must keep the list in order by appending > remain open-coded until later patches. "now-public" suggests a patch in this series made it public. Used to be the case, but no more. Suggest "we can use QAPI_LIST_PREPEND()". > Note that as a side effect, this also performs a cleanup of two minor > issues in qga/commands-posix.c: the old code was performing > new = g_malloc0(sizeof(*ret)); > which 1) is confusing because you have to verify whether 'new' and > 'ret' are variables with the same type, and 2) would conflict with C++ > compilation (not an actual problem for this file, but makes > copy-and-paste harder). I consider 2) a complete non-issue :) > Signed-off-by: Eric Blake > --- > docs/devel/writing-qmp-commands.txt | 12 +-- > block/gluster.c | 4 +- > block/qapi.c | 7 +- > chardev/char.c | 20 ++--- > hw/core/machine-qmp-cmds.c | 6 +- > hw/core/machine.c | 11 +-- > hw/net/rocker/rocker_of_dpa.c | 20 ++--- > hw/net/virtio-net.c | 21 ++---- > migration/migration.c | 7 +- > migration/postcopy-ram.c | 7 +- > monitor/hmp-cmds.c | 13 ++-- > monitor/misc.c | 25 +++--- > monitor/qmp-cmds-control.c | 10 +-- > qemu-img.c | 5 +- > qga/commands-posix-ssh.c | 7 +- > qga/commands-posix.c | 46 +++-------- > qga/commands-win32.c | 32 ++------ > qga/commands.c | 6 +- > qom/qom-qmp-cmds.c | 29 ++----- > target/arm/helper.c | 6 +- > target/arm/monitor.c | 13 +--- > target/i386/cpu.c | 6 +- > target/mips/helper.c | 6 +- > target/s390x/cpu_models.c | 12 +-- > tests/test-clone-visitor.c | 7 +- > tests/test-qobject-output-visitor.c | 42 +++++------ > tests/test-visitor-serialization.c | 113 ++++------------------------ > trace/qmp.c | 22 +++--- > ui/input.c | 16 ++-- > ui/vnc.c | 21 ++---- > util/qemu-config.c | 14 +--- > target/ppc/translate_init.c.inc | 12 +-- > 32 files changed, 158 insertions(+), 420 deletions(-) Quite a few more instances as in v1. Some of the more "creative" ones were bothersome to review. I figure they were just as bothersome to clean up. Thanks for that! Reviewed-by: Markus Armbruster