From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0442DC433DF for ; Fri, 29 May 2020 14:16:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF01B20707 for ; Fri, 29 May 2020 14:16:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OZzn0xzU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF01B20707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jefoM-0005VN-Ue for qemu-devel@archiver.kernel.org; Fri, 29 May 2020 10:16:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jefPz-0005Gg-Lf for qemu-devel@nongnu.org; Fri, 29 May 2020 09:51:27 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:26472 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jefPy-00023W-Tb for qemu-devel@nongnu.org; Fri, 29 May 2020 09:51:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590760285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rchiy/A8fwaRkFpsPowqeALvy5sQ8i8AsGN5jFcOjOQ=; b=OZzn0xzUuN2uvHAywSIyg4fXHcFLTsKVwh3svGXC95jylkyZqdVT4WDGRLDQLhlqrARzqd qiflg66pwK3olOwI8c0kMeK2ZsWEjTslTwTrYDh9O1ApDv/ruBeRBS2rY1oL/JMDwCKjwe Bfe2S37XhrJSjdTYdjmdYWvuKZqyDJs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-Kcio34waNh6WU-JXaDaWuA-1; Fri, 29 May 2020 09:51:22 -0400 X-MC-Unique: Kcio34waNh6WU-JXaDaWuA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4F558014D4; Fri, 29 May 2020 13:51:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 133995D9D5; Fri, 29 May 2020 13:51:18 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 73CBA11386A0; Fri, 29 May 2020 15:45:26 +0200 (CEST) From: Markus Armbruster To: Markus Armbruster Subject: Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices References: <5c6028bd-0bab-6c78-90fe-f00e23ab71b9@redhat.com> <03AEEA41-0543-4097-8FFB-9E41038F31EE@redhat.com> <87k110fqgl.fsf@dusky.pond.sub.org> Date: Fri, 29 May 2020 15:45:26 +0200 In-Reply-To: <87k110fqgl.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Mon, 25 May 2020 09:01:30 +0200") Message-ID: <87ftbilurt.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=207.211.31.81; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/29 01:27:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, ehabkost@redhat.com, David Hildenbrand , Cornelia Huck , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, pbonzini@redhat.com, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: > David Hildenbrand writes: > >>>> +static void realize_event_facility(DeviceState *dev, Error **errp) >>>> +{ >>>> + SCLPEventFacility *event_facility = EVENT_FACILITY(dev); >>>> + Error *local_err = NULL; >>>> + >>>> + qdev_realize(DEVICE(&event_facility->quiesce), >>>> + BUS(&event_facility->sbus), &local_err); >>>> + if (local_err) { >>>> + error_propagate(errp, local_err); >>>> + return; >>>> + } >>>> + qdev_realize(DEVICE(&event_facility->cpu_hotplug), >>>> + BUS(&event_facility->sbus), errp); >>> >>> Just wondering, do we have to care about un-realizing quiesce in case >>> this fails? >> >> Just remembered that we fail creating the machine and therefore abort. So not necessary :) > > True. I chose to clean up on error anyway in v2. Thanks!