From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A547CA9EA0 for ; Wed, 23 Oct 2019 00:56:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1891420659 for ; Wed, 23 Oct 2019 00:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733089AbfJWA4L (ORCPT ); Tue, 22 Oct 2019 20:56:11 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:8139 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731265AbfJWA4K (ORCPT ); Tue, 22 Oct 2019 20:56:10 -0400 Date: 23 Oct 2019 09:56:09 +0900 X-IronPort-AV: E=Sophos;i="5.68,218,1569250800"; d="scan'208";a="29737860" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 23 Oct 2019 09:56:09 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 3CD8F400A11D; Wed, 23 Oct 2019 09:56:09 +0900 (JST) Message-ID: <87ftjkz3di.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Eugeniu Rosca Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , , , Eugeniu Rosca , Jiada Wang , Andrew Gabbasov , Timo Wischer Subject: Re: [PATCH] ASoC: rsnd: dma: set bus width to data width for monaural data In-Reply-To: <20191022185518.12838-1-erosca@de.adit-jv.com> References: <20191022185518.12838-1-erosca@de.adit-jv.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > According to R-Car3 HW manual 40.3.3 (Data Format on Audio Local Bus), > in case of monaural data writing or reading through Audio-DMAC, > it's always in Left Justified format, so both src and dst > DMA Bus width should be equal to physical data width. > > Therefore set src and dst's DMA bus width to: > - [monaural case] data width > - [non-monaural case] 32bits (as prior applying the patch) > > Cc: Andrew Gabbasov > Cc: Timo Wischer > Signed-off-by: Jiada Wang > Signed-off-by: Eugeniu Rosca > --- I don't know how Monaural works, but I know you are using it. Thus don't say Acked-by and/or Reviewed-by, but I have no objection about this patch. Thank you for your help !! Best regards --- Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385A0CA9EA0 for ; Wed, 23 Oct 2019 00:57:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A82662084B for ; Wed, 23 Oct 2019 00:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="A5i2O//J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A82662084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 05F6D1607; Wed, 23 Oct 2019 02:56:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 05F6D1607 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571792228; bh=mOlYo8g/4jo/j+q0okG9WSvE5p6Pa7XQl0dY010sWg0=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=A5i2O//JlIplWhjzDJCFr7gCggN7xSmSfhBkA80xieQsJsdPWcibZlecBK0kh2Huq 4OEuU94DHvQqUaGTI3ei/Q/tClXBiUnWrQh5zpuUblqP6+xs2uYZ/e996+ElNlXpp6 B0ZcQovdyg/WoU4pgm8Sym+X6iMLyvCDbU9xyZJo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 80744F802FB; Wed, 23 Oct 2019 02:56:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7991AF8031A; Wed, 23 Oct 2019 02:56:16 +0200 (CEST) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id AE12FF8026A for ; Wed, 23 Oct 2019 02:56:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AE12FF8026A Date: 23 Oct 2019 09:56:09 +0900 X-IronPort-AV: E=Sophos;i="5.68,218,1569250800"; d="scan'208";a="29737860" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 23 Oct 2019 09:56:09 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 3CD8F400A11D; Wed, 23 Oct 2019 09:56:09 +0900 (JST) Message-ID: <87ftjkz3di.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Eugeniu Rosca In-Reply-To: <20191022185518.12838-1-erosca@de.adit-jv.com> References: <20191022185518.12838-1-erosca@de.adit-jv.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Timo Wischer , alsa-devel@alsa-project.org, Andrew Gabbasov , Liam Girdwood , Jiada Wang , Eugeniu Rosca , linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown Subject: Re: [alsa-devel] [PATCH] ASoC: rsnd: dma: set bus width to data width for monaural data X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi > According to R-Car3 HW manual 40.3.3 (Data Format on Audio Local Bus), > in case of monaural data writing or reading through Audio-DMAC, > it's always in Left Justified format, so both src and dst > DMA Bus width should be equal to physical data width. > > Therefore set src and dst's DMA bus width to: > - [monaural case] data width > - [non-monaural case] 32bits (as prior applying the patch) > > Cc: Andrew Gabbasov > Cc: Timo Wischer > Signed-off-by: Jiada Wang > Signed-off-by: Eugeniu Rosca > --- I don't know how Monaural works, but I know you are using it. Thus don't say Acked-by and/or Reviewed-by, but I have no objection about this patch. Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel