From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY Date: Tue, 28 May 2019 15:47:07 +0300 Message-ID: <87ftoy6910.fsf@intel.com> References: <20190523231758.6230-1-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E9F8E89DFC for ; Tue, 28 May 2019 12:43:55 +0000 (UTC) In-Reply-To: <20190523231758.6230-1-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMyBNYXkgMjAxOSwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PiB3cm90ZToKPiBTdXNwZW5kIHJlc3VtZSBpcyBicm9rZW4gaWYgd2UgdHJ5IHRvIGVuYWJsZS9k aXNhYmxlIGRjOSBvbgo+IGNhc2VzIHdpdGggZGlzYWJsZWQgZGlzcGxheXMuCj4KPiB2MjogTWFr ZSBjaGVja3BhdGNoIGhhcHB5Ogo+ICAgICAtIGJyYWNlcyB7fSBhcmUgbm90IG5lY2Vzc2FyeSBm b3Igc2luZ2xlIHN0YXRlbWVudCBibG9ja3MKPgo+IHYzOiBBbHNvIG1vdmUgaHN3L2JkdyBQQzgg c2VxdWVuY2VzIHNpbmNlIHRoZXkgYXJlIHJlbGF0ZWQgdG8KPiAgICAgZGlzcGxheSBQTSBhbnl3 YXlzLiAoVmlsbGUpCgpNb3N0IGlmIG5vdCBhbGwgdGhlIG5ldyBmdW5jdGlvbnMgYmVsb25nIGlu IGludGVsX3J1bnRpbWVfcG0uYywgYW5kIHlvdQpjYW4gbWFrZSBhIGJ1bmNoIG9mIGZ1bmN0aW9u cyBzdGF0aWMgdGhlcmUgYXMgd2VsbC4gVGhpcyBpcyBuaWNlbHkgaW4KbGluZSB3aXRoIG5vdCBl eHBvc2luZyBwbGF0Zm9ybSBzcGVjaWZpYyBmdW5jdGlvbnMgZnJvbSAuYyBmaWxlcy4KCkJSLApK YW5pLgoKCj4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiBDYzogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+ Cj4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ IFJldmlld2VkLWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNv bT4gKHYxKQo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIHwgMTE3ICsr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3NiBpbnNl cnRpb25zKCspLCA0MSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IGlu ZGV4IDgzZDJlYjllNzRjYi4uYmQ3M2NlNTc3NDFhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5jCj4gQEAgLTIxMTgsNiArMjExOCwxNyBAQCBnZXRfc3VzcGVuZF9tb2RlKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwgYm9vbCBoaWJlcm5hdGUpCj4gIAlyZXR1cm4gSTkxNV9E Uk1fU1VTUEVORF9NRU07Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGludGVsX2Rpc3BsYXlfc3Vz cGVuZF9sYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICsJaWYg KCFIQVNfRElTUExBWShkZXZfcHJpdikpCj4gKwkJcmV0dXJuOwo+ICsKPiArCWlmIChJTlRFTF9H RU4oZGV2X3ByaXYpID49IDExIHx8IElTX0dFTjlfTFAoZGV2X3ByaXYpKQo+ICsJCWJ4dF9lbmFi bGVfZGM5KGRldl9wcml2KTsKPiArCWVsc2UgaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElT X0JST0FEV0VMTChkZXZfcHJpdikpCj4gKwkJaHN3X2VuYWJsZV9wYzgoZGV2X3ByaXYpOwo+ICt9 Cj4gKwo+ICBzdGF0aWMgaW50IGk5MTVfZHJtX3N1c3BlbmRfbGF0ZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCBib29sIGhpYmVybmF0aW9uKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gQEAgLTIxMzMsMTIgKzIxNDQsMTAgQEAgc3Rh dGljIGludCBpOTE1X2RybV9zdXNwZW5kX2xhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgYm9v bCBoaWJlcm5hdGlvbikKPiAgCWludGVsX3Bvd2VyX2RvbWFpbnNfc3VzcGVuZChkZXZfcHJpdiwK PiAgCQkJCSAgICBnZXRfc3VzcGVuZF9tb2RlKGRldl9wcml2LCBoaWJlcm5hdGlvbikpOwo+ICAK PiArCWludGVsX2Rpc3BsYXlfc3VzcGVuZF9sYXRlKGRldl9wcml2KTsKPiArCj4gIAlyZXQgPSAw Owo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEgfHwgSVNfR0VOOV9MUChkZXZfcHJp dikpCj4gLQkJYnh0X2VuYWJsZV9kYzkoZGV2X3ByaXYpOwo+IC0JZWxzZSBpZiAoSVNfSEFTV0VM TChkZXZfcHJpdikgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkKPiAtCQloc3dfZW5hYmxlX3Bj OChkZXZfcHJpdik7Cj4gLQllbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19D SEVSUllWSUVXKGRldl9wcml2KSkKPiArCWlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJ U19DSEVSUllWSUVXKGRldl9wcml2KSkKPiAgCQlyZXQgPSB2bHZfc3VzcGVuZF9jb21wbGV0ZShk ZXZfcHJpdik7Cj4gIAo+ICAJaWYgKHJldCkgewo+IEBAIC0yMjY2LDYgKzIyNzUsMTkgQEAgc3Rh dGljIGludCBpOTE1X2RybV9yZXN1bWUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCXJldHVy biAwOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBpbnRlbF9kaXNwbGF5X3Jlc3VtZV9lYXJseShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiArCWlmICghSEFTX0RJU1BM QVkoZGV2X3ByaXYpKQo+ICsJCXJldHVybjsKPiArCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2 KSA+PSAxMSB8fCBJU19HRU45X0xQKGRldl9wcml2KSkgewo+ICsJCWdlbjlfc2FuaXRpemVfZGNf c3RhdGUoZGV2X3ByaXYpOwo+ICsJCWJ4dF9kaXNhYmxlX2RjOShkZXZfcHJpdik7Cj4gKwl9IGVs c2UgaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsK PiArCQloc3dfZGlzYWJsZV9wYzgoZGV2X3ByaXYpOwo+ICsJfQo+ICt9Cj4gKwo+ICBzdGF0aWMg aW50IGk5MTVfZHJtX3Jlc3VtZV9lYXJseShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gQEAg LTIzMjgsMTIgKzIzNTAsNyBAQCBzdGF0aWMgaW50IGk5MTVfZHJtX3Jlc3VtZV9lYXJseShzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAKPiAgCWk5MTVfY2hlY2tfYW5kX2NsZWFyX2ZhdWx0cyhk ZXZfcHJpdik7Cj4gIAo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEgfHwgSVNfR0VO OV9MUChkZXZfcHJpdikpIHsKPiAtCQlnZW45X3Nhbml0aXplX2RjX3N0YXRlKGRldl9wcml2KTsK PiAtCQlieHRfZGlzYWJsZV9kYzkoZGV2X3ByaXYpOwo+IC0JfSBlbHNlIGlmIChJU19IQVNXRUxM KGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7Cj4gLQkJaHN3X2Rpc2FibGVf cGM4KGRldl9wcml2KTsKPiAtCX0KPiArCWludGVsX2Rpc3BsYXlfcmVzdW1lX2Vhcmx5KGRldl9w cml2KTsKPiAgCj4gIAlpbnRlbF91bmNvcmVfc2FuaXRpemUoZGV2X3ByaXYpOwo+ICAKPiBAQCAt Mjg2OSw2ICsyODg2LDIyIEBAIHN0YXRpYyBpbnQgdmx2X3Jlc3VtZV9wcmVwYXJlKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gK3N0 YXRpYyB2b2lkIGludGVsX3J1bnRpbWVfZGlzcGxheV9zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiArewo+ICsJaWYgKCFIQVNfRElTUExBWShkZXZfcHJpdikpCj4g KwkJcmV0dXJuOwo+ICsKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKSB7Cj4gKwkJ aWNsX2Rpc3BsYXlfY29yZV91bmluaXQoZGV2X3ByaXYpOwo+ICsJCWJ4dF9lbmFibGVfZGM5KGRl dl9wcml2KTsKPiArCX0gZWxzZSBpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikpIHsKPiArCQlieHRf ZGlzcGxheV9jb3JlX3VuaW5pdChkZXZfcHJpdik7Cj4gKwkJYnh0X2VuYWJsZV9kYzkoZGV2X3By aXYpOwo+ICsJfSBlbHNlIGlmIChJU19IQVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwo ZGV2X3ByaXYpKSB7Cj4gKwkJaHN3X2VuYWJsZV9wYzgoZGV2X3ByaXYpOwo+ICsJfQo+ICt9Cj4g Kwo+ICBzdGF0aWMgaW50IGludGVsX3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICprZGV2 KQo+ICB7Cj4gIAlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoa2Rldik7Cj4gQEAg LTI4OTgsMTggKzI5MzEsMTEgQEAgc3RhdGljIGludCBpbnRlbF9ydW50aW1lX3N1c3BlbmQoc3Ry dWN0IGRldmljZSAqa2RldikKPiAgCj4gIAlpbnRlbF91bmNvcmVfc3VzcGVuZCgmZGV2X3ByaXYt PnVuY29yZSk7Cj4gIAo+ICsJaW50ZWxfcnVudGltZV9kaXNwbGF5X3N1c3BlbmQoZGV2X3ByaXYp Owo+ICsKPiAgCXJldCA9IDA7Cj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkgewo+ IC0JCWljbF9kaXNwbGF5X2NvcmVfdW5pbml0KGRldl9wcml2KTsKPiAtCQlieHRfZW5hYmxlX2Rj OShkZXZfcHJpdik7Cj4gLQl9IGVsc2UgaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpKSB7Cj4gLQkJ Ynh0X2Rpc3BsYXlfY29yZV91bmluaXQoZGV2X3ByaXYpOwo+IC0JCWJ4dF9lbmFibGVfZGM5KGRl dl9wcml2KTsKPiAtCX0gZWxzZSBpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikgfHwgSVNfQlJPQURX RUxMKGRldl9wcml2KSkgewo+IC0JCWhzd19lbmFibGVfcGM4KGRldl9wcml2KTsKPiAtCX0gZWxz ZSBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikp IHsKPiArCWlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9w cml2KSkKPiAgCQlyZXQgPSB2bHZfc3VzcGVuZF9jb21wbGV0ZShkZXZfcHJpdik7Cj4gLQl9Cj4g IAo+ICAJaWYgKHJldCkgewo+ICAJCURSTV9FUlJPUigiUnVudGltZSBzdXNwZW5kIGZhaWxlZCwg ZGlzYWJsaW5nIGl0ICglZClcbiIsIHJldCk7Cj4gQEAgLTI5NjcsMjUgKzI5OTMsMTAgQEAgc3Rh dGljIGludCBpbnRlbF9ydW50aW1lX3N1c3BlbmQoc3RydWN0IGRldmljZSAqa2RldikKPiAgCXJl dHVybiAwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGludGVsX3J1bnRpbWVfcmVzdW1lKHN0cnVj dCBkZXZpY2UgKmtkZXYpCj4gK3N0YXRpYyB2b2lkIGludGVsX3J1bnRpbWVfZGlzcGxheV9yZXN1 bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gLQlzdHJ1Y3QgcGNp X2RldiAqcGRldiA9IHRvX3BjaV9kZXYoa2Rldik7Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gcGNpX2dldF9kcnZkYXRhKHBkZXYpOwo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gdG9faTkxNShkZXYpOwo+IC0JaW50IHJldCA9IDA7Cj4gLQo+IC0JaWYgKFdBUk5f T05fT05DRSghSEFTX1JVTlRJTUVfUE0oZGV2X3ByaXYpKSkKPiAtCQlyZXR1cm4gLUVOT0RFVjsK PiAtCj4gLQlEUk1fREVCVUdfS01TKCJSZXN1bWluZyBkZXZpY2VcbiIpOwo+IC0KPiAtCVdBUk5f T05fT05DRShhdG9taWNfcmVhZCgmZGV2X3ByaXYtPnJ1bnRpbWVfcG0ud2FrZXJlZl9jb3VudCkp Owo+IC0JZGlzYWJsZV9ycG1fd2FrZXJlZl9hc3NlcnRzKGRldl9wcml2KTsKPiAtCj4gLQlpbnRl bF9vcHJlZ2lvbl9ub3RpZnlfYWRhcHRlcihkZXZfcHJpdiwgUENJX0QwKTsKPiAtCWRldl9wcml2 LT5ydW50aW1lX3BtLnN1c3BlbmRlZCA9IGZhbHNlOwo+IC0JaWYgKGludGVsX3VuY29yZV91bmNs YWltZWRfbW1pbygmZGV2X3ByaXYtPnVuY29yZSkpCj4gLQkJRFJNX0RFQlVHX0RSSVZFUigiVW5j bGFpbWVkIGFjY2VzcyBkdXJpbmcgc3VzcGVuZCwgYmlvcz9cbiIpOwo+ICsJaWYgKCFIQVNfRElT UExBWShkZXZfcHJpdikpCj4gKwkJcmV0dXJuOwo+ICAKPiAgCWlmIChJTlRFTF9HRU4oZGV2X3By aXYpID49IDExKSB7Cj4gIAkJYnh0X2Rpc2FibGVfZGM5KGRldl9wcml2KTsKPiBAQCAtMzAwNiw5 ICszMDE3LDMzIEBAIHN0YXRpYyBpbnQgaW50ZWxfcnVudGltZV9yZXN1bWUoc3RydWN0IGRldmlj ZSAqa2RldikKPiAgCQkJZ2VuOV9lbmFibGVfZGM1KGRldl9wcml2KTsKPiAgCX0gZWxzZSBpZiAo SVNfSEFTV0VMTChkZXZfcHJpdikgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkgewo+ICAJCWhz d19kaXNhYmxlX3BjOChkZXZfcHJpdik7Cj4gLQl9IGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2 X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKSB7Cj4gLQkJcmV0ID0gdmx2X3Jlc3Vt ZV9wcmVwYXJlKGRldl9wcml2LCB0cnVlKTsKPiAgCX0KPiArfQo+ICsKPiArc3RhdGljIGludCBp bnRlbF9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICprZGV2KQo+ICt7Cj4gKwlzdHJ1Y3Qg cGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoa2Rldik7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2ID0gcGNpX2dldF9kcnZkYXRhKHBkZXYpOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICsJaW50IHJldCA9IDA7Cj4gKwo+ICsJaWYgKFdB Uk5fT05fT05DRSghSEFTX1JVTlRJTUVfUE0oZGV2X3ByaXYpKSkKPiArCQlyZXR1cm4gLUVOT0RF VjsKPiArCj4gKwlEUk1fREVCVUdfS01TKCJSZXN1bWluZyBkZXZpY2VcbiIpOwo+ICsKPiArCVdB Uk5fT05fT05DRShhdG9taWNfcmVhZCgmZGV2X3ByaXYtPnJ1bnRpbWVfcG0ud2FrZXJlZl9jb3Vu dCkpOwo+ICsJZGlzYWJsZV9ycG1fd2FrZXJlZl9hc3NlcnRzKGRldl9wcml2KTsKPiArCj4gKwlp bnRlbF9vcHJlZ2lvbl9ub3RpZnlfYWRhcHRlcihkZXZfcHJpdiwgUENJX0QwKTsKPiArCWRldl9w cml2LT5ydW50aW1lX3BtLnN1c3BlbmRlZCA9IGZhbHNlOwo+ICsJaWYgKGludGVsX3VuY29yZV91 bmNsYWltZWRfbW1pbygmZGV2X3ByaXYtPnVuY29yZSkpCj4gKwkJRFJNX0RFQlVHX0RSSVZFUigi VW5jbGFpbWVkIGFjY2VzcyBkdXJpbmcgc3VzcGVuZCwgYmlvcz9cbiIpOwo+ICsKPiArCWludGVs X3J1bnRpbWVfZGlzcGxheV9yZXN1bWUoZGV2X3ByaXYpOwo+ICsKPiArCWlmIChJU19WQUxMRVlW SUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPiArCQlyZXQgPSB2bHZf cmVzdW1lX3ByZXBhcmUoZGV2X3ByaXYsIHRydWUpOwo+ICAKPiAgCWludGVsX3VuY29yZV9ydW50 aW1lX3Jlc3VtZSgmZGV2X3ByaXYtPnVuY29yZSk7CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9w ZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZng=