From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v8 1/2] drm/i915: Introduce async plane update to i915 Date: Fri, 08 Mar 2019 11:55:27 +0200 Message-ID: <87ftrx7ks0.fsf@intel.com> References: <20190307164948.12138-1-helen.koike@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9581189A5C for ; Fri, 8 Mar 2019 09:55:32 +0000 (UTC) In-Reply-To: <20190307164948.12138-1-helen.koike@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Helen Koike , dri-devel@lists.freedesktop.org Cc: tfiga@chromium.org, mcasas@google.com, zhenyu.z.wang@intel.com, daniel.vetter@ffwll.ch, tina.zhang@intel.com, kernel@collabora.com List-Id: dri-devel@lists.freedesktop.org ClBsZWFzZSBzZW5kIGRybS9pOTE1IHBhdGNoZXMgYWxzbyB0byBpbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnIHRvCnRyaWdnZXIgQ0kgb24gdGhlIHBhdGNoZXMgYW1vbmcgb3RoZXIgdGhp bmdzLgoKQlIsCkphbmkuCgoKT24gVGh1LCAwNyBNYXIgMjAxOSwgSGVsZW4gS29pa2UgPGhlbGVu LmtvaWtlQGNvbGxhYm9yYS5jb20+IHdyb3RlOgo+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3Vz dGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jb20+Cj4KPiBBZGQgaW1wbGVtZW50YXRpb24gZm9yIGFz eW5jIHBsYW5lIHVwZGF0ZSBjYWxsYmFja3MKPgo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gUGFk b3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRW5y aWMgQmFsbGV0Ym8gaSBTZXJyYSA8ZW5yaWMuYmFsbGV0Ym9AY29sbGFib3JhLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBUaW5hIFpoYW5nIDx0aW5hLnpoYW5nQGludGVsLmNvbT4KPiBTaWduZWQtb2Zm LWJ5OiBIZWxlbiBLb2lrZSA8aGVsZW4ua29pa2VAY29sbGFib3JhLmNvbT4KPgo+IC0tLQo+IEhp LAo+Cj4gVGhpcyBwYXRjaCBqdXN0IGFkZHMgdGhlIGNhbGxiYWNrcyBmb3IgYXRvbWljIGFzeW5j IHVwZGF0ZSwgdGhlIG5leHQgaW4KPiB0aGUgc2VyaWVzIHdpbGwgcmVwbGFjZSB0aGUgbGVnYWN5 IGN1cnNvciBpbXBsZW1lbnRhdGlvbiB3aXRoIHRoZXNlCj4gY2FsbGJhY2tzLgo+Cj4gSSB0ZXN0 ZWQgd2l0aCBpZ3QgKGtzbV9jdXJzb3JfbGVnYWN5IGFuZCBwbGFuZV9jdXJzb3JfbGVnYWN5KS4K Pgo+IFRoaXMgcGF0Y2ggZGVwZW5kcyBvbiAiW1BBVENIXSBkcm06IGRvbid0IGJsb2NrIGZiIGNo YW5nZXMgZm9yIGFzeW5jIHBsYW5lIHVwZGF0ZXMiLAo+IG90aGVyd2lzZSB0aGVyZSB3aWxsIGJl IGEgcmVncmVzc2lvbiBvbiBpZ3QgdGVzdHM6Cj4KPiAgICAgICAgIGN1cnNvci12cy1mbGlwLWF0 b21pYy10cmFuc2l0aW9ucy12YXJ5aW5nLXNpemUKPiAgICAgICAgIGN1cnNvci12cy1mbGlwLXRv Z2dsZQo+ICAgICAgICAgY3Vyc29yLXZzLWZsaXAtdmFyeWluZy1zaXplCj4KPiB3aXRoIGVycm9y cyBvZiB0eXBlOgo+Cj4gIkNSSVRJQ0FMOiBjb21wbGV0ZWQgOTcgY3Vyc29yIHVwZGF0ZWQgaW4g YSBwZXJpb2Qgb2YgMzAgZmxpcHMsIHdlCj4gZXhwZWN0IHRvIGNvbXBsZXRlIGFwcHJveGltYXRl bHkgMTUzNjAgdXBkYXRlcywgd2l0aCB0aGUgdGhyZXNob2xkIHNldAo+IGF0IDc2ODAiCj4KPiBU aGlzIGhhcHBlbnMgYmVjYXVzZSB3aGF0IHNob3VsZCBiZSBhc3luYyB1cGRhdGVzIGFyZSBiZWlu ZyB0dXJuZWQgaW50bwo+IHN5bmNyb25vdXMgdXBkYXRlcy4KPgo+IFRoYW5rcwo+IEhlbGVuCj4K PiBDaGFuZ2VzIGluIHY4Ogo+ICAtIHY3OiBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxOC82Lzgv MTY4Cj4gIC0gdjcgd2FzIHNwbGl0ZWQgaW4gdHdvLCBvbmUgdGhhdCBhZGRzIHRoZSBhc3luYyBj YWxsYmFja3MgYW5kIGFub3RoZXIKPiAgdGhhdCB1cGRhdGVzIHRoZSBjdXJzb3IuCj4gIC0gcmVi YXNlIHdpdGggZHJtLWludGVsCj4gIC0gYWxsb3cgYXN5bmMgdXBkYXRlIGluIGFsbCB0eXBlcyBv ZiBwbGFuZXMsIG5vdCBvbmx5IGN1cnNvcgo+ICAtIGFkZCB3YXRlcm1hcmsgY2hlY2tzIGluIGFz eW5jIHVwZGF0ZQo+ICAtIHJlbW92ZSBieXBhc3Mgb2YgaW50ZWxfcHJlcGFyZV9wbGFuZV9mYigp IGluIGNhc2Ugb2YgYXN5bmMgdXBkYXRlCj4gIC0gYWRkIG1pc3NpbmcgZHJtX2F0b21pY19oZWxw ZXJfY2xlYW51cF9wbGFuZXMoZGV2LCBzdGF0ZSkgY2FsbCBpbgo+ICBpbnRlbF9hdG9taWNfY29t bWl0KCkuCj4gIC0gdXNlIHN3YXAoKSBmdW5jdGlvbiBpbiBhc3luYyB1cGRhdGUgdG8gc2V0IHRo ZSBvbGRfZmIgaW4gdGhlCj4gIG5ld19zdGF0ZSBvYmplY3QuCj4gIC0gdXNlIGhlbHBlcnMgaW50 ZWxfdXBkYXRlX3BsYW5lKCkvaW50ZWxfZGlzYWJsZV9wbGFuZSgpCj4KPiBDaGFuZ2VzIGluIHY3 Ogo+IC0gUmViYXNlIG9uIHRvcCBvZiBkcm0taW50ZWwgcmVwb3NpdG9yeS4gSG9wZWZ1bGx5IG5v dyB3aWxsIHBsYXkKPiAgIG5pY2VseSB3aXRoIGF1dG9idWlsZGVycy4KPgo+IENoYW5nZXMgaW4g djY6Cj4gLSBSZXdvcmsgdGhlIGludGVsX3BsYW5lX2F0b21pY19hc3luY191cGRhdGUgZHVlIGRy aXZlciBjaGFuZ2VkIGZyb20KPiAgIGxhc3QgdGltZS4KPiAtIFJlbW92ZWQgdGhlIG11dGV4X2xv Y2svdW5sb2NrIGFzIGNhdXNlcyBhIGRlYWRsb2NrLgo+Cj4gQ2hhbmdlcyBpbiB2NToKPiAtIENh bGwgZHJtX2F0b21pY19oZWxwZXJfYXN5bmNfY2hlY2soKSBmcm9tIHRoZSBjaGVjayBob29rCj4K PiBDaGFuZ2VzIGluIHY0Ogo+IC0gU2V0IGNvcnJlY3Qgdm1hIHRvIG5ldyBzdGF0ZSBmb3IgY2xl YW51cAo+IC0gTW92ZSBzaXplIGNoZWNrcyBiYWNrIHRvIGRyaXZlcnMgKFZpbGxlIFN5cmrDpGzD pCkKPgo+IENoYW5nZXMgaW4gdjM6Cj4gLSBNb3ZlIGZiIHNldHRpbmcgdG8gY29yZSBhbmQgdXNl IG5ldyBzdGF0ZSAoRXJpYyBBbmhvbHQpCj4KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXRvbWljX3BsYW5lLmMgfCA3MSArKysrKysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgICAgICB8ICA5ICsrKwo+ICAyIGZpbGVzIGNoYW5n ZWQsIDgwIGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9hdG9taWNfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21p Y19wbGFuZS5jCj4gaW5kZXggNzk2MWNmMGU2OTUxLi5mNTE2YjIyN2RiYTkgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+IEBAIC0zMTgsMTAgKzMxOCw4 MSBAQCB2b2lkIGk5eHhfdXBkYXRlX3BsYW5lc19vbl9jcnRjKHN0cnVjdCBpbnRlbF9hdG9taWNf c3RhdGUgKnN0YXRlLAo+ICAJfQo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IGludGVsX3BsYW5lX2F0 b21pY19hc3luY19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiArCQkJCQkgIHN0cnVj dCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUg KmNydGNfc3RhdGU7Cj4gKwo+ICsJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5n X2NydGNfc3RhdGUoc3RhdGUtPnN0YXRlLAo+ICsJCQkJCQkJc3RhdGUtPmNydGMpOwo+ICsJaWYg KFdBUk5fT04oIWNydGNfc3RhdGUpKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCS8qCj4g KwkgKiBXaGVuIGNydGMgaXMgaW5hY3RpdmUgb3IgdGhlcmUgaXMgYSBtb2Rlc2V0IHBlbmRpbmcs Cj4gKwkgKiB3YWl0IGZvciBpdCB0byBjb21wbGV0ZSBpbiB0aGUgc2xvd3BhdGgKPiArCSAqLwo+ ICsJaWYgKCFjcnRjX3N0YXRlLT5hY3RpdmUgfHwgdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjX3N0 YXRlKS0+dXBkYXRlX3BpcGUpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJLyoKPiArCSAq IElmIGFueSBwYXJhbWV0ZXJzIGNoYW5nZSB0aGF0IG1heSBhZmZlY3Qgd2F0ZXJtYXJrcywKPiAr CSAqIHRha2UgdGhlIHNsb3dwYXRoLiBPbmx5IGNoYW5naW5nIGZiIG9yIHBvc2l0aW9uIHNob3Vs ZCBiZQo+ICsJICogaW4gdGhlIGZhc3RwYXRoLgo+ICsJICovCj4gKwlpZiAocGxhbmUtPnN0YXRl LT5jcnRjICE9IHN0YXRlLT5jcnRjIHx8Cj4gKwkgICAgcGxhbmUtPnN0YXRlLT5zcmNfdyAhPSBz dGF0ZS0+c3JjX3cgfHwKPiArCSAgICBwbGFuZS0+c3RhdGUtPnNyY19oICE9IHN0YXRlLT5zcmNf aCB8fAo+ICsJICAgIHBsYW5lLT5zdGF0ZS0+Y3J0Y193ICE9IHN0YXRlLT5jcnRjX3cgfHwKPiAr CSAgICBwbGFuZS0+c3RhdGUtPmNydGNfaCAhPSBzdGF0ZS0+Y3J0Y19oIHx8Cj4gKwkgICAgIXBs YW5lLT5zdGF0ZS0+ZmIgIT0gIXN0YXRlLT5mYikKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4g KwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgaW50ZWxfcGxhbmVfYXRvbWljX2Fz eW5jX3VwZGF0ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiArCQkJCQkgICAgc3RydWN0IGRy bV9wbGFuZV9zdGF0ZSAqbmV3X3N0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0 YXRlICppbnRlbF9uZXdfc3RhdGUgPQo+ICsJCXRvX2ludGVsX2F0b21pY19zdGF0ZShuZXdfc3Rh dGUtPnN0YXRlKTsKPiArCXN0cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxhbmUgPSB0b19pbnRl bF9wbGFuZShwbGFuZSk7Cj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBwbGFuZS0+c3RhdGUt PmNydGM7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGU7Cj4gKwlz dHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YzsKPiArCWludCBpOwo+ICsKPiArCWZvcl9lYWNo X25ld19pbnRlbF9jcnRjX2luX3N0YXRlKGludGVsX25ld19zdGF0ZSwgaW50ZWxfY3J0YywKPiAr CQkJCQkgbmV3X2NydGNfc3RhdGUsIGkpCj4gKwkJV0FSTl9PTihuZXdfY3J0Y19zdGF0ZS0+d20u bmVlZF9wb3N0dmJsX3VwZGF0ZSB8fAo+ICsJCQluZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3dtX3Bv c3QpOwo+ICsKPiArCWk5MTVfZ2VtX3RyYWNrX2ZiKGludGVsX2ZiX29iaihwbGFuZS0+c3RhdGUt PmZiKSwKPiArCQkJICBpbnRlbF9mYl9vYmoobmV3X3N0YXRlLT5mYiksCj4gKwkJCSAgaW50ZWxf cGxhbmUtPmZyb250YnVmZmVyX2JpdCk7Cj4gKwo+ICsJcGxhbmUtPnN0YXRlLT5zcmNfeCA9IG5l d19zdGF0ZS0+c3JjX3g7Cj4gKwlwbGFuZS0+c3RhdGUtPnNyY195ID0gbmV3X3N0YXRlLT5zcmNf eTsKPiArCXBsYW5lLT5zdGF0ZS0+Y3J0Y194ID0gbmV3X3N0YXRlLT5jcnRjX3g7Cj4gKwlwbGFu ZS0+c3RhdGUtPmNydGNfeSA9IG5ld19zdGF0ZS0+Y3J0Y195Owo+ICsKPiArCXN3YXAocGxhbmUt PnN0YXRlLT5mYiwgbmV3X3N0YXRlLT5mYik7Cj4gKwo+ICsJaWYgKHBsYW5lLT5zdGF0ZS0+dmlz aWJsZSkKPiArCQlpbnRlbF91cGRhdGVfcGxhbmUoaW50ZWxfcGxhbmUsCj4gKwkJCQkgICB0b19p bnRlbF9jcnRjX3N0YXRlKGNydGMtPnN0YXRlKSwKPiArCQkJCSAgIHRvX2ludGVsX3BsYW5lX3N0 YXRlKHBsYW5lLT5zdGF0ZSkpOwo+ICsJZWxzZQo+ICsJCWludGVsX2Rpc2FibGVfcGxhbmUoaW50 ZWxfcGxhbmUsCj4gKwkJCQkgICAgdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5zdGF0ZSkpOwo+ ICt9Cj4gKwo+ICBjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2hlbHBlcl9mdW5jcyBpbnRlbF9wbGFu ZV9oZWxwZXJfZnVuY3MgPSB7Cj4gIAkucHJlcGFyZV9mYiA9IGludGVsX3ByZXBhcmVfcGxhbmVf ZmIsCj4gIAkuY2xlYW51cF9mYiA9IGludGVsX2NsZWFudXBfcGxhbmVfZmIsCj4gIAkuYXRvbWlj X2NoZWNrID0gaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrLAo+ICsJLmF0b21pY19hc3luY19jaGVj ayA9IGludGVsX3BsYW5lX2F0b21pY19hc3luY19jaGVjaywKPiArCS5hdG9taWNfYXN5bmNfdXBk YXRlID0gaW50ZWxfcGxhbmVfYXRvbWljX2FzeW5jX3VwZGF0ZSwKPiAgfTsKPiAgCj4gIC8qKgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA0MTVkODk2OGYyYzUuLjI0 NGUxYzk0Mjc3ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAt MTM0NjQsNiArMTM0NjQsMTUgQEAgc3RhdGljIGludCBpbnRlbF9hdG9taWNfY29tbWl0KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGRldik7Cj4gIAlpbnQgcmV0ID0gMDsKPiAgCj4gKwlpZiAoc3RhdGUtPmFzeW5j X3VwZGF0ZSkgewo+ICsJCXJldCA9IGRybV9hdG9taWNfaGVscGVyX3ByZXBhcmVfcGxhbmVzKGRl diwgc3RhdGUpOwo+ICsJCWlmIChyZXQpCj4gKwkJCXJldHVybiByZXQ7Cj4gKwkJZHJtX2F0b21p Y19oZWxwZXJfYXN5bmNfY29tbWl0KGRldiwgc3RhdGUpOwo+ICsJCWRybV9hdG9taWNfaGVscGVy X2NsZWFudXBfcGxhbmVzKGRldiwgc3RhdGUpOwo+ICsJCXJldHVybiAwOwo+ICsJfQo+ICsKPiAg CWRybV9hdG9taWNfc3RhdGVfZ2V0KHN0YXRlKTsKPiAgCWk5MTVfc3dfZmVuY2VfaW5pdCgmaW50 ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSwKPiAgCQkJICAgaW50ZWxfYXRvbWljX2NvbW1pdF9yZWFk eSk7CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=