From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gregory CLEMENT <gregory.clement@bootlin.com>
Date: Thu, 13 Dec 2018 15:29:49 +0100
Subject: [U-Boot] [PATCH v3 4/7] MSCC: add support for Luton SoCs
In-Reply-To: <24b3159e-a4c6-320d-37ee-f949d4d5d0bf@gmail.com> (Daniel
 Schwierzeck's message of "Mon, 10 Dec 2018 18:03:25 +0100")
References: <20181205171054.926-1-gregory.clement@bootlin.com>
 <20181205171054.926-5-gregory.clement@bootlin.com>
 <24b3159e-a4c6-320d-37ee-f949d4d5d0bf@gmail.com>
Message-ID: <87ftv1lcte.fsf@bootlin.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hi Daniel,
=20
 On lun., d=C3=A9c. 10 2018, Daniel Schwierzeck <daniel.schwierzeck@gmail.c=
om> wrote:
>> +static inline int hal_vcoreiii_train_bytelane(u32 bytelane)
>> +{
>> +	register int res;
>> +
>> +	set_dly(bytelane, 0);	// Start training at DQS=3D0
>
> no C++ style comments
>
OK
[...]
>> +	for (i =3D 0; i < 8; i++) {
>> +		DDR[i] =3D ~i;
>> +		if (DDR[i] !=3D ~i)
>
> __raw_readl(), __raw_writel() ?

OK

[...]
>> +++ b/arch/mips/mach-mscc/include/mach/luton/luton.h
>> @@ -0,0 +1,24 @@
>> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
>
> this line should begin with a //. Please fix all files in this patch.

As explained in the previous patch /* */ is the correct comment style for
SPDX in C header file

[...]
>> +	/* Wait for lock */
>> +2:	lw	v0, MACRO_CTRL_PLL5G_STATUS_PLL5G_STATUS0
>> +	andi	v1, v0, MACRO_CTRL_PLL5G_STATUS_PLL5G_STATUS0_LOCK_STATUS
>> +	# Keep looping if zero (no lock bit yet)
>
> should be a C style comment

OK

Thanks,

Gregory

--=20
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com