All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf
@ 2018-09-23 13:50 Thomas Petazzoni
  2018-09-25 20:26 ` Thomas Petazzoni
  2018-10-05 12:09 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-09-23 13:50 UTC (permalink / raw)
  To: buildroot

The configure script of xutil_makedepend uses PKG_CHECK_MODULES(), so
it should depend on host-pkgconf. Otherwise, a "make
host-xutil_makedepend" fails with:

"""
checking for X... configure: error: in `/home/thomas/projets/buildroot/output/build/host-xutil_makedepend-1.0.5':
configure: error: The pkg-config script could not be found or is too old.  Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.

Alternatively, you may set the environment variables X_CFLAGS
and X_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

To get pkg-config, see <http://pkg-config.freedesktop.org/>.
"""

This was detected using per-package host/target directories, but can
be reproduced without it.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/x11r7/xutil_makedepend/xutil_makedepend.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/x11r7/xutil_makedepend/xutil_makedepend.mk b/package/x11r7/xutil_makedepend/xutil_makedepend.mk
index 8a058efcec..a50320ba93 100644
--- a/package/x11r7/xutil_makedepend/xutil_makedepend.mk
+++ b/package/x11r7/xutil_makedepend/xutil_makedepend.mk
@@ -10,8 +10,8 @@ XUTIL_MAKEDEPEND_SITE = http://xorg.freedesktop.org/releases/individual/util
 XUTIL_MAKEDEPEND_LICENSE = MIT
 XUTIL_MAKEDEPEND_LICENSE_FILES = COPYING
 
-XUTIL_MAKEDEPEND_DEPENDENCIES = xorgproto
-HOST_XUTIL_MAKEDEPEND_DEPENDENCIES = host-xorgproto
+XUTIL_MAKEDEPEND_DEPENDENCIES = xorgproto host-pkgconf
+HOST_XUTIL_MAKEDEPEND_DEPENDENCIES = host-xorgproto host-pkgconf
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.14.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf
  2018-09-23 13:50 [Buildroot] [PATCH] package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf Thomas Petazzoni
@ 2018-09-25 20:26 ` Thomas Petazzoni
  2018-10-05 12:09 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-09-25 20:26 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 23 Sep 2018 15:50:07 +0200, Thomas Petazzoni wrote:
> The configure script of xutil_makedepend uses PKG_CHECK_MODULES(), so
> it should depend on host-pkgconf. Otherwise, a "make
> host-xutil_makedepend" fails with:
> 
> """
> checking for X... configure: error: in `/home/thomas/projets/buildroot/output/build/host-xutil_makedepend-1.0.5':
> configure: error: The pkg-config script could not be found or is too old.  Make sure it
> is in your PATH or set the PKG_CONFIG environment variable to the full
> path to pkg-config.
> 
> Alternatively, you may set the environment variables X_CFLAGS
> and X_LIBS to avoid the need to call pkg-config.
> See the pkg-config man page for more details.
> 
> To get pkg-config, see <http://pkg-config.freedesktop.org/>.
> """
> 
> This was detected using per-package host/target directories, but can
> be reproduced without it.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/x11r7/xutil_makedepend/xutil_makedepend.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf
  2018-09-23 13:50 [Buildroot] [PATCH] package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf Thomas Petazzoni
  2018-09-25 20:26 ` Thomas Petazzoni
@ 2018-10-05 12:09 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-10-05 12:09 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > The configure script of xutil_makedepend uses PKG_CHECK_MODULES(), so
 > it should depend on host-pkgconf. Otherwise, a "make
 > host-xutil_makedepend" fails with:

 > """
 > checking for X... configure: error: in
 > `/home/thomas/projets/buildroot/output/build/host-xutil_makedepend-1.0.5':
 > configure: error: The pkg-config script could not be found or is too old.  Make sure it
 > is in your PATH or set the PKG_CONFIG environment variable to the full
 > path to pkg-config.

 > Alternatively, you may set the environment variables X_CFLAGS
 > and X_LIBS to avoid the need to call pkg-config.
 > See the pkg-config man page for more details.

 > To get pkg-config, see <http://pkg-config.freedesktop.org/>.
 > """

 > This was detected using per-package host/target directories, but can
 > be reproduced without it.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-05 12:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-23 13:50 [Buildroot] [PATCH] package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf Thomas Petazzoni
2018-09-25 20:26 ` Thomas Petazzoni
2018-10-05 12:09 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.