From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966450AbdJRFpc (ORCPT ); Wed, 18 Oct 2017 01:45:32 -0400 Received: from ozlabs.org ([103.22.144.67]:48383 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965804AbdJRFpa (ORCPT ); Wed, 18 Oct 2017 01:45:30 -0400 From: Michael Ellerman To: Mathieu Desnoyers Cc: "Paul E. McKenney" , Boqun Feng , Peter Zijlstra , Paul Turner , Andrew Hunter , Andy Lutomirski , Dave Watson , Josh Triplett , Will Deacon , linux-kernel , Russell King , Catalin Marinas , Thomas Gleixner , Andi Kleen , Chris Lameter , Ingo Molnar , "H. Peter Anvin" , Ben Maurer , rostedt , Linus Torvalds , Andrew Morton , shuah , linux-kselftest , linux-api Subject: Re: [RFC PATCH for 4.15 14/14] Restartable sequences: Provide self-tests In-Reply-To: <1618170495.42951.1508248216596.JavaMail.zimbra@efficios.com> References: <20171012230326.19984-1-mathieu.desnoyers@efficios.com> <20171012230326.19984-15-mathieu.desnoyers@efficios.com> <871sm3n6sy.fsf@concordia.ellerman.id.au> <1998166049.42520.1508179805908.JavaMail.zimbra@efficios.com> <87d15mjc1g.fsf@concordia.ellerman.id.au> <1618170495.42951.1508248216596.JavaMail.zimbra@efficios.com> Date: Wed, 18 Oct 2017 16:45:28 +1100 Message-ID: <87fuahhuvb.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mathieu Desnoyers writes: > ----- On Oct 17, 2017, at 6:36 AM, Michael Ellerman mpe@ellerman.id.au wrote: > >> Mathieu Desnoyers writes: >> >>> Hi Michael, >>> >>> With your changes integrated, both rseq and cpu-opv selftests fail to >>> build if I pass e.g. -j32 to make. >>> >>> cd tools/testing/selftests/cpu-opv >>> >>> efficios@compudjdev:~/git/linux-percpu-dev/tools/testing/selftests/cpu-opv$ make >>> clean; make >>> rm -f -r >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test >>> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ basic_cpu_opv_test.c >>> cpu-op.c cpu-op.h -o basic_cpu_opv_test >>> >>> efficios@compudjdev:~/git/linux-percpu-dev/tools/testing/selftests/cpu-opv$ make >>> clean; make -j32 >>> rm -f -r >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test >>> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ basic_cpu_opv_test.c >>> cpu-op.c cpu-op.h -o basic_cpu_opv_test >>> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ basic_cpu_opv_test.c -o >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test >>> /tmp/ccDthnqM.o: In function `test_memcpy_op': >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test.c:364: >>> undefined reference to `cpu_op_get_current_cpu' >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test.c:365: >>> undefined reference to `cpu_opv' >> ... >>> make: *** >>> [/home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test] >>> Error 1 >>> make: *** Waiting for unfinished jobs.... >>> >>> Any idea what is going on here ? >> >> Ugh sorry, yes. >> >> New patch below should fix it. Tested with -j: > > Perfect, folding it into my series. Thanks. > I see that the "all" target was redundant here. Yeah. Unfortunately lib.mk has grown a bit more complicated than I would like, including defining the all target. It does make for nice short Makefiles for individual test directories, but it's not all that easy to use if you're not familiar with it [or even if you are, as I demostrated here :)] cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [RFC PATCH for 4.15 14/14] Restartable sequences: Provide self-tests Date: Wed, 18 Oct 2017 16:45:28 +1100 Message-ID: <87fuahhuvb.fsf@concordia.ellerman.id.au> References: <20171012230326.19984-1-mathieu.desnoyers@efficios.com> <20171012230326.19984-15-mathieu.desnoyers@efficios.com> <871sm3n6sy.fsf@concordia.ellerman.id.au> <1998166049.42520.1508179805908.JavaMail.zimbra@efficios.com> <87d15mjc1g.fsf@concordia.ellerman.id.au> <1618170495.42951.1508248216596.JavaMail.zimbra@efficios.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1618170495.42951.1508248216596.JavaMail.zimbra-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mathieu Desnoyers Cc: "Paul E. McKenney" , Boqun Feng , Peter Zijlstra , Paul Turner , Andrew Hunter , Andy Lutomirski , Dave Watson , Josh Triplett , Will Deacon , linux-kernel , Russell King , Catalin Marinas , Thomas Gleixner , Andi Kleen , Chris Lameter , Ingo Molnar , "H. Peter Anvin" , Ben Maurer , rostedt , Linus Torvalds , Andrew Morton List-Id: linux-api@vger.kernel.org Mathieu Desnoyers writes: > ----- On Oct 17, 2017, at 6:36 AM, Michael Ellerman mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org wrote: > >> Mathieu Desnoyers writes: >> >>> Hi Michael, >>> >>> With your changes integrated, both rseq and cpu-opv selftests fail to >>> build if I pass e.g. -j32 to make. >>> >>> cd tools/testing/selftests/cpu-opv >>> >>> efficios@compudjdev:~/git/linux-percpu-dev/tools/testing/selftests/cpu-opv$ make >>> clean; make >>> rm -f -r >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test >>> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ basic_cpu_opv_test.c >>> cpu-op.c cpu-op.h -o basic_cpu_opv_test >>> >>> efficios@compudjdev:~/git/linux-percpu-dev/tools/testing/selftests/cpu-opv$ make >>> clean; make -j32 >>> rm -f -r >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test >>> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ basic_cpu_opv_test.c >>> cpu-op.c cpu-op.h -o basic_cpu_opv_test >>> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ basic_cpu_opv_test.c -o >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test >>> /tmp/ccDthnqM.o: In function `test_memcpy_op': >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test.c:364: >>> undefined reference to `cpu_op_get_current_cpu' >>> /home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test.c:365: >>> undefined reference to `cpu_opv' >> ... >>> make: *** >>> [/home/efficios/git/linux-percpu-dev/tools/testing/selftests/cpu-opv/basic_cpu_opv_test] >>> Error 1 >>> make: *** Waiting for unfinished jobs.... >>> >>> Any idea what is going on here ? >> >> Ugh sorry, yes. >> >> New patch below should fix it. Tested with -j: > > Perfect, folding it into my series. Thanks. > I see that the "all" target was redundant here. Yeah. Unfortunately lib.mk has grown a bit more complicated than I would like, including defining the all target. It does make for nice short Makefiles for individual test directories, but it's not all that easy to use if you're not familiar with it [or even if you are, as I demostrated here :)] cheers