From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 16/16] arm64: dts: marvell: armada-3720-espressobin: fill UART nodes Date: Fri, 06 Oct 2017 15:01:18 +0200 Message-ID: <87fuawe8gx.fsf@free-electrons.com> References: <20171006101344.15590-1-miquel.raynal@free-electrons.com> <20171006101344.15590-17-miquel.raynal@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20171006101344.15590-17-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> (Miquel Raynal's message of "Fri, 6 Oct 2017 12:13:44 +0200") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Miquel Raynal Cc: Greg Kroah-Hartman , Linus Walleij , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Jiri Slaby , Catalin Marinas , Will Deacon , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Petazzoni , Antoine Tenart , Nadav Haklai , Wilson Ding List-Id: linux-gpio@vger.kernel.org Hi Miquel, On ven., oct. 06 2017, Miquel Raynal wrote: > Fill ESPRESSObin uart0 node with pinctrl information like in the > Armada-3720-DB device tree (which uses the same node). > > Also explain how to enable the second UART port available on the > headers. This second port is not enabled by default because both > headers are dedicated to expose general purpose pins and remapping > some of them to use the second UART would break existing users. > > Suggested-by: László ÁSHIN > Signed-off-by: Miquel Raynal > --- > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > index 2ce52ba74f73..c05b274ab1a9 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > @@ -98,9 +98,17 @@ > > /* Exported on the micro USB connector J5 through an FTDI */ > &uart0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart1_pins>; > status = "okay"; > }; > > +/* > + * Enabling the second UART on J17 (pins 24,26) is just a matter of copying the > + * uart1 node from armada-3720-db.dts with one difference: it works with 1.8V > + * TTL levels. This difference is not related to the device tree. So I would write: /* * To enable the second UART on J17 (pins 24,26) refer to the uart1 * node from armada-3720-db.dts. * Note that TX and RX signal are the ones coming directly from the SoC: * 1.8V TTL. */ Thanks, Gregory > + */ > + > /* J7 */ > &usb3 { > status = "okay"; > -- > 2.11.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Fri, 06 Oct 2017 15:01:18 +0200 Subject: [PATCH 16/16] arm64: dts: marvell: armada-3720-espressobin: fill UART nodes In-Reply-To: <20171006101344.15590-17-miquel.raynal@free-electrons.com> (Miquel Raynal's message of "Fri, 6 Oct 2017 12:13:44 +0200") References: <20171006101344.15590-1-miquel.raynal@free-electrons.com> <20171006101344.15590-17-miquel.raynal@free-electrons.com> Message-ID: <87fuawe8gx.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Miquel, On ven., oct. 06 2017, Miquel Raynal wrote: > Fill ESPRESSObin uart0 node with pinctrl information like in the > Armada-3720-DB device tree (which uses the same node). > > Also explain how to enable the second UART port available on the > headers. This second port is not enabled by default because both > headers are dedicated to expose general purpose pins and remapping > some of them to use the second UART would break existing users. > > Suggested-by: L?szl? ?SHIN > Signed-off-by: Miquel Raynal > --- > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > index 2ce52ba74f73..c05b274ab1a9 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > @@ -98,9 +98,17 @@ > > /* Exported on the micro USB connector J5 through an FTDI */ > &uart0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart1_pins>; > status = "okay"; > }; > > +/* > + * Enabling the second UART on J17 (pins 24,26) is just a matter of copying the > + * uart1 node from armada-3720-db.dts with one difference: it works with 1.8V > + * TTL levels. This difference is not related to the device tree. So I would write: /* * To enable the second UART on J17 (pins 24,26) refer to the uart1 * node from armada-3720-db.dts. * Note that TX and RX signal are the ones coming directly from the SoC: * 1.8V TTL. */ Thanks, Gregory > + */ > + > /* J7 */ > &usb3 { > status = "okay"; > -- > 2.11.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com