Re: [Qemu-devel] [PATCH v4 03/20] instrument: Add generic library loader

["Lluís Vilanova" <vilanova@ac.upc.edu>]

Emilio G Cota writes:

> On Wed, Sep 06, 2017 at 20:34:48 +0300, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
>> ---
> (snip)
>> diff --git a/configure b/configure
>> index 80dcc91c98..05bd7b1950 100755
>> --- a/configure
>> +++ b/configure
>> @@ -6034,6 +6034,8 @@ fi
>> echo "CONFIG_TRACE_FILE=$trace_file" >> $config_host_mak
>> 
>> if test "$instrument" = "yes"; then
>> +  LDFLAGS="-rdynamic $LDFLAGS"          # limit symbols available to clients

> -rdynamic exports all objects to the instrumenters, not the other way around.
> You can see it with nm(1).

I'll send a minor fix for this in next version.


> BTW I'm using ebf447b5b from your qemu-dbi repo. Is that the same as this
> patchset? It doesn't compile with --enable-instrument:
> $ make
>   CC      x86_64-linux-user/instrument/trace.o
> /data/src/qemu2/instrument/trace.c:12:30: fatal error: qemu-instr/trace.h: No such file or directory
> compilation terminated.
> /data/src/qemu2/rules.mak:66: recipe for target 'instrument/trace.o' failed
> make[1]: *** [instrument/trace.o] Error 1
> Makefile:326: recipe for target 'subdir-x86_64-linux-user' failed
> make: *** [subdir-x86_64-linux-user] Error 2

No, I started using a separate branch to keep the old patches around in the
meantime.


> 		Emilio


Lluis