All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] slang: use correct ncurses config script name
@ 2017-03-26  6:36 Rodrigo Rebello
  2017-03-26  6:36 ` [Buildroot] [PATCH 2/2] htop: " Rodrigo Rebello
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Rodrigo Rebello @ 2017-03-26  6:36 UTC (permalink / raw)
  To: buildroot

The ncurses config script can have different names depending on the
configuration (e.g. wchar support enabled/disabled). So, use
$(NCURSES_CONFIG_SCRIPTS) from the ncurses package as it contains the
proper name.

Fixes:

  http://autobuild.buildroot.net/results/c97554c05e121c76407be53ba37924cfcb658e9d/
  http://autobuild.buildroot.net/results/b0a31a3491a30ee0d6e6e7dbba68a86f0e00943d/
  http://autobuild.buildroot.net/results/a77241141cf8710fa945523ef62327798e3c4824/
  [...]

Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>
---
 package/slang/slang.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/slang/slang.mk b/package/slang/slang.mk
index 9078bf293..e6abdeebe 100644
--- a/package/slang/slang.mk
+++ b/package/slang/slang.mk
@@ -40,7 +40,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_NCURSES),y)
 SLANG_DEPENDENCIES += ncurses
-SLANG_CONF_ENV += ac_cv_path_nc5config=$(STAGING_DIR)/usr/bin/ncurses5-config
+SLANG_CONF_ENV += ac_cv_path_nc5config=$(STAGING_DIR)/usr/bin/$(NCURSES_CONFIG_SCRIPTS)
 else
 SLANG_CONF_OPTS += ac_cv_path_nc5config=no
 endif
@@ -49,7 +49,7 @@ ifeq ($(BR2_PACKAGE_READLINE),y)
 SLANG_CONF_OPTS += --with-readline=gnu
 SLANG_DEPENDENCIES += readline
 ifeq ($(BR2_STATIC_LIBS),y)
-SLANG_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/ncurses5-config --libs`"
+SLANG_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/$(NCURSES_CONFIG_SCRIPTS) --libs`"
 endif
 endif
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] htop: use correct ncurses config script name
  2017-03-26  6:36 [Buildroot] [PATCH 1/2] slang: use correct ncurses config script name Rodrigo Rebello
@ 2017-03-26  6:36 ` Rodrigo Rebello
  2017-03-31  7:03   ` Peter Korsgaard
  2017-03-26 10:32 ` [Buildroot] [PATCH 1/2] slang: " Thomas Petazzoni
  2017-03-31  7:02 ` Peter Korsgaard
  2 siblings, 1 reply; 5+ messages in thread
From: Rodrigo Rebello @ 2017-03-26  6:36 UTC (permalink / raw)
  To: buildroot

The ncurses config script can have different names depending on the
configuration (e.g. wchar support enabled/disabled). So, use
$(NCURSES_CONFIG_SCRIPTS) from the ncurses package as it contains the
proper name.

Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>
---
 package/htop/htop.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/htop/htop.mk b/package/htop/htop.mk
index 9451d159f..dd3bed41b 100644
--- a/package/htop/htop.mk
+++ b/package/htop/htop.mk
@@ -8,7 +8,7 @@ HTOP_VERSION = 2.0.2
 HTOP_SITE = http://hisham.hm/htop/releases/$(HTOP_VERSION)
 HTOP_DEPENDENCIES = ncurses
 # Prevent htop build system from searching the host paths
-HTOP_CONF_ENV = HTOP_NCURSES_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/ncurses5-config
+HTOP_CONF_ENV = HTOP_NCURSES_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/$(NCURSES_CONFIG_SCRIPTS)
 HTOP_LICENSE = GPLv2
 HTOP_LICENSE_FILES = COPYING
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/2] slang: use correct ncurses config script name
  2017-03-26  6:36 [Buildroot] [PATCH 1/2] slang: use correct ncurses config script name Rodrigo Rebello
  2017-03-26  6:36 ` [Buildroot] [PATCH 2/2] htop: " Rodrigo Rebello
@ 2017-03-26 10:32 ` Thomas Petazzoni
  2017-03-31  7:02 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-03-26 10:32 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 26 Mar 2017 03:36:53 -0300, Rodrigo Rebello wrote:
> The ncurses config script can have different names depending on the
> configuration (e.g. wchar support enabled/disabled). So, use
> $(NCURSES_CONFIG_SCRIPTS) from the ncurses package as it contains the
> proper name.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/c97554c05e121c76407be53ba37924cfcb658e9d/
>   http://autobuild.buildroot.net/results/b0a31a3491a30ee0d6e6e7dbba68a86f0e00943d/
>   http://autobuild.buildroot.net/results/a77241141cf8710fa945523ef62327798e3c4824/
>   [...]
> 
> Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>
> ---
>  package/slang/slang.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Both applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/2] slang: use correct ncurses config script name
  2017-03-26  6:36 [Buildroot] [PATCH 1/2] slang: use correct ncurses config script name Rodrigo Rebello
  2017-03-26  6:36 ` [Buildroot] [PATCH 2/2] htop: " Rodrigo Rebello
  2017-03-26 10:32 ` [Buildroot] [PATCH 1/2] slang: " Thomas Petazzoni
@ 2017-03-31  7:02 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2017-03-31  7:02 UTC (permalink / raw)
  To: buildroot

>>>>> "Rodrigo" == Rodrigo Rebello <rprebello@gmail.com> writes:

 > The ncurses config script can have different names depending on the
 > configuration (e.g. wchar support enabled/disabled). So, use
 > $(NCURSES_CONFIG_SCRIPTS) from the ncurses package as it contains the
 > proper name.

 > Fixes:

 >   http://autobuild.buildroot.net/results/c97554c05e121c76407be53ba37924cfcb658e9d/
 >   http://autobuild.buildroot.net/results/b0a31a3491a30ee0d6e6e7dbba68a86f0e00943d/
 >   http://autobuild.buildroot.net/results/a77241141cf8710fa945523ef62327798e3c4824/
 >   [...]

 > Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] htop: use correct ncurses config script name
  2017-03-26  6:36 ` [Buildroot] [PATCH 2/2] htop: " Rodrigo Rebello
@ 2017-03-31  7:03   ` Peter Korsgaard
  0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2017-03-31  7:03 UTC (permalink / raw)
  To: buildroot

>>>>> "Rodrigo" == Rodrigo Rebello <rprebello@gmail.com> writes:

 > The ncurses config script can have different names depending on the
 > configuration (e.g. wchar support enabled/disabled). So, use
 > $(NCURSES_CONFIG_SCRIPTS) from the ncurses package as it contains the
 > proper name.

 > Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-03-31  7:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-26  6:36 [Buildroot] [PATCH 1/2] slang: use correct ncurses config script name Rodrigo Rebello
2017-03-26  6:36 ` [Buildroot] [PATCH 2/2] htop: " Rodrigo Rebello
2017-03-31  7:03   ` Peter Korsgaard
2017-03-26 10:32 ` [Buildroot] [PATCH 1/2] slang: " Thomas Petazzoni
2017-03-31  7:02 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.