From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH 14/14 V2] rtlwifi: Remove some redundant code
Date: Fri, 30 Dec 2016 15:53:03 +0200 [thread overview]
Message-ID: <87ful5jzgg.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20161215182310.13713-15-Larry.Finger@lwfinger.net> (Larry Finger's message of "Thu, 15 Dec 2016 12:23:10 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> The symbol DBG_EMERG is no longer used and is removed.
>
> In a number of places, the code has redundant messages. For example, if
> the failure for the firmware to run is logged, it is not necessary to
> log that the firmware has been started. In addition, extraneous braces are
> removed.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
[...]
> --- wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/debug.h
> +++ wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/debug.h
> @@ -36,7 +36,7 @@
> *unexpected HW behavior, HW BUG
> *and so on.
> */
> -#define DBG_EMERG 0
> +/*#define DBG_EMERG 0 */
You are not really removing, just commenting it out :) But this is good
enough for me, if you really want to remove it submit a followup patch.
--
Kalle Valo
next prev parent reply other threads:[~2016-12-30 13:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 18:22 [PATCH 00/14 V2] rtlwifi: Start reworking of debug system Larry Finger
2016-12-15 18:22 ` [PATCH 01/14 V2] rtlwifi: Replace local debug macro RT_ASSERT Larry Finger
2016-12-30 13:55 ` [01/14,V2] " Kalle Valo
2016-12-15 18:22 ` [PATCH 02/14 V2] rtlwifi: Remove RT_TRACE messages that use DBG_EMERG Larry Finger
2016-12-16 19:31 ` Joe Perches
2016-12-15 18:22 ` [PATCH 03/14 V2] rtlwifi: rtl8821ae: Remove all instances of DBG_EMERG Larry Finger
2016-12-16 19:34 ` Joe Perches
2016-12-15 18:23 ` [PATCH 04/14 V2] rtlwifi: rtl8723be: " Larry Finger
2016-12-15 18:23 ` [PATCH 05/14 V2] rtlwifi: rtl8723ae: " Larry Finger
2016-12-15 18:23 ` [PATCH 06/14 V2] rtlwifi: rtl8192ee: " Larry Finger
2016-12-15 18:23 ` [PATCH 07/14 V2] rtlwifi: rtl8723-common: " Larry Finger
2016-12-15 18:23 ` [PATCH 08/14] rtlwifi: rtl8192se: " Larry Finger
2016-12-15 18:23 ` [PATCH 09/14 V2] rtlwifi: rtl8192de: " Larry Finger
2016-12-15 18:23 ` [PATCH 10/14 V2] rtlwifi: rtl8192cu: " Larry Finger
2016-12-15 18:23 ` [PATCH 11/14 V2] rtlwifi: rtl8192ce: " Larry Finger
2016-12-15 18:23 ` [PATCH 12/14 V2] rtlwifi: rtl8192c-common: " Larry Finger
2016-12-15 18:23 ` [PATCH 13/14 V2] rtlwifi: rtl8188ee: " Larry Finger
2016-12-15 18:23 ` [PATCH 14/14 V2] rtlwifi: Remove some redundant code Larry Finger
2016-12-30 13:53 ` Kalle Valo [this message]
2017-01-10 9:55 ` [PATCH next] rtlwifi: rtl8192de: fix missing curly braces Vincent Stehlé
2017-01-12 15:11 ` [next] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ful5jzgg.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.