From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtx4-0004jJ-38 for qemu-devel@nongnu.org; Thu, 11 Feb 2016 11:18:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTtwy-0003tM-Vx for qemu-devel@nongnu.org; Thu, 11 Feb 2016 11:18:42 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:56391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtwy-0003sc-CD for qemu-devel@nongnu.org; Thu, 11 Feb 2016 11:18:36 -0500 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Feb 2016 16:18:33 -0000 From: Sascha Silbe In-Reply-To: <20160211101831.3ba6dcf9.cornelia.huck@de.ibm.com> References: <1455023713-104799-1-git-send-email-silbe@linux.vnet.ibm.com> <1455023713-104799-3-git-send-email-silbe@linux.vnet.ibm.com> <87h9hfk4cw.fsf@blackfin.pond.sub.org> <20160211101831.3ba6dcf9.cornelia.huck@de.ibm.com> Date: Thu, 11 Feb 2016 17:18:32 +0100 Message-ID: <87fuwzcjaf.fsf@oc4731375738.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] qdev-monitor: add missing aliases for virtio-{9p, balloon, rng, scsi} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Markus Armbruster Cc: Kevin Wolf , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Alexander Graf , Tu Bo , Christian Borntraeger Dear Conny, Cornelia Huck writes: > On Thu, 11 Feb 2016 10:01:35 +0100 > Markus Armbruster wrote: > >> Sascha Silbe writes: > >> > This leaves out >> > virtio-{gpu,input,input-hid,input-host,keyboard,mouse,tablet} because >> > they're currently only implemented using PCI, so there's no immediate >> > value in having them. It would nevertheless make sense to include them >> > so they can get used already and will start to Just Work=E2=84=A2 on s= 390x >> > once a CCW implementation appears. I can post the corresponding patch >> > if there's any interest. >>=20 >> I guess that's for the virtio people to decide. I'm cc'ing some. > > What would the error look like if one decided to use e.g. virtio-gpu on > s390x? If the error is more specific (i.e. virtio-gpu-ccw does not > exist vs. virtio-gpu does not exist), I think adding the aliases makes > sense: the user sees what is actually missing. Interesting point. Indeed, if we already define the matching -ccw aliases, the error message may be slightly more useful: silbe@oc4731375738:~/recoverable/qemu$ s390x-softmmu/qemu-system-s390x -dev= ice virtio-gpu qemu-system-s390x: -device virtio-gpu: 'virtio-gpu-ccw' is not a valid devi= ce model name Though we should probably at least add a comment to the alias list mentioning that this is intentional. We might even want to adjust qdev_get_device_class() to print a more specific error message in this case. Sascha --=20 Softwareentwicklung Sascha Silbe, Niederhofenstra=C3=9Fe 5/1, 71229 Leonberg https://se-silbe.de/ USt-IdNr. DE281696641