From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQDQ3-00040E-3q for qemu-devel@nongnu.org; Mon, 01 Feb 2016 07:17:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQDPy-0005yZ-4b for qemu-devel@nongnu.org; Mon, 01 Feb 2016 07:17:23 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:35692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQDPx-0005xV-O6 for qemu-devel@nongnu.org; Mon, 01 Feb 2016 07:17:18 -0500 Received: by mail-wm0-x22d.google.com with SMTP id r129so67502684wmr.0 for ; Mon, 01 Feb 2016 04:17:17 -0800 (PST) References: <1454083668-23520-1-git-send-email-stefanha@redhat.com> <87r3h0gwxm.fsf@linaro.org> <20160201113716.GC4642@stefanha-x1.localdomain> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20160201113716.GC4642@stefanha-x1.localdomain> Date: Mon, 01 Feb 2016 12:17:14 +0000 Message-ID: <87fuxcpqut.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org Stefan Hajnoczi writes: > On Fri, Jan 29, 2016 at 04:41:41PM +0000, Alex Bennée wrote: >> >> Stefan Hajnoczi writes: >> >> > The GThread coroutine backend was a portable coroutine implementation. >> > Over the years all platforms got their own optimized coroutine >> > implementations and nothing uses the GThread backend anymore. >> > >> > In fact, ./configure mentions the GThread backend doesn't work but might >> > be useful for debugging. Since GDB macros were added to ease debugging >> > of ucontext coroutines, there seems little point in keeping a broken >> > backend around. >> >> Except I found that I couldn't run the ThreadSanitizer without using the >> gthread co-routines. So while I totally agree we should dump stuff >> that's not used lets make sure no one else relies on it for debugging >> stuff as well. > > Is it still the case that ThreadSanitizer only works with gthread > coroutines? It certainly was very confused about what was going on with the default option (sigucontext IIRC?). > > Stefan -- Alex Bennée