From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francisco Jerez Subject: Re: [PATCH 1/3] drm/i915: Fix command parser to validate multiple register access with the same command. Date: Mon, 31 Aug 2015 01:19:47 +0300 Message-ID: <87fv304dx8.fsf@riseup.net> References: <1432907055-8268-1-git-send-email-currojerez@riseup.net> <000901d09d17$99c5f380$cd51da80$@linux.intel.com> <20150615103559.GX8341@phenom.ffwll.local> <87d20xkyom.fsf@riseup.net> <20150615112622.GJ5176@intel.com> <20150615114048.GD8341@phenom.ffwll.local> <87a8w1kwhn.fsf@riseup.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2003077241==" Return-path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8FF96E0F1 for ; Sun, 30 Aug 2015 15:20:15 -0700 (PDT) In-Reply-To: <87a8w1kwhn.fsf@riseup.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2003077241== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Francisco Jerez writes: > Daniel Vetter writes: > >> On Mon, Jun 15, 2015 at 02:26:22PM +0300, Ville Syrj=C3=A4l=C3=A4 wrote: >>> On Mon, Jun 15, 2015 at 02:18:01PM +0300, Francisco Jerez wrote: >>> > Daniel Vetter writes: >>> >=20 >>> > > On Tue, Jun 02, 2015 at 05:36:26PM +0800, Zhigang Gong wrote: >>> > >> The patchset LGTM and works well with beignet. The 80%+ performanc= e regression issue in darktable also has been fixed >>> > >> after this patchset applied and enable the atomic in L3 at beignet= side. So, >>> > >>=20 >>> > >> Reviewed-by: Zhigang Gong >>> > > >>> > > All three merged. >>> >=20 >>> > Thanks Daniel. >>> >=20 >>> > > Aside: Dont we need an increment for the cmd parser version for >>> > > userspace to be able to detect this? >>> > > >>> > Yeah, that would be a good idea, patch attached. >>>=20 >>> The old version alloweed userspace to write basically any register, the >>> new version allows only the whitelisted registers. I don't see how a >>> version number bump would help anyone. >> >> Oops, totally missed the context of patch 1. Jani I think that one's for >> you too ... >> > IMHO the version bump is still useful for userspace to find out whether > it can use plain LRIs to write the L3 atomic chicken bits. It's true > that as Ville said it would have been possible for userspace to write > the same bits before this series by building a batch specifically > crafted to cheat the command parser, but I don't think we want userspace > to rely on a command parser bug (e.g. because we may want to back-port > the fix to earlier kernel versions). > Ping. I cannot use these registers from userspace until the command parser version number is bumped. >> Thanks for pointing this out. >> -Daniel >> --=20 >> Daniel Vetter >> Software Engineer, Intel Corporation >> http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlXjgYMACgkQg5k4nX1Sv1ttbAD6AmhhfoMT5fYw03+mIUspXb95 3/Gl91kdLJIOvl/eNogA+gOiQMxnk9HO6oR3J3ifPZD9oBYvzsSD09K5EoQQtWRl =xC8G -----END PGP SIGNATURE----- --==-=-=-- --===============2003077241== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============2003077241==--