From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4qRy-0000lj-7K for qemu-devel@nongnu.org; Tue, 16 Jun 2015 08:58:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4qRu-00039K-Dd for qemu-devel@nongnu.org; Tue, 16 Jun 2015 08:58:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4qRu-00039E-94 for qemu-devel@nongnu.org; Tue, 16 Jun 2015 08:58:42 -0400 From: Markus Armbruster References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <1434205258-1932-11-git-send-email-armbru@redhat.com> <557F45EF.5060505@redhat.com> Date: Tue, 16 Jun 2015 14:58:39 +0200 In-Reply-To: <557F45EF.5060505@redhat.com> (Eric Blake's message of "Mon, 15 Jun 2015 15:38:55 -0600") Message-ID: <87fv5rg680.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mdroth@linux.vnet.ibm.com Eric Blake writes: > On 06/13/2015 08:20 AM, Markus Armbruster wrote: >> In particular, don't include it into headers. >> >> Signed-off-by: Markus Armbruster >> --- > >> 46 files changed, 25 insertions(+), 21 deletions(-) > > Assuming this was done by deleting from headers, then adding it into .c > files that no longer compiled. Were there any .c files where it was > unused, and if so, how did you go about finding them? By grepping for > QERR_? Yes, I grepped for QERR_ in addition to compile. Compile can only find missing includes, grep also finds the superfluous ones, and covers code I can't easily compile locally. > Reviewed-by: Eric Blake Thanks!