From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ufb2J-0001Pi-Le for qemu-devel@nongnu.org; Thu, 23 May 2013 15:18:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ufb2I-0000aj-8O for qemu-devel@nongnu.org; Thu, 23 May 2013 15:18:51 -0400 Received: from mail-oa0-f52.google.com ([209.85.219.52]:44732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ufb2I-0000aY-2X for qemu-devel@nongnu.org; Thu, 23 May 2013 15:18:50 -0400 Received: by mail-oa0-f52.google.com with SMTP id h1so5078090oag.11 for ; Thu, 23 May 2013 12:18:49 -0700 (PDT) From: Anthony Liguori In-Reply-To: References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> <1369133851-1894-5-git-send-email-pbonzini@redhat.com> Date: Thu, 23 May 2013 14:18:46 -0500 Message-ID: <87fvxdqzc9.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Paolo Bonzini Cc: David Gibson , qemu-devel@nongnu.org, jan.kiszka@gmail.com Peter Maydell writes: > On 21 May 2013 11:57, Paolo Bonzini wrote: >> It is not used anywhere. > > So does this get deleted just because it's not used, or because > it gets in the way of patches later in the series. As far as I > can tell the st*_phys_notdirty() are for TCG to update page > table entries with accessed/modified bits, and I don't see > any reason we wouldn't have targets that need to update a > 64 bit page table descriptor rather than just 32 bits of it. Unused code is untested code. Untested code is broken code. Someone can add it back later if it's ever needed. Reviewed-by: Anthony Liguori Regards, Anthony Liguori > > thanks > -- PMM