Re: [Buildroot] [PATCH] package/pkg-download: do not try to vendor _EXTRA_DOWNLOADS

[Peter Korsgaard <peter@korsgaard.com>]

>>>>>   <yann.morin@orange.com> writes:

 > From: "Yann E. MORIN" <yann.morin@orange.com>
 > For golang- or cargo-based packages, we apply a vendoring pass after the
 > package's "main" download is done. Whether to vendor or not is based on
 > the heuristic that a specific directory exists or not; for golang
 > packages, we look for '/vendor', while for cargo, we look for '/VENDOR'.

 > This is fine for the "main" (by lack of a better term) download, but
 > this falls flat on its face for extra downloads. Indeed, so packages may
 > need to download data sets, or assets, as _EXTRA_DOWNLOADS. Those are
 > usually just data blobs, and are not actual golang or cargo packages; as
 > such they do not need to be vendored, but worse, if we try to actually
 > vendor them, this fails because the required files for vendoring are
 > missing from the archives in such data sets.

 > We fix that by decoupling the download for the extra download, from the
 > download for the main archive. We pass the post-processing option only
 > to the main download.

 > This makes the hard assumption that extra downloads will never need to
 > be post-processed for vendoring, of course; we hope this will always be
 > correct in practice.

 > Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot