From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B90C433F5 for ; Tue, 26 Apr 2022 09:47:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237257AbiDZJu4 (ORCPT ); Tue, 26 Apr 2022 05:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346496AbiDZJuZ (ORCPT ); Tue, 26 Apr 2022 05:50:25 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 746B12729 for ; Tue, 26 Apr 2022 02:06:57 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id kq17so11555004ejb.4 for ; Tue, 26 Apr 2022 02:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=y8cxzUPeA/1NTAqf+0bELgQgo6NleXzy7R+kj9eBCJI=; b=ielBkO36gl89DCP+MYZspSFloUWilnrjBruJ3vz61LAw8kNiQSjQo/4QD5fVEi1Zk6 Ug1EE5IJsBFEexhG2DL+lpE/+iyQQBQs/pUw0U6Afff27cBGavIHAcN676uUpR/Ib/If VlKzsD2etkR0XS9gXCLc0GSi+qg1BSh5T3+xM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=y8cxzUPeA/1NTAqf+0bELgQgo6NleXzy7R+kj9eBCJI=; b=gqGxqk/S8G5mSfD08OcVl0ladIBTj9CtnV/iv3FKzInm1LkePpv+1mUODrjocoCB0w 0Zo4mJgEPi5yQhoSGQtzuMNsl8N3a6ZUjnGLsCgv7j8kcqzKWpu9qRBbzgyxAsLie2Mz SJzfP0s7pHmLAFTDLZYuIU7XGFa5whHk95GS2+Sz5OHdmGZfL8FlpOZis71gClJ3mNPA acSiOxtVOQDeRrrlSBih1pq+l+TFr80Dkge/frSkQyc9ZlFWmOWyrkb/2B1iwklZps6O 2lx/pzNI5P2GEi0jn2puo15EwABvocEr6kajEP1gma1WdOxnzy7+1p8XZSzrj4iAAjbG fTZw== X-Gm-Message-State: AOAM533X5Dt6HpvobzSmgPceYHkUN0OGLka+cL9CzYToqs9DsIl6I7up NtLQ43VI5MS9J6JPWv63yvzHCA== X-Google-Smtp-Source: ABdhPJy+jKKaj7TJ4z9PfEJpfFFYHuylNp+uJPNooZZcAUZOdhg6ZYZAdPRrunqaGRIme0cEdQGu5g== X-Received: by 2002:a17:907:3e11:b0:6ef:78e3:8d9b with SMTP id hp17-20020a1709073e1100b006ef78e38d9bmr20390515ejc.373.1650964016074; Tue, 26 Apr 2022 02:06:56 -0700 (PDT) Received: from cloudflare.com (79.184.126.143.ipv4.supernova.orange.pl. [79.184.126.143]) by smtp.gmail.com with ESMTPSA id b89-20020a509f62000000b00425e21479fdsm3110541edf.19.2022.04.26.02.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 02:06:55 -0700 (PDT) References: <20220425160803.114851-1-jakub@cloudflare.com> <31702ffb-380f-69f9-ab87-3aec5b22537c@gmail.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Jakub Sitnicki To: Alejandro Colomar Cc: linux-man@vger.kernel.org, bpf@vger.kernel.org, Michael Kerrisk , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Subject: Re: [PATCH] bpf.2: Note that unused fields and padding in bpf_attr must be zero Date: Tue, 26 Apr 2022 11:05:53 +0200 In-reply-to: <31702ffb-380f-69f9-ab87-3aec5b22537c@gmail.com> Message-ID: <87h76g6wnl.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Apr 25, 2022 at 11:01 PM +02, Alejandro Colomar wrote: [...] >> diff --git a/man2/bpf.2 b/man2/bpf.2 >> index 2d257eaa6..ee57226ee 100644 >> --- a/man2/bpf.2 >> +++ b/man2/bpf.2 >> @@ -142,7 +142,7 @@ provided via >> .IR attr , >> which is a pointer to a union of type >> .I bpf_attr >> -(see below). >> +(see below). The unused fields and padding must be zeroed out before the call. > > But I changed it to add a separate line, instead of continuation in the same > one. > Thanks for the fixup, Alex. I will keep it in mind for the next time.