All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/rt-tests: needs __sync_*_4 intrisics
@ 2022-04-05 21:52 Fabrice Fontaine
  2022-04-12 18:32 ` Arnout Vandecappelle
  2022-04-13  7:48 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2022-04-05 21:52 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine, Thomas Petazzoni

rt-tests needs __sync_*_4 intrisics since bump to version 1.9 in commit
32be34427956a590d07d12e965f97fa9d2110ae9 and
https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git/commit/?id=c86dec5765e1ad0bd1d0c429ca7c138c11da2c80:

oslat.c:(.text+0x1034): undefined reference to `__sync_add_and_fetch_4'

Fixes:
 - http://autobuild.buildroot.org/results/9b065ee7611db3a404863b85161f46a2e9e8ddad

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/rt-tests/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
index 47fa7cd840..8efa3d194e 100644
--- a/package/rt-tests/Config.in
+++ b/package/rt-tests/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_RT_TESTS
 	bool "rt-tests"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # __sync_*_4 intrisics
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
 	depends on BR2_USE_MMU # fork(), numactl
@@ -30,6 +31,7 @@ comment "rt-tests may not work on MIPS with an external uClibc toolchain"
 	depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
 
 comment "rt-tests needs a uClibc or glibc toolchain w/ NPTL, headers >= 4.5, dynamic library"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
 		|| BR2_TOOLCHAIN_USES_MUSL || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
 	depends on BR2_USE_MMU
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/rt-tests: needs __sync_*_4 intrisics
  2022-04-05 21:52 [Buildroot] [PATCH 1/1] package/rt-tests: needs __sync_*_4 intrisics Fabrice Fontaine
@ 2022-04-12 18:32 ` Arnout Vandecappelle
  2022-04-13  7:48 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2022-04-12 18:32 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Thomas Petazzoni



On 05/04/2022 23:52, Fabrice Fontaine wrote:
> rt-tests needs __sync_*_4 intrisics since bump to version 1.9 in commit
> 32be34427956a590d07d12e965f97fa9d2110ae9 and
> https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git/commit/?id=c86dec5765e1ad0bd1d0c429ca7c138c11da2c80:
> 
> oslat.c:(.text+0x1034): undefined reference to `__sync_add_and_fetch_4'
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/9b065ee7611db3a404863b85161f46a2e9e8ddad
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/rt-tests/Config.in | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
> index 47fa7cd840..8efa3d194e 100644
> --- a/package/rt-tests/Config.in
> +++ b/package/rt-tests/Config.in
> @@ -1,5 +1,6 @@
>   config BR2_PACKAGE_RT_TESTS
>   	bool "rt-tests"
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # __sync_*_4 intrisics
>   	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>   	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
>   	depends on BR2_USE_MMU # fork(), numactl
> @@ -30,6 +31,7 @@ comment "rt-tests may not work on MIPS with an external uClibc toolchain"
>   	depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
>   
>   comment "rt-tests needs a uClibc or glibc toolchain w/ NPTL, headers >= 4.5, dynamic library"
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>   	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
>   		|| BR2_TOOLCHAIN_USES_MUSL || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
>   	depends on BR2_USE_MMU
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/rt-tests: needs __sync_*_4 intrisics
  2022-04-05 21:52 [Buildroot] [PATCH 1/1] package/rt-tests: needs __sync_*_4 intrisics Fabrice Fontaine
  2022-04-12 18:32 ` Arnout Vandecappelle
@ 2022-04-13  7:48 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-04-13  7:48 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Thomas Petazzoni, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > rt-tests needs __sync_*_4 intrisics since bump to version 1.9 in commit
 > 32be34427956a590d07d12e965f97fa9d2110ae9 and
 > https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git/commit/?id=c86dec5765e1ad0bd1d0c429ca7c138c11da2c80:

 > oslat.c:(.text+0x1034): undefined reference to `__sync_add_and_fetch_4'

 > Fixes:
 >  - http://autobuild.buildroot.org/results/9b065ee7611db3a404863b85161f46a2e9e8ddad

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-13  7:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 21:52 [Buildroot] [PATCH 1/1] package/rt-tests: needs __sync_*_4 intrisics Fabrice Fontaine
2022-04-12 18:32 ` Arnout Vandecappelle
2022-04-13  7:48 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.