From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A37C433F5 for ; Thu, 17 Mar 2022 19:54:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbiCQT4B (ORCPT ); Thu, 17 Mar 2022 15:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbiCQTz5 (ORCPT ); Thu, 17 Mar 2022 15:55:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A203188A0F; Thu, 17 Mar 2022 12:54:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF853618F2; Thu, 17 Mar 2022 19:54:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FFF7C340E9; Thu, 17 Mar 2022 19:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647546877; bh=5hffbwsJCKcVChBEOg9xhWcvocoqaI4B/ouojGPSnrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RxiHc14Zqm22aG9h2QsH8B1KyDqMNIxQAWh7qozUoaDyGZybMVlaajZhcTagUs4BI cqZpS2taU21pOd4f1ZeMvqg1quZaByxuLi/ekn+LfBJ11LfJX8stjRvTsUU79L/K05 goeVTAzqAVZnQ3Vtxa2FQu06QkDEKMoFRJFk6n6HjUjqda/c/OUV1a3zUlSdHxz/JS 1Pqa8+ohcjkATUF8szIEVzbjxV+fnETQ0eOYa4CZ7RnZRESyeKZOphcO44KhshBJsi 1O4K7p3rCY1rE6+KloP9x0ZQbAxxOkecQi/q1AGrgajPjk3hov2K4cay8bUTFCbh51 cO2Lld/mTkZcA== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nUwCg-00FHTs-QI; Thu, 17 Mar 2022 19:54:34 +0000 Date: Thu, 17 Mar 2022 19:54:34 +0000 Message-ID: <87h77wxslh.wl-maz@kernel.org> From: Marc Zyngier To: Kuldeep Singh Cc: Rob Herring , Joel Stanley , Andrew Jeffery , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: Remove arch timer clocks property In-Reply-To: <20220317191527.96237-4-singh.kuldeep87k@gmail.com> References: <20220317191527.96237-1-singh.kuldeep87k@gmail.com> <20220317191527.96237-4-singh.kuldeep87k@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: singh.kuldeep87k@gmail.com, robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Mar 2022 19:15:26 +0000, Kuldeep Singh wrote: > > Arch timer either require clock-frequency property or doesn't need to > specify clock at all in DT. In general, frequency can be determined > internally and in case of brokern firmwares, need to extend > clock-frequency to pass info to driver. A clock frequency and a clock are not the same thing. > > Aspeed BMC is the platform which defines clocks property, an invalid > entry which can be safely removed. Safely removed? Says who? Have you tested this change? > > Moreover, clocks also matches incorrectly with the regex pattern. > Remove this entry altogether to fix it. > 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' NAK. That's not a reason to randomly butcher things. M. > > Signed-off-by: Kuldeep Singh > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index c32e87fad4dc..d5ef9aceb632 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -64,7 +64,6 @@ timer { > , > , > ; > - clocks = <&syscon ASPEED_CLK_HPLL>; > arm,cpu-registers-not-fw-configured; > always-on; > }; > -- > 2.25.1 > > -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C70A1C433F5 for ; Thu, 17 Mar 2022 19:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ig7dV+bxi/01XMIGtayQCJjd+OvSHJZaEF7z6jAx6NI=; b=gW++M5AsdN9uIE qjrQh/PvYTp5qDdNbCCSeLfpQu/NOLbEWL7TTTkaGhBTgyoPvL85eWtOBrHmJmOe+Std/XTZJm0I8 Qff1inJbY2UCx8qjG4tmSOWW7fn7YDcuz2C6KUnOqhYWSYp6kvnfpy8h9Nw4zW0Xgu9Lrj5uuOoYU 4EKYzSIyLy9656amoFdydAAh7WbyueS48CLKwh5M7keaL4ZESsyR4A3mU4DOUshaxjOosmp9uBqxE cifRJtDU4X8v3e50Ce6kdbWL64HmOgBkx+YTTknMmHbdrYnAQbJlalV10ByI9+YXR/+uunTwK4AY4 T/cLZC5hTwZcmAQT9Vvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUwCu-00HEqt-4H; Thu, 17 Mar 2022 19:54:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUwCq-00HEpx-JH for linux-arm-kernel@lists.infradead.org; Thu, 17 Mar 2022 19:54:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D7B45618BB; Thu, 17 Mar 2022 19:54:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FFF7C340E9; Thu, 17 Mar 2022 19:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647546877; bh=5hffbwsJCKcVChBEOg9xhWcvocoqaI4B/ouojGPSnrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RxiHc14Zqm22aG9h2QsH8B1KyDqMNIxQAWh7qozUoaDyGZybMVlaajZhcTagUs4BI cqZpS2taU21pOd4f1ZeMvqg1quZaByxuLi/ekn+LfBJ11LfJX8stjRvTsUU79L/K05 goeVTAzqAVZnQ3Vtxa2FQu06QkDEKMoFRJFk6n6HjUjqda/c/OUV1a3zUlSdHxz/JS 1Pqa8+ohcjkATUF8szIEVzbjxV+fnETQ0eOYa4CZ7RnZRESyeKZOphcO44KhshBJsi 1O4K7p3rCY1rE6+KloP9x0ZQbAxxOkecQi/q1AGrgajPjk3hov2K4cay8bUTFCbh51 cO2Lld/mTkZcA== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nUwCg-00FHTs-QI; Thu, 17 Mar 2022 19:54:34 +0000 Date: Thu, 17 Mar 2022 19:54:34 +0000 Message-ID: <87h77wxslh.wl-maz@kernel.org> From: Marc Zyngier To: Kuldeep Singh Cc: Rob Herring , Joel Stanley , Andrew Jeffery , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: Remove arch timer clocks property In-Reply-To: <20220317191527.96237-4-singh.kuldeep87k@gmail.com> References: <20220317191527.96237-1-singh.kuldeep87k@gmail.com> <20220317191527.96237-4-singh.kuldeep87k@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: singh.kuldeep87k@gmail.com, robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_125444_718535_7ACEE460 X-CRM114-Status: GOOD ( 24.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Mar 2022 19:15:26 +0000, Kuldeep Singh wrote: > > Arch timer either require clock-frequency property or doesn't need to > specify clock at all in DT. In general, frequency can be determined > internally and in case of brokern firmwares, need to extend > clock-frequency to pass info to driver. A clock frequency and a clock are not the same thing. > > Aspeed BMC is the platform which defines clocks property, an invalid > entry which can be safely removed. Safely removed? Says who? Have you tested this change? > > Moreover, clocks also matches incorrectly with the regex pattern. > Remove this entry altogether to fix it. > 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' NAK. That's not a reason to randomly butcher things. M. > > Signed-off-by: Kuldeep Singh > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index c32e87fad4dc..d5ef9aceb632 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -64,7 +64,6 @@ timer { > , > , > ; > - clocks = <&syscon ASPEED_CLK_HPLL>; > arm,cpu-registers-not-fw-configured; > always-on; > }; > -- > 2.25.1 > > -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel